Re: [Patch] Fix gcc.dg/20050922-*.c

2013-11-18 Thread Mike Stump
On Nov 18, 2013, at 3:09 AM, Vidya Praveen wrote: >> Ok, let it bake on trunk and then you can back port it if no one screams. > > I think it has baked long enough. Could this be approved for 4.7 and 4.8 now? Oh, that was pre-approval to back port, conditional on no fallout and no screams… If

Re: Re: [Patch] Fix gcc.dg/20050922-*.c

2013-11-18 Thread Vidya Praveen
Mike, On 25/10/13 00:37, Mike Stump wrote: On Oct 24, 2013, at 2:26 AM, Vidya Praveen wrote: On Mon, Oct 21, 2013 at 06:40:28PM +0100, Mike Stump wrote: On Oct 21, 2013, at 3:28 AM, Vidya Praveen wrote: Tests gcc.dg/20050922-1.c and gcc.dg/20050922-2.c includes stdlib.h. This can be a issue

Re: [Patch] Fix gcc.dg/20050922-*.c

2013-10-25 Thread Hans-Peter Nilsson
On Fri, 25 Oct 2013, Mike Stump wrote: > On Oct 24, 2013, at 7:33 PM, Hans-Peter Nilsson wrote: > > On Thu, 24 Oct 2013, Hans-Peter Nilsson wrote: > >> I too would like to include this change on those branches, as > >> recent generic newlib changes has caused these tests to break > >> (regress) fo

Re: [Patch] Fix gcc.dg/20050922-*.c

2013-10-25 Thread Mike Stump
On Oct 24, 2013, at 7:33 PM, Hans-Peter Nilsson wrote: > On Thu, 24 Oct 2013, Hans-Peter Nilsson wrote: >> On Mon, 21 Oct 2013, Mike Stump wrote: >> >>> On Oct 21, 2013, at 3:28 AM, Vidya Praveen wrote: Tests gcc.dg/20050922-1.c and gcc.dg/20050922-2.c includes stdlib.h. This can

Re: [Patch] Fix gcc.dg/20050922-*.c

2013-10-24 Thread Hans-Peter Nilsson
On Thu, 24 Oct 2013, Hans-Peter Nilsson wrote: > On Mon, 21 Oct 2013, Mike Stump wrote: > > > On Oct 21, 2013, at 3:28 AM, Vidya Praveen wrote: > > > Tests gcc.dg/20050922-1.c and gcc.dg/20050922-2.c includes stdlib.h. This > > > can > > > be a issue especially since they define uint32_t. > > > >

Re: [Patch] Fix gcc.dg/20050922-*.c

2013-10-24 Thread Mike Stump
On Oct 24, 2013, at 2:26 AM, Vidya Praveen wrote: > On Mon, Oct 21, 2013 at 06:40:28PM +0100, Mike Stump wrote: >> On Oct 21, 2013, at 3:28 AM, Vidya Praveen wrote: >>> Tests gcc.dg/20050922-1.c and gcc.dg/20050922-2.c includes stdlib.h. This >>> can >>> be a issue especially since they define u

Re: [Patch] Fix gcc.dg/20050922-*.c

2013-10-24 Thread Hans-Peter Nilsson
On Mon, 21 Oct 2013, Mike Stump wrote: > On Oct 21, 2013, at 3:28 AM, Vidya Praveen wrote: > > Tests gcc.dg/20050922-1.c and gcc.dg/20050922-2.c includes stdlib.h. This > > can > > be a issue especially since they define uint32_t. > > > OK for 4.7, 4.8? > > For release branches, you'd need to

Re: [Patch] Fix gcc.dg/20050922-*.c

2013-10-24 Thread Vidya Praveen
On Mon, Oct 21, 2013 at 05:47:44PM +0100, Jeff Law wrote: > On 10/21/13 04:28, Vidya Praveen wrote: > > Hello, > > > > Tests gcc.dg/20050922-1.c and gcc.dg/20050922-2.c includes stdlib.h. This > > can > > be a issue especially since they define uint32_t. Testcase writing > > guidelines > > discou

Re: [Patch] Fix gcc.dg/20050922-*.c

2013-10-24 Thread Vidya Praveen
On Mon, Oct 21, 2013 at 06:40:28PM +0100, Mike Stump wrote: > On Oct 21, 2013, at 3:28 AM, Vidya Praveen wrote: > > Tests gcc.dg/20050922-1.c and gcc.dg/20050922-2.c includes stdlib.h. This > > can > > be a issue especially since they define uint32_t. > > > OK for 4.7, 4.8? > > For release bran

Re: [Patch] Fix gcc.dg/20050922-*.c

2013-10-21 Thread Mike Stump
On Oct 21, 2013, at 3:28 AM, Vidya Praveen wrote: > Tests gcc.dg/20050922-1.c and gcc.dg/20050922-2.c includes stdlib.h. This can > be a issue especially since they define uint32_t. > OK for 4.7, 4.8? For release branches, you'd need to transition from the theoretical to the practical. On whic

Re: [Patch] Fix gcc.dg/20050922-*.c

2013-10-21 Thread Jeff Law
On 10/21/13 04:28, Vidya Praveen wrote: Hello, Tests gcc.dg/20050922-1.c and gcc.dg/20050922-2.c includes stdlib.h. This can be a issue especially since they define uint32_t. Testcase writing guidelines discourages such inclusion as well. This patch replaces these #includes with manual declarat