Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-11 Thread Ramana Radhakrishnan
On 10/05/15 23:16, Martin Galvan wrote: Hi Ramana! Sorry to bother, but I looked at the repository and didn't see this committed. As I don't have write access could you please commit this for me? Thanks a lot! sorry about the slow response, I was travelling for a bit and missed your emails

Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-12 Thread Ramana Radhakrishnan
On 11/05/15 20:44, Martin Galvan wrote: On Mon, May 11, 2015 at 4:45 AM, Ramana Radhakrishnan wrote: sorry about the slow response, I was travelling for a bit and missed your emails. Trying your patch out gives me failures possibly because my mail client munged it when it received this inlin

Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-12 Thread Martin Galvan
On Tue, May 12, 2015 at 5:49 AM, Ramana Radhakrishnan wrote: > That's what I mean when I say email clients "munged it" : email clients and > / or some popular email servers appear to end up munging white spaces and > patches don't apply cleanly. > > So, no it doesn't work - once you've sent it thr

Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-13 Thread Ramana Radhakrishnan
On 12/05/15 14:01, Martin Galvan wrote: On Tue, May 12, 2015 at 5:49 AM, Ramana Radhakrishnan wrote: That's what I mean when I say email clients "munged it" : email clients and / or some popular email servers appear to end up munging white spaces and patches don't apply cleanly. So, no it do

Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-13 Thread Ramana Radhakrishnan
On 13/05/15 17:37, Ramana Radhakrishnan wrote: On 12/05/15 14:01, Martin Galvan wrote: On Tue, May 12, 2015 at 5:49 AM, Ramana Radhakrishnan wrote: That's what I mean when I say email clients "munged it" : email clients and / or some popular email servers appear to end up munging white spa

Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-13 Thread Martin Galvan
On Wed, May 13, 2015 at 1:58 PM, Ramana Radhakrishnan wrote: > On 13/05/15 17:37, Ramana Radhakrishnan wrote: >> I'm not sure what's going on here and couldn't figure out what was going >> wrong in the 20 minutes I spent on it just now. >> > Bah, I must be going blind. > >> >> @@ -53,11 +57,13 @@

Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-13 Thread Marek Polacek
On Wed, May 13, 2015 at 02:07:34PM -0300, Martin Galvan wrote: > That makes sense. I downloaded the gcc sources from the git mirror at > github-- perhaps that's what's munging the patch? That mirror seems to be out-of-date. I suggest using .

Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-13 Thread Martin Galvan
Here's the new patch. I downloaded the gcc sources from the SVN repository, removed the extra semicolon from my version of the files and re-generated the patch using svn diff, making sure the context info had all the tabs from the original. I then e-mailed the patch to myself as an attachment, appl

Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-13 Thread Martin Galvan
Forgot to mention: I first did a --dry-run of the patch and then applied it to the gcc sources. On Wed, May 13, 2015 at 3:11 PM, Martin Galvan wrote: > Here's the new patch. I downloaded the gcc sources from the SVN > repository, removed the extra semicolon from my version of the files > and re-g

Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-15 Thread Ramana Radhakrishnan
On 13/05/15 19:11, Martin Galvan wrote: Here's the new patch. I downloaded the gcc sources from the SVN repository, removed the extra semicolon from my version of the files and re-generated the patch using svn diff, making sure the context info had all the tabs from the original. I then e-maile

Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-15 Thread Martin Galvan
On Fri, May 15, 2015 at 1:58 PM, Ramana Radhakrishnan wrote: > Thanks for doing this now the patch looks much better and I can apply it ! > Unfortunately there are still problems with it and I'm not sure about your > testing procedures. > >> >> >> mov ip, r0 >> mov r0, r2 >

Re: Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-11 Thread Martin Galvan
On Mon, May 11, 2015 at 4:45 AM, Ramana Radhakrishnan wrote: > sorry about the slow response, I was travelling for a bit and missed your > emails. Trying your patch out gives me failures possibly because my mail > client munged it when it received this inline. > > Can you please rebase if necessa