Re: asan: support for globals in kernel

2014-12-05 Thread Andrey Ryabinin
On 12/04/2014 10:10 PM, Dmitry Vyukov wrote: > On Wed, Dec 3, 2014 at 9:19 AM, Andrey Ryabinin > wrote: >> On 12/02/2014 08:56 PM, Dmitry Vyukov wrote: >>> Hi, >>> >>> The following patch adds support for instrumentation of globals for >>> Linux kernel (-fsanitize=kernel-address). Kernel only sup

Re: asan: support for globals in kernel

2014-12-04 Thread Dmitry Vyukov
will wait for Andrey this time On Thu, Dec 4, 2014 at 10:12 PM, Jakub Jelinek wrote: > On Thu, Dec 04, 2014 at 11:10:15PM +0400, Dmitry Vyukov wrote: >> That would be an option too. I don't know whether it is much better or not. >> Kernel lives without constructors, they are used only by coverag

Re: asan: support for globals in kernel

2014-12-04 Thread Jakub Jelinek
On Thu, Dec 04, 2014 at 11:10:15PM +0400, Dmitry Vyukov wrote: > That would be an option too. I don't know whether it is much better or not. > Kernel lives without constructors, they are used only by coverage. And > coverage does not need priorities. So it is only kasan that needs > priorities. Tha

Re: asan: support for globals in kernel

2014-12-04 Thread Dmitry Vyukov
On Wed, Dec 3, 2014 at 9:19 AM, Andrey Ryabinin wrote: > On 12/02/2014 08:56 PM, Dmitry Vyukov wrote: >> Hi, >> >> The following patch adds support for instrumentation of globals for >> Linux kernel (-fsanitize=kernel-address). Kernel only supports >> constructors with default priority, but the re

Re: asan: support for globals in kernel

2014-12-02 Thread Andrey Ryabinin
On 12/02/2014 08:56 PM, Dmitry Vyukov wrote: > Hi, > > The following patch adds support for instrumentation of globals for > Linux kernel (-fsanitize=kernel-address). Kernel only supports > constructors with default priority, but the rest works fine. > > OK for trunk? > I know this is too late

Re: asan: support for globals in kernel

2014-12-02 Thread Dmitry Vyukov
On Tue, Dec 2, 2014 at 9:17 PM, Jakub Jelinek wrote: > On Tue, Dec 02, 2014 at 10:12:30PM +0400, Dmitry Vyukov wrote: >> > Shall we backport it to 4.9 branch too? >> >> If it's doable, it would be nice. Thanks. > > Bet the same patch will just apply there. Do I need to do anything additional for

Re: asan: support for globals in kernel

2014-12-02 Thread Jakub Jelinek
On Tue, Dec 02, 2014 at 10:12:30PM +0400, Dmitry Vyukov wrote: > > Shall we backport it to 4.9 branch too? > > If it's doable, it would be nice. Thanks. Bet the same patch will just apply there. > When do we expect next 4.9 release? Probably in March/April timeframe or so, 4.9.2 has been releas

Re: asan: support for globals in kernel

2014-12-02 Thread Dmitry Vyukov
On Tue, Dec 2, 2014 at 9:04 PM, Jakub Jelinek wrote: > On Tue, Dec 02, 2014 at 09:56:36PM +0400, Dmitry Vyukov wrote: >> --- gcc/ChangeLog (revision 218280) >> +++ gcc/ChangeLog (working copy) >> @@ -1,3 +1,8 @@ >> +2014-12-02 Dmitry Vyukov >> + >> + * asan.c: (asan_finish_file): Use default pr

Re: asan: support for globals in kernel

2014-12-02 Thread Jakub Jelinek
On Tue, Dec 02, 2014 at 09:56:36PM +0400, Dmitry Vyukov wrote: > --- gcc/ChangeLog (revision 218280) > +++ gcc/ChangeLog (working copy) > @@ -1,3 +1,8 @@ > +2014-12-02 Dmitry Vyukov > + > + * asan.c: (asan_finish_file): Use default priority for constructors > + in kernel mode. Seems your MUA is

asan: support for globals in kernel

2014-12-02 Thread Dmitry Vyukov
Hi, The following patch adds support for instrumentation of globals for Linux kernel (-fsanitize=kernel-address). Kernel only supports constructors with default priority, but the rest works fine. OK for trunk? https://codereview.appspot.com/176570043 Index: gcc/ChangeLog ==