Re: structurally compare type_arg_packs [93933]

2020-02-27 Thread Jason Merrill
On 2/27/20 10:33 AM, Nathan Sidwell wrote: On 2/26/20 5:00 PM, Jason Merrill wrote: On 2/25/20 4:09 PM, Nathan Sidwell wrote: We consider all TYPE_ARGUMENT_PACKS distinct types, leading to problems with redeclarations. I'd think that the bug is that we're treating them as types in the first

Re: structurally compare type_arg_packs [93933]

2020-02-27 Thread Nathan Sidwell
On 2/26/20 5:00 PM, Jason Merrill wrote: On 2/25/20 4:09 PM, Nathan Sidwell wrote: We consider all TYPE_ARGUMENT_PACKS distinct types, leading to problems with redeclarations. I'd think that the bug is that we're treating them as types in the first place; they aren't types, so they shouldn't

Re: structurally compare type_arg_packs [93933]

2020-02-26 Thread Jason Merrill
On 2/25/20 4:09 PM, Nathan Sidwell wrote: We consider all TYPE_ARGUMENT_PACKS distinct types, leading to problems with redeclarations. This patch fixes things by: a) marking all such types for structural comparison b) teaching structural_comptypes how to compare them. 1) It appears that

structurally compare type_arg_packs [93933]

2020-02-25 Thread Nathan Sidwell
We consider all TYPE_ARGUMENT_PACKS distinct types, leading to problems with redeclarations. This patch fixes things by: a) marking all such types for structural comparison b) teaching structural_comptypes how to compare them. 1) It appears that NONTYPE_ARGUMENT_PACKS just work, I think