testsuite allocators patch

2014-06-20 Thread François Dumont
Hi I would like to finally propose this patch before the one on _Rb_tree, as a separate one. I have adopted the same evolution on the tracker_allocator with even a perfect forwarding constructor to allow its usage on top of the uneq_allocator which take a personality parameter. Doin

Re: testsuite allocators patch

2014-06-25 Thread François Dumont
Hi With the patch this time. I would like to finally propose this patch before the one on _Rb_tree, as a separate one. I have adopted the same evolution on the tracker_allocator with even a perfect forwarding constructor to allow its usage on top of the uneq_allocator which t

Re: testsuite allocators patch

2014-06-26 Thread Jonathan Wakely
On 25/06/14 21:47 +0200, François Dumont wrote: I would like to finally propose this patch before the one on _Rb_tree, as a separate one. I have adopted the same evolution on the tracker_allocator with even a perfect forwarding constructor to allow its usage on top of the uneq_allocator

Re: testsuite allocators patch

2014-06-26 Thread François Dumont
On 26/06/2014 12:33, Jonathan Wakely wrote: The _GLIBCXX_USE_NOEXCEPT macro expands to nothing in C++03 mode, so you might as well omit it in the #else branch. OK for trunk if you make the tracker_allocator comment correct. Thanks! Committed with: // An allocator facade that intercepts

Re: testsuite allocators patch

2014-06-26 Thread Paolo Carlini
Hi, I'm afraid something went badly wrong with this commit, I'm seeing tens of fails. See eg: https://gcc.gnu.org/ml/gcc-testresults/2014-06/msg02439.html Paolo.

Re: testsuite allocators patch

2014-06-26 Thread Jonathan Wakely
On 26/06/14 23:21 +0200, Paolo Carlini wrote: Hi, I'm afraid something went badly wrong with this commit, I'm seeing tens of fails. See eg: https://gcc.gnu.org/ml/gcc-testresults/2014-06/msg02439.html It seems that uneq_allocator is no longer copy constructible.

Re: testsuite allocators patch

2014-06-27 Thread Paolo Carlini
Hi, On 06/27/2014 12:38 AM, Jonathan Wakely wrote: On 26/06/14 23:21 +0200, Paolo Carlini wrote: Hi, I'm afraid something went badly wrong with this commit, I'm seeing tens of fails. See eg: https://gcc.gnu.org/ml/gcc-testresults/2014-06/msg02439.html It seems that uneq_allocator is no

Re: testsuite allocators patch

2014-06-27 Thread Jonathan Wakely
I didn't see an obvious fix (I'm not sure if the templated constructor can deduce its argument since the change) but have been out all day and not had a chance to look into it. On 27 June 2014 08:27, Paolo Carlini wrote: > Hi, > > > On 06/27/2014 12:38 AM, Jonathan Wakely wrote: >> >> On 26/06/14

Re: testsuite allocators patch

2014-06-27 Thread Paolo Carlini
Hi, On 06/27/2014 07:33 PM, Jonathan Wakely wrote: I didn't see an obvious fix (I'm not sure if the templated constructor can deduce its argument since the change) but have been out all day and not had a chance to look into it. Ok, thanks. I'm reverting the last two libstdc++-v3 commits. Paolo

Re: testsuite allocators patch

2014-06-27 Thread François Dumont
On 27/06/2014 21:48, Paolo Carlini wrote: Hi, On 06/27/2014 07:33 PM, Jonathan Wakely wrote: I didn't see an obvious fix (I'm not sure if the templated constructor can deduce its argument since the change) but have been out all day and not had a chance to look into it. Ok, thanks. I'm revertin

Re: testsuite allocators patch

2014-07-23 Thread François Dumont
On 27/06/2014 21:48, Paolo Carlini wrote: Hi, On 06/27/2014 07:33 PM, Jonathan Wakely wrote: I didn't see an obvious fix (I'm not sure if the templated constructor can deduce its argument since the change) but have been out all day and not had a chance to look into it. Ok, thanks. I'm revertin

Re: testsuite allocators patch

2014-07-24 Thread Jonathan Wakely
On 23/07/14 22:33 +0200, François Dumont wrote: I have a small question regarding some code next to the one I am modifying in this patch. I can see lines like: propagating_allocator() noexcept = default; When using a default implementation shouldn't we let the compiler decide if it

Re: testsuite allocators patch

2014-07-24 Thread François Dumont
On 24/07/2014 10:55, Jonathan Wakely wrote: On 23/07/14 22:33 +0200, François Dumont wrote: I have a small question regarding some code next to the one I am modifying in this patch. I can see lines like: propagating_allocator() noexcept = default; When using a default implementatio

Re: testsuite allocators patch

2014-07-24 Thread Jonathan Wakely
On 24 July 2014 21:11, François Dumont wrote: > > Yes I have tested with no other changes in my tree and got only those pretty > printers errors which are unrelated I think: > > Python Exception iter() returned non-iterator of type > '_contained': > $2 = std::experimental::optional [no contained v

Re: testsuite allocators patch

2014-07-29 Thread Jonathan Wakely
On 23/07/14 22:33 +0200, François Dumont wrote: On 27/06/2014 21:48, Paolo Carlini wrote: Hi, On 06/27/2014 07:33 PM, Jonathan Wakely wrote: I didn't see an obvious fix (I'm not sure if the templated constructor can deduce its argument since the change) but have been out all day and not had a

Re: testsuite allocators patch

2014-07-29 Thread Jonathan Wakely
On 25/07/14 00:19 +0100, Jonathan Wakely wrote: On 24 July 2014 21:11, François Dumont wrote: Yes I have tested with no other changes in my tree and got only those pretty printers errors which are unrelated I think: Python Exception iter() returned non-iterator of type '_contained': $2 = std:

Re: testsuite allocators patch

2014-07-29 Thread Jonathan Wakely
On 29/07/14 22:33 +0100, Jonathan Wakely wrote: Tested x86_64-linux (thanks to Samual Bronson for testing with Python3) and committed to trunk. Oops, Samuel not Samual ... no idea why my fingers typed that wrong!