[PATCH] Fix PR ipa/65439

2015-03-18 Thread Martin Liška
Hi. This is fix for PR65439 which extends number of expected equivalences for IPA ICF that can be different on darwin target. Ready for trunk? Thanks Martin From 1fb6c73e6ee74a2923aaccbac9658b46005aeba5 Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Wed, 18 Mar 2015 09:52:29 +0100

Re: [PATCH] Fix PR ipa/65432

2015-03-18 Thread Martin Liška
TOn 03/18/2015 02:33 PM, Richard Biener wrote: On Wed, Mar 18, 2015 at 2:24 PM, Martin Liška mli...@suse.cz wrote: Hello. Following patch wraps symtab_node::{asm_}name with xstrdup_for_dump. Ready for trunk? /* Gets symbol name of the item. */ const char *name (void

Re: [PATCH] Fix PR ipa/65432

2015-03-18 Thread Martin Liška
On 03/18/2015 03:05 PM, Jakub Jelinek wrote: On Wed, Mar 18, 2015 at 02:59:10PM +0100, Martin Liška wrote: From 5d2e883524ba23155d80cd4ad6d58ba5c73a1f90 Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Wed, 18 Mar 2015 13:59:49 +0100 Subject: [PATCH] Fix PR ipa/65432 gcc/ChangeLog

Re: [PATCH] Fix PR ipa/65439

2015-03-18 Thread Martin Liška
On 03/18/2015 02:06 PM, Martin Liška wrote: Hi. Sorry for previous mail, which has wrongly assigned To address. Original message: This is fix for PR65439 which extends number of expected equivalences for IPA ICF that can be different on darwin target. Ready for trunk? Thanks Martin I've

Re: [PATCH] Speed-up IPA ICF by enhanced hash values

2015-03-22 Thread Martin Liška
On 03/19/2015 09:42 PM, Jan Hubicka wrote: diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c index f68d23c..b8e3aa4 100644 --- a/gcc/ipa-icf.c +++ b/gcc/ipa-icf.c @@ -557,6 +557,69 @@ sem_function::equals_wpa (sem_item *item, return true; } +/* Update hash by address sensitive

Re: [PATCH] Speed-up def_builtin_const (ix86_valid_target_attribute)

2015-03-20 Thread Martin Liška
On 03/20/2015 01:10 AM, Jan Hubicka wrote: Hi. Explanation of the patch is introduced. thanks mask = ~OPTION_MASK_ISA_64BIT; if (mask == 0 @@ -30670,6 +30673,14 @@ def_builtin_const (HOST_WIDE_INT mask, const char *name, static void ix86_add_new_builtins

Re: [PATCH] Speed-up def_builtin_const (ix86_valid_target_attribute)

2015-03-20 Thread Martin Liška
On 03/20/2015 12:24 PM, Jakub Jelinek wrote: On Fri, Mar 20, 2015 at 11:33:09AM +0100, Martin Liška wrote: @@ -30670,6 +30673,20 @@ def_builtin_const (HOST_WIDE_INT mask, const char *name, static void ix86_add_new_builtins (HOST_WIDE_INT isa) { + /* Last cached isa value. */ + static

[PATCH] Fix PR ipa/65380

2015-03-19 Thread Martin Liška
Hello. This is fix for the issue as introduced by Honza. I've just finished testing on x86_64-linux-pc and the patch is pre-approved by Honza. Thanks, Martin From f3c845d74b7a1edbbba9ecefa081feb58700d515 Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Thu, 19 Mar 2015 10:52:44 +0100

[PATCH] Speed-up IPA ICF by enhanced hash values

2015-03-19 Thread Martin Liška
Hi. Following patch improves performance by adding hash values of references that are not candidates for IPA ICF. Tested on x86_64-linux-pc w/o any new regression observed. Ready for trunk? Thanks, Martin From 6c04cc4283d08a8aa9829574dd91579a918cb508 Mon Sep 17 00:00:00 2001 From: marxin

Re: [PATCH] Fix PR ipa/65465

2015-03-19 Thread Martin Liška
On 03/19/2015 06:13 PM, Jakub Jelinek wrote: On Thu, Mar 19, 2015 at 06:08:03PM +0100, Martin Liška wrote: From 1b0416658cf59348664d44b14518c994075fd9bd Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Thu, 19 Mar 2015 15:36:34 +0100 Subject: [PATCH] Fix for PR ipa/65465. gcc

[PATCH] Fix PR ipa/65465

2015-03-19 Thread Martin Liška
Hello. Following patch is fix for the PR. Problem is caused if we fill up cgraph_thunk_info with some values (e.g. virtual_value != 0) and further analysis set thunk_p = false. In all situations IPA ICF needs to reset all fields of the struct as it sets thunk_p = true. Tested on

Re: [PATCH] Speed-up def_builtin_const (ix86_valid_target_attribute)

2015-03-19 Thread Martin Liška
On 03/13/2015 05:42 AM, Jan Hubicka wrote: 2015-03-09 Martin Liska marxin.li...@gmail.com * config/i386/i386.c (def_builtin): Collect union of all possible masks. (ix86_add_new_builtins): Do not iterate over all builtins in cases that isa value has no

[PATCH] Speed-up def_builtin_const (ix86_valid_target_attribute)

2015-03-09 Thread Martin Liška
Hello. During compilation of Chromium project, I noticed (perf top) that ix86_valid_target_attribute is utilized by about 0.8-1.9%. Following patch introduces simple optimization that reduces the utilization to ~0.05%. Tests have been running on x86_64-linux-pc. Ready for trunk? Martin From

[PATCH] Fix PR65538

2015-03-24 Thread Martin Liška
Hi. In following patch, I've added missing delete call for all item summaries that are allocated within a function_summary container in case the container does not use GGC memory allocation. Can boostrap on ppc64le and no regression is seen on x86_64-linux-pc. Ready for trunk? Thanks, Martin

Re: [PATCH] Fix PR65538

2015-03-24 Thread Martin Liška
On 03/24/2015 06:38 PM, Jan Hubicka wrote: Hi. In following patch, I've added missing delete call for all item summaries that are allocated within a function_summary container in case the container does not use GGC memory allocation. Can boostrap on ppc64le and no regression is seen on

[PATCH] IPA ICF: make hash values finer

2015-03-24 Thread Martin Liška
Hello. Following patch should be final speed-up patch for IPA ICF. It just basically enhances hash values of a symbol, computed in a TU. Having finer hash values, we do not spend so much time in WPA phase. It shows, we can reduce utilization from 14% - 9% (_w/o_ WPA streaming out). Time report

[PATCH] Fix PR ipa/65557

2015-03-30 Thread Martin Liška
Hello. Following patch fixed the issue, where we have to check if function summary for IPA CP has been already created. Tested on x86_64-linux-pc w/o any new regression introduced. Ready for trunk? Thanks, Martin From c33680093e67328863836a845e847bf1b1b23d0e Mon Sep 17 00:00:00 2001

Re: [PATCH] Fix PR ipa/65557

2015-03-30 Thread Martin Liška
On 03/30/2015 07:03 PM, Jan Hubicka wrote: Hello. Following patch fixed the issue, where we have to check if function summary for IPA CP has been already created. Tested on x86_64-linux-pc w/o any new regression introduced. Ready for trunk? Thanks, Martin From

Re: [PATCH] Fix PR ipa/65087

2015-03-03 Thread Martin Liška
On 03/02/2015 06:20 PM, Jan Hubicka wrote: Hello. Following one line patch is fix for PR ipa/65087. No regression has been seen on x86_64-linux-pc. OK, it won't happend large programs, but can you arrange its execute method to return TODO_remove_functions only if some merging actually

Re: [PATCH] Fix PR ipa/65087

2015-03-03 Thread Martin Liška
On 03/03/2015 10:50 AM, Marek Polacek wrote: On Tue, Mar 03, 2015 at 10:31:17AM +0100, Martin Liška wrote: @@ -2952,9 +2959,12 @@ sem_item_optimizer::merge_classes (unsigned int prev_class_count) alias-dump_to_file (dump_file); } - source-merge (alias

[PATCH] ICF: move readonly decision for variables to the right place

2015-02-28 Thread Martin Liška
Hello. This patch makes correctly decision about variables that are read-only and are candidates for merge operation. Tested on x86_64-unknown-linux-gnu. Ready for trunk? Thanks, Martin From 72370368eb04a69bf36b42f692d44c21592bc94a Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Fri,

Re: [PATCH] ICF is more strict about non-common function and var, attributes.

2015-02-28 Thread Martin Liška
On 02/28/2015 11:42 PM, Jan Hubicka wrote: 2015-02-28 Martin Liska mli...@suse.cz Jan Hubicka hubi...@ucw.cz * ipa-icf-gimple.c (func_checker::compare_variable_decl): Validate variable alignment. * ipa-icf.c (sem_function::equals_private): Be more precise

[PATCH] ICF is more strict about non-common function and var, attributes.

2015-02-28 Thread Martin Liška
Hello. Following patch is guard for special non-common function attributes that can be spotted by ICF machinery. Tested on x86_64-linux. Ready for trunk? Thanks, Martin From 13e8c55b6317bf4e2c21ef04305cb3a20ad51255 Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Fri, 27 Feb 2015

[PATCH] Fix for PR ipa/65245

2015-02-28 Thread Martin Liška
Hello. Following patch skips all variable aliases as potential merge candidates. Tested on x86_64-linux. Ready for trunk? Thanks, Martin From fbde2e98f98a71105d18cf3e91e8032d0c657139 Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Fri, 27 Feb 2015 22:42:49 +0100 Subject: [PATCH 2/4]

Re: [PATCH] ICF: move readonly decision for variables to the right place

2015-03-02 Thread Martin Liška
On 03/02/2015 08:53 AM, Jan Hubicka wrote: Hi, this is a variant of patch I commited. It takes care to load the constructor to memory in sem_variable::equals and donot touch it earlier. I also made sem_variable::parse to skip volatile and reigster variables. Bootstrapped/regtested

[PATCH] Fix PR ipa/65087

2015-03-02 Thread Martin Liška
Hello. Following one line patch is fix for PR ipa/65087. No regression has been seen on x86_64-linux-pc. Ready for trunk? Thanks, Martin From f39be56c66387c698546c498550d38512ddeb477 Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Mon, 2 Mar 2015 16:56:42 +0100 Subject: [PATCH] Fix

[PATCH] Fix PR ipa/65263

2015-03-02 Thread Martin Liška
Hello. This is suggested patch for the PR. Tested on x86_64-unknown-linux-pc. Ready for trunk? Thanks, Martin From c0f86505df4519b555f110d8c9d320c17b9fcfd9 Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Mon, 2 Mar 2015 14:15:30 +0100 Subject: [PATCH] Fix PR ipa/65263.

Re: ipa-icf::merge TLC

2015-02-27 Thread Martin Liška
On 02/27/2015 07:04 PM, Steve Ellcey wrote: Following up to my own email. I can reproduce this with the following cut down test case if I compile with '-O2 -fmerge-all-constants' on MIPS. extern const char *const _sys_siglist[128]; const char *const __new_sys_siglist[128] = { }; extern

Re: [PATCH] Fix for PR ipa/64693

2015-02-27 Thread Martin Liška
On 02/26/2015 07:21 PM, Jan Hubicka wrote: 2015-02-25 Martin Liska mli...@suse.cz Jan Hubicka hubi...@ucw.cz PR ipa/64693 * ipa-icf.c (symbol_compare_collection::symbol_compare_collection): New. (sem_item_optimizer::subdivide_classes_by_sensitive_refs):

[PATCH] Fix PR ipa/65318

2015-03-05 Thread Martin Liška
Hello. This is patch that prevents merge operation for ICF on variables types which are not compatible. Regression tests were run on x86_64-linux-pc. Ready for trunk? Thanks, Martin From b92ec230162b99ff11d4e5688f63ae978e75af12 Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Thu, 5

Re: [PATCH] Workaround -Wmaybe-uninitialized false positives during profiledbootstrap

2015-03-04 Thread Martin Liška
On 01/27/2015 01:31 PM, Martin Liška wrote: On 01/27/2015 05:23 AM, DJ Delorie wrote: +/* Workaround -Wstrict-overflow false positive during profiledbootstrap. */ + +# if GCC_VERSION = 4004 +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored -Wstrict-overflow +#endif + #pragma

Re: [PATCH] Fix for PR ipa/65245

2015-03-01 Thread Martin Liška
On 02/28/2015 11:41 PM, Jan Hubicka wrote: Hello. Following patch skips all variable aliases as potential merge candidates. Tested on x86_64-linux. Ready for trunk? Thanks, Martin From fbde2e98f98a71105d18cf3e91e8032d0c657139 Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date:

Re: [PATCH] Fix PR ipa/65318

2015-03-05 Thread Martin Liška
On 03/05/2015 03:29 PM, Marek Polacek wrote: On Thu, Mar 05, 2015 at 02:53:44PM +0100, Martin Liška wrote: --- a/gcc/ipa-icf.c +++ b/gcc/ipa-icf.c @@ -1501,6 +1501,11 @@ sem_variable::equals (sem_item *item, if (DECL_INITIAL (item-decl) == error_mark_node in_lto_p) dyn_cast

[PATCH] Fix PR ipa/65287

2015-03-03 Thread Martin Liška
Hello. There's suggested patch for the issue that survives regression tests on x86_64-linux-pc. Ready for trunk? Thanks, Martin From d4e9d2906a90151d1239e7b32b00f7cb46b045fa Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Tue, 3 Mar 2015 10:36:59 +0100 Subject: [PATCH] Fix PR

[PATCH] Fix PR ipa/65282

2015-03-03 Thread Martin Liška
Hello. There's suggested patch for the issue, where regression test have been running on x86_64-linux-pc. Ready for trunk after tests will be finished? Thanks, Martin From a186fc97c5f192b94cc571f611a50eb0f4f8a354 Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Tue, 3 Mar 2015

Re: [PATCH] Fix for PR ipa/64693

2015-02-25 Thread Martin Liška
On 02/20/2015 07:39 PM, Jan Hubicka wrote: Hello. There's updated version that reflects how should we handle congruence classes that have any address reference. Patch can bootstrap x86_64-linux-pc and no new regression is introduced? Ready for trunk? Thanks, Martin From

[PATCH] ICF: handle correctly hard register variables

2015-02-25 Thread Martin Liška
Hello. This patch adds support for hard register variables in ICF and it's pre-approved by Honza, I'm going to install the patch. No regressing on x86_64-linux-pc. Thanks, Martin From eff93050904e0aeaf26b47fb1d1e8eeb803f9af6 Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Wed, 25

Re: [PATCH] Fix for PR ipa/64693

2015-02-25 Thread Martin Liška
On 02/25/2015 06:00 PM, Jan Hubicka wrote: Hello Honza. I've updated the patch so that your notes are resolved. Moreover, I've added comparison for interposable symbols that are either target of reference or are called by a function. Please read the patch to verify the comparison is as you

Re: ipa-icf::merge TLC

2015-02-25 Thread Martin Liška
On 02/25/2015 06:15 PM, Jan Hubicka wrote: On 2015.02.25 at 09:38 +0100, Jan Hubicka wrote: this patch reorganize sem_function::merge and sem_variable::merge. I read the code in detail and found several issues that are fixed in the following patch. I gave your patch a quick spin. It breaks

Re: [PATCH] Fix for PR ipa/64693

2015-02-26 Thread Martin Liška
On 02/25/2015 07:46 PM, Jan Hubicka wrote: From dd240028726cb7fdc777acd0b6d14c4f89aed714 Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Thu, 19 Feb 2015 16:08:09 +0100 Subject: [PATCH 1/3] Fix PR ipa/64693 2015-02-25 Martin Liska mli...@suse.cz Jan Hubicka

[PATCH] GCC LTO-bootstrap -Wodr fix

2015-02-26 Thread Martin Liška
Hello. Following error message can be seen for LTO boostrap: ../../gcc/fortran/resolve.c:3812:1: error: type ‘comparison’ violates one definition rule [-Werror=odr] comparison; ^ ../../gcc/compare-elim.c:95:0: note: a different type is defined in another translation unit rtx_insn *insn;

Re: [PATCH] Fix PR65538

2015-03-25 Thread Martin Liška
On 03/25/2015 12:37 AM, Jan Hubicka wrote: On Tue, Mar 24, 2015 at 10:54:25PM +0100, Martin Liška wrote: --- a/gcc/symbol-summary.h +++ b/gcc/symbol-summary.h @@ -81,6 +81,12 @@ public: m_symtab_insertion_hook = NULL; m_symtab_removal_hook = NULL; m_symtab_duplication_hook

[PATCH] Vimrc config: fix symlink creation

2015-03-25 Thread Martin Liška
Hello. Following patch correctly creates symlink that now points to a wrong location. Ready for trunk? Thanks, Martin From 5681b55f531f579ba75aad21f5628f86fba4bc8a Mon Sep 17 00:00:00 2001 From: mliska mli...@suse.cz Date: Wed, 25 Mar 2015 10:09:21 +0100 Subject: [PATCH] Fix vimrc file link

Fix PR ipa/64693

2015-01-23 Thread Martin Liška
Hello. Following patch is a fix for PR ipa/64693, where ICF merges a pair of functions that somehow take a references to a different functions. Unfortunately, such function pointer can be used for function comparison that can break an executable. Tested on x86_64-linux-pc and no regression is

[PATCH] IPA ICF: handle IMAGPART_EXPR and REALPART_EXPR

2015-01-13 Thread Martin Liška
Hello. As pointed out in the following PR64307, IPA ICF is missing support for aforementioned TREE types. Apart from that, the patch also fixes BIT_FIELD_REF, which was broken. Tested on x86_64-linux-pc and no regression has been seen. Ready for trunk? Thanks, Martin From

[PATCH] Fix PR ipa/64858

2015-01-30 Thread Martin Liška
Hi. Attached patch handles situation where remove_unreachable_nodes is called before IPA ICF registers removal hooks. As a result, a deleted callgraph node is touched. Tested on x86_64-linux-pc without a new regression seen. Ready for trunk? Thanks, Martin From

Re: [PATCH] Workaround -Wmaybe-uninitialized false positives during profiledbootstrap

2015-01-30 Thread Martin Liška
On 01/27/2015 01:31 PM, Martin Liška wrote: On 01/27/2015 05:23 AM, DJ Delorie wrote: +/* Workaround -Wstrict-overflow false positive during profiledbootstrap. */ + +# if GCC_VERSION = 4004 +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored -Wstrict-overflow +#endif + #pragma

[PATCH] Fix PR ipa/65665

2015-04-03 Thread Martin Liška
Hello. Following patch fixes a new issue, ICE has disappeared on aarch64-linux machine and I was able to boostrap on the machine. Moreover, no new regression seen on x86_64-linux-pc. Ready for trunk? Thanks, Martin From b8463b8a7b2f6b652d6d9c3a2ece814ec5554619 Mon Sep 17 00:00:00 2001 From:

[PATCH] Fix memory leak in IPA passes

2015-04-14 Thread Martin Liška
Hello. As originally reported by Andi Kleen, following patch fix memory leaks that can be seen in IPA ICF and IPA CP. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Moreover, with patch applied, we can build Firefox and Linux kernel on ppc64le-linux-gnu. Ready for both

Re: [PATCH] Fix memory leak in IPA passes

2015-04-14 Thread Martin Liška
On 04/14/2015 10:18 AM, Jakub Jelinek wrote: On Tue, Apr 14, 2015 at 10:14:06AM +0200, Martin Liška wrote: As originally reported by Andi Kleen, following patch fix memory leaks that can be seen in IPA ICF and IPA CP. Patch can bootstrap on x86_64-linux-gnu and survives regression tests

[PATCH] Fix PR ipa/65908.

2015-05-15 Thread Martin Liška
Hello. Following patch is fix for GCC-5 branch for PR ipa/65908, was tested on x86_64-linux-pc, as well as bootstrapped. As soon as the patch is applied, I'm going to send the similar patch for trunk. Ready for 5 branch? Thanks, Martin gcc/testsuite/ChangeLog: 2015-05-12 Martin Liska

Re: [PATCH] Fix PR ipa/65908.

2015-05-15 Thread Martin Liška
On 05/15/2015 12:38 PM, Jakub Jelinek wrote: On Fri, May 15, 2015 at 10:38:57AM +0200, Martin Liška wrote: Following patch is fix for GCC-5 branch for PR ipa/65908, was tested on x86_64-linux-pc, as well as bootstrapped. As soon as the patch is applied, I'm going to send the similar patch

Re: [PATCH] Fix PR ipa/65557

2015-05-12 Thread Martin Liška
On 04/30/2015 11:11 PM, Uros Bizjak wrote: Hello! 2015-03-29 Martin Liska mli...@suse.cz PR ipa/65557 * ipa-icf.c (sem_function::equals_wpa): Check if IPA CP has already filled up function summary. (sem_item_optimizer::update_hash_by_addr_refs): Likewise.

Re: [PATCH] Fix memory leak in IPA passes

2015-04-14 Thread Martin Liška
On 04/14/2015 03:45 PM, Jan Hubicka wrote: 2015-04-13 Martin Liska mli...@suse.cz * ipa-cp.c (ipcp_driver): Release prev_edge_clone. * ipa-icf.c (sem_item_optimizer::subdivide_classes_by_sensitive_refs): Release symbol_compare_collection. * ipa-reference.c:

Re: [PATCH] Fix PR ipa/65665

2015-04-07 Thread Martin Liška
On 04/03/2015 07:19 PM, Jan Hubicka wrote: Hello. Following patch fixes a new issue, ICE has disappeared on aarch64-linux machine and I was able to boostrap on the machine. Moreover, no new regression seen on x86_64-linux-pc. Ready for trunk? Thanks, Martin From

Re: [patch] Adjust hash-table.h and it's pre-requisite includes.

2015-06-09 Thread Martin Liška
On 06/05/2015 05:24 PM, Andrew MacLeod wrote: There is a horrible morass of include dependencies between hash-map.h, mem-stats.h and hash-table.h. There are even includes in both directions (mem-stats.h and hash-map.h include each other, as do hash-map.h and hash-table.h.. blech). Some of

Re: [PATCH 1/2] Memory statistics enhancement.

2015-06-08 Thread Martin Liška
On 06/01/2015 06:16 PM, mliska wrote: Hi. Following 2 patches improve memory statistics infrastructure. First one ports pool allocator to the new infrastructure. And the second one makes column alignment properly. Both can bootstrap on x86_64-linux-pc and survive regression tests.

Re: [PATCH 1/2] Memory statistics enhancement.

2015-06-03 Thread Martin Liška
On 06/02/2015 07:17 PM, Jeff Law wrote: On 06/02/2015 09:05 AM, Martin Liška wrote: On 06/02/2015 03:58 PM, Jeff Law wrote: On 06/01/2015 10:16 AM, mliska wrote: Hi. Following 2 patches improve memory statistics infrastructure. First one ports pool allocator to the new infrastructure

Re: [PATCH 1/2] Memory statistics enhancement.

2015-06-03 Thread Martin Liška
On 06/01/2015 06:16 PM, mliska wrote: Hi. Following 2 patches improve memory statistics infrastructure. First one ports pool allocator to the new infrastructure. And the second one makes column alignment properly. Both can bootstrap on x86_64-linux-pc and survive regression tests.

Re: [PATCH 1/2] Memory statistics enhancement.

2015-06-03 Thread Martin Liška
On 06/03/2015 03:18 PM, Jeff Law wrote: On 06/03/2015 03:14 AM, Martin Liška wrote: On 06/02/2015 07:17 PM, Jeff Law wrote: On 06/02/2015 09:05 AM, Martin Liška wrote: On 06/02/2015 03:58 PM, Jeff Law wrote: On 06/01/2015 10:16 AM, mliska wrote: Hi. Following 2 patches improve memory

Re: Do less generous pointer globbing in alias.c

2015-06-10 Thread Martin Liška
On 05/27/2015 07:28 AM, Jan Hubicka wrote: Hi, this patch makes it possible for non-LTO alias oracle to TBAA disambiguate pointer types. It makes void * conflicting with all of them and does not put it to alias set 0. It also preserves the property that qualifiers of pointer-to type should

Re: [PATCH] Fix PR ipa/65908.

2015-06-10 Thread Martin Liška
On 05/15/2015 08:52 PM, Jan Hubicka wrote: +/* Return true if DECL_ARGUMENT types are valid to be merged. */ Perhaps bettter as Perform additional check needed to match types function parameters that are used. Unlike for normal parameters it matters if type is TYPE_RESTRICT and we make an

[PATCH] Fix PR lto/66394

2015-06-10 Thread Martin Liška
Hello. This patch fixes $SUBJECT, can bootstrap and survive regression tests on x86_64-linux-unknown-pc. Ready for trunk? If so, I'm going to prepare backportable patches for 4.9 and 5.0 branches. Thanks, Martin From 9cd5de436cfca51095d63b3a3017df44c95baba6 Mon Sep 17 00:00:00 2001 From:

[PATCH] Fix PR bootstrap/66471

2015-06-09 Thread Martin Liška
Hello. Following patch renames an enum values so that they do not clash with a MinGW reserved keyword. Patch can bootstrap on MinGW and there's no regression seen on x86_64-linux-unknown-gnu. Ready for trunk? Thanks, Martin From 740811e0af76af3e1e2f39f149c35bd49ef5fed3 Mon Sep 17 00:00:00 2001

[hsa] Fix register allocator

2015-06-25 Thread Martin Liška
Hi. The following patch fixes HSA register allocator which hasn't visited all insns that belong to a call block insn. As a result, the allocator hasn't passed correct registers to a called function. Martin From 1d0f5dce43f7af5a65bbfb5aef9545a3f1c0af27 Mon Sep 17 00:00:00 2001 From: mliska

Re: New type-based pool allocator code miscompiled due to aliasing issue?

2015-06-24 Thread Martin Liška
On 06/23/2015 09:44 PM, Pat Haugen wrote: On 06/18/2015 06:10 AM, Richard Biener wrote: You are right that we should call ::new just for classes that have m_ignore_type_size == false. I've come up with following patch, that I tested slightly: diff --git a/gcc/alloc-pool.h b/gcc/alloc-pool.h

Re: [PATCH 00/17] RFC: Addding a unit testing framework to gcc

2015-06-11 Thread Martin Liška
On 06/10/2015 05:24 PM, David Malcolm wrote: Our current test suite is rather coarse-grained, acting at the level of running gcc subprocesses, and verifying externally-visible properties: - Did the compile succeed? - Was a particular dumpfile emitted, containing something matching

Re: New type-based pool allocator code miscompiled due to aliasing issue?

2015-06-16 Thread Martin Liška
On 06/16/2015 03:17 PM, Richard Biener wrote: On Tue, Jun 16, 2015 at 11:26 AM, Martin Liška mli...@suse.cz wrote: On 06/15/2015 07:31 PM, Marc Glisse wrote: On Mon, 15 Jun 2015, Martin Liška wrote: Ah, I overlooked that it's not a placement new, but just static casting. Anyway, if I added

Re: [PATCH 1/2] Memory statistics enhancement.

2015-06-16 Thread Martin Liška
On 06/08/2015 05:01 PM, Martin Liška wrote: On 06/01/2015 06:16 PM, mliska wrote: Hi. Following 2 patches improve memory statistics infrastructure. First one ports pool allocator to the new infrastructure. And the second one makes column alignment properly. Both can bootstrap on x86_64

Re: New type-based pool allocator code miscompiled due to aliasing issue?

2015-06-15 Thread Martin Liška
On 06/11/2015 08:19 PM, Richard Biener wrote: On June 11, 2015 7:50:36 PM GMT+02:00, Jakub Jelinek ja...@redhat.com wrote: On Fri, Jun 12, 2015 at 12:58:12AM +0800, pins...@gmail.com wrote: This is just a bug in the older compiler. There was a change to fix in placement new operator. I can't

Re: New type-based pool allocator code miscompiled due to aliasing issue?

2015-06-15 Thread Martin Liška
On 06/15/2015 11:13 AM, Andrew Pinski wrote: On Mon, Jun 15, 2015 at 2:09 AM, Martin Liška mli...@suse.cz wrote: On 06/11/2015 08:19 PM, Richard Biener wrote: On June 11, 2015 7:50:36 PM GMT+02:00, Jakub Jelinek ja...@redhat.com wrote: On Fri, Jun 12, 2015 at 12:58:12AM +0800, pins

Re: New type-based pool allocator code miscompiled due to aliasing issue?

2015-06-16 Thread Martin Liška
On 06/16/2015 04:02 PM, Richard Biener wrote: On Tue, Jun 16, 2015 at 3:38 PM, Martin Liška mli...@suse.cz wrote: On 06/16/2015 03:17 PM, Richard Biener wrote: On Tue, Jun 16, 2015 at 11:26 AM, Martin Liška mli...@suse.cz wrote: On 06/15/2015 07:31 PM, Marc Glisse wrote: On Mon, 15 Jun 2015

Re: GCC 4.9.3 Status Report (2015-06-17) - branch frozen for release

2015-06-17 Thread Martin Liška
On 06/17/2015 10:44 AM, Jakub Jelinek wrote: The GCC 4.9 branch is now frozen for preparing of a release candidate for GCC 4.9.3. All changes to the branch require release manager approval from now on until 4.9.3 is released. I'll announce the GCC 4.9.3 release candidate once it is ready.

Re: [PATCH] Fix PR ipa/65908.

2015-06-17 Thread Martin Liška
On 06/10/2015 01:50 PM, Martin Liška wrote: On 05/15/2015 08:52 PM, Jan Hubicka wrote: +/* Return true if DECL_ARGUMENT types are valid to be merged. */ Perhaps bettter as Perform additional check needed to match types function parameters that are used. Unlike for normal parameters

Re: New type-based pool allocator code miscompiled due to aliasing issue?

2015-06-17 Thread Martin Liška
On 06/17/2015 01:29 PM, Richard Biener wrote: On Wed, Jun 17, 2015 at 1:22 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Jun 17, 2015 at 11:13:58AM +0200, Martin Jambor wrote: Do you mean Richard following changes: alloc-pool.h (allocate): ... + /* Placement new contructor. */ +

Re: New type-based pool allocator code miscompiled due to aliasing issue?

2015-06-16 Thread Martin Liška
On 06/15/2015 07:31 PM, Marc Glisse wrote: On Mon, 15 Jun 2015, Martin Liška wrote: Ah, I overlooked that it's not a placement new, but just static casting. Anyway, if I added: cselib_val () {} to struct cselib_val and changed the cast to placement new: char *ptr = (char *) header

Re: Statically-allocated objects with non-trivial ctors (was Re: [PATCH 33/35] Change use to type-based pool allocator in ira-color.c.)

2015-05-28 Thread Martin Liška
On 05/28/2015 08:03 PM, Jakub Jelinek wrote: On Thu, May 28, 2015 at 07:57:39PM +0200, Richard Biener wrote: But we've been trying to avoid this. And the jit might not be too happy about it either. Yeah, we should certainly try to avoid them, especially if it would affect many variables

Re: [PATCH 10/35] Change use to type-based pool allocator in cfg.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 07:57 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * cfg.c (initialize_original_copy_tables):Use new type-based pool allocator. (free_original_copy_tables) Likewise. (copy_original_table_clear)

Re: [PATCH 09/35] Change use to type-based pool allocator in c-format.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 07:55 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/c-family/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * c-format.c (check_format_arg):Use new type-based pool allocator. (check_format_info_main) Likewise. OK. jeff v2 From

Re: [PATCH 23/35] Change use to type-based pool allocator in tree-ssa-pre.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 08:18 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * tree-ssa-pre.c (get_or_alloc_expr_for_name): Use new type-based pool allocator. (bitmap_set_new): Likewise. (get_or_alloc_expr_for_constant):

Re: [PATCH 25/35] Change use to type-based pool allocator in tree-ssa-sccvn.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 08:13 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * tree-ssa-sccvn.c (vn_reference_insert): Use new type-based pool allocator. (vn_reference_insert_pieces): Likewise. (vn_phi_insert): Likewise.

Re: [PATCH 24/35] Change use to type-based pool allocator in tree-ssa-reassoc.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 08:12 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * tree-ssa-reassoc.c (add_to_ops_vec): Use new type-based pool allocator. (add_repeat_to_ops_vec): Likewise. (get_ops): Likewise.

Re: [PATCH 26/35] Change use to type-based pool allocator in tree-ssa-strlen.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 03:56 PM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * tree-ssa-strlen.c (new_strinfo): Use new type-based pool allocator. (free_strinfo): Likewise. (pass_strlen::execute): Likewise. --- gcc/tree-ssa-strlen.c | 10 --

Re: [PATCH 01/35] Introduce new type-based pool allocator.

2015-05-29 Thread Martin Liška
On 05/28/2015 07:15 PM, Jeff Law wrote: On 05/28/2015 06:49 AM, Martin Liška wrote: . This mechanism has been just adapted. I find it quite useful as we have examples in source code where we allocate same struct/class types from a various pool. For debugging purpose, it helps to identify

Re: [PATCH 13/35] Change use to type-based pool allocator in df-problems.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 08:01 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * df-problems.c (df_chain_create):Use new type-based pool allocator. (df_chain_unlink_1) Likewise. (df_chain_unlink) Likewise.

Re: [PATCH 12/35] Change use to type-based pool allocator in cselib.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 03:56 PM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * cselib.c (new_elt_list):Use new type-based pool allocator. (new_elt_loc_list) Likewise. (unchain_one_elt_list) Likewise. (unchain_one_elt_loc_list) Likewise.

Re: [PATCH 11/35] Change use to type-based pool allocator in sh.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 07:59 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * config/sh/sh.c (add_constant):Use new type-based pool allocator. (sh_reorg) Likewise. OK. jeff v2 From 68f0b72993d882d5dfe4096806f2bb78c87a37c4

Re: [PATCH 19/35] Change use to type-based pool allocator in sel-sched-ir.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 08:04 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * sel-sched-ir.c (alloc_sched_pools): Use new type-based pool allocator. (free_sched_pools): Likewise. * sel-sched-ir.h (_list_alloc): Likewise.

Re: [PATCH 22/35] Change use to type-based pool allocator in sched-deps.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 08:14 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * sched-deps.c (create_dep_node): Use new type-based pool allocator. (delete_dep_node): Likewise. (create_deps_list): Likewise.

Re: [PATCH 21/35] Change use to type-based pool allocator in regcprop.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 08:11 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * regcprop.c (free_debug_insn_changes): Use new type-based pool allocator. (replace_oldest_value_reg): Likewise. (pass_cprop_hardreg::execute):

Re: [PATCH 29/35] Change use to type-based pool allocator in ipa-prop.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 08:16 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * ipa-prop.c (ipa_set_jf_constant): Use new type-based pool allocator. (ipa_edge_duplication_hook): Likewise.

Re: [PATCH 02/35] Change use to type-based pool allocator in et-forest.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 07:45 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * et-forest.c (et_new_occ): Use new type-based pool allocator. (et_new_tree): Likewise. (et_free_tree): Likewise. (et_free_tree_force):

Re: [PATCH 03/35] Change use to type-based pool allocator in lra-lives.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 07:47 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * lra-lives.c (free_live_range): Use new type-based pool allocator. (free_live_range_list) Likewise. (create_live_range) Likewise.

Re: [PATCH 04/35] Change use to type-based pool allocator in lra.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 07:50 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * lra.c (init_insn_regs): Use new type-based pool allocator. (new_insn_reg) Likewise. (free_insn_reg) Likewise. (free_insn_regs) Likewise.

Re: [PATCH 05/35] Change use to type-based pool allocator in ira-color.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 07:51 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * ira-color.c (init_update_cost_records):Use new type-based pool allocator. (get_update_cost_record) Likewise. (free_update_cost_record_list)

Re: [PATCH 07/35] Change use to type-based pool allocator in var-tracking.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 03:56 PM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * var-tracking.c (variable_htab_free):Use new type-based pool allocator. (attrs_list_clear) Likewise. (attrs_list_insert) Likewise. (attrs_list_copy) Likewise.

Re: [PATCH 14/35] Change use to type-based pool allocator in df-scan.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 03:56 PM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * df-scan.c (struct df_scan_problem_data):Use new type-based pool allocator. (df_scan_free_internal) Likewise. (df_scan_alloc) Likewise. (df_grow_reg_info) Likewise.

Re: [PATCH 15/35] Change use to type-based pool allocator in dse.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 03:56 PM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * dse.c (get_group_info):Use new type-based pool allocator. (dse_step0) Likewise. (free_store_info) Likewise. (delete_dead_store_insn) Likewise.

Re: [PATCH 16/35] Change use to type-based pool allocator in tree-sra.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 08:02 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * tree-sra.c (sra_initialize): Use new type-based pool allocator. (sra_deinitialize) Likewise. (create_access_1) Likewise.

Re: [PATCH 17/35] Change use to type-based pool allocator in tree-ssa-math-opts.c.

2015-05-29 Thread Martin Liška
On 05/27/2015 08:03 PM, Jeff Law wrote: On 05/27/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-04-30 Martin Liska mli...@suse.cz * tree-ssa-math-opts.c (occ_new): Use new type-based pool allocator. (free_bb): Likewise. (pass_cse_reciprocals::execute): Likewise. OK. jeff

<    1   2   3   4   5   6   7   8   9   10   >