Re: [Geany-devel] Short function factoring

2011-11-08 Thread Matthew Brush
On 11/08/2011 01:21 PM, Lex Trotman wrote: On Wed, Nov 9, 2011 at 3:40 AM, Nick Treleaven wrote: On 04/11/2011 00:21, Lex Trotman wrote: Geany has many places where a short function then calls another short function which calls another short function, none of which are re-used. Personally I

Re: [Geany-devel] Highlighting setup refactoring?

2011-11-08 Thread Matthew Brush
On 11/08/2011 02:55 PM, Colomban Wendling wrote: Hi guys, TL;DR: code refactoring, boring stuff :D I tried a rewrite of highlighting.c:styleset_*() functions for all this code to be better readable and hopefully more easily maintainable. I ended up with no logic change (yet at least ^^), but

Re: [Geany-devel] Development website

2011-11-08 Thread Lex Trotman
[...] > BTW: What about the issue trackers, do you intend them to rest at > SourceForge? > IIUC yes for the moment. Cheers Lex > > -- > Dominic Hopf > http://dominichopf.de/ > > Key Fingerprint: A7DF C4FC 07AE 4DDC 5CA0 BD93 AAB0 6019 CA7D 868D > > _

[Geany-devel] Highlighting setup refactoring?

2011-11-08 Thread Colomban Wendling
Hi guys, TL;DR: code refactoring, boring stuff :D I tried a rewrite of highlighting.c:styleset_*() functions for all this code to be better readable and hopefully more easily maintainable. I ended up with no logic change (yet at least ^^), but a big refactoring, in the form of arrays mapping th

Re: [Geany-devel] Development website

2011-11-08 Thread Dominic Hopf
Am Dienstag, den 08.11.2011, 01:22 +0100 schrieb Colomban Wendling: > Le 08/11/2011 00:21, Lex Trotman a écrit : > > On Tue, Nov 8, 2011 at 6:03 AM, Dominic Hopf wrote: > >> Hi Lex, > >> > >> Am Montag, den 07.11.2011, 08:09 +1100 schrieb Lex Trotman: > >>> Hi Website dudes, > >>> > >>> Just notic

Re: [Geany-devel] [RFC] Document Messages

2011-11-08 Thread Dominic Hopf
Am Montag, den 07.11.2011, 23:28 +0100 schrieb Enrico Tröger: > In what way this is better than the search field in the toolbar? Another point which wasn't mentioned in previous replies: It just shows up if you request it via keybinding. Otherwise it won't be displayed (if I understood Matthew cor

Re: [Geany-devel] [RFC] Document Messages

2011-11-08 Thread Enrico Tröger
On Mon, 07 Nov 2011 17:51:38 -0800, Matthew wrote: >On 11/07/2011 02:28 PM, Enrico Tröger wrote: >> On Mon, 07 Nov 2011 01:00:49 -0800, Matthew wrote: >> >> Hi, >> >>> I actually have a plugin I've been working on that does exactly >>> that. It's a really simplified search bar that pops-up under t

Re: [Geany-devel] Short function factoring

2011-11-08 Thread Lex Trotman
On Wed, Nov 9, 2011 at 3:40 AM, Nick Treleaven wrote: > On 04/11/2011 00:21, Lex Trotman wrote: >> >> Geany has many places where a short function then calls >> another short function which calls another short function, none of >> which are re-used.  Personally I find this way of writing code less

Re: [Geany-devel] Stub project files for sharing

2011-11-08 Thread Lex Trotman
[...] >> Unfortunately this is a requirement for any overriding scheme like >> stubs, if all the settings are written to the users project file no >> settings will be read from the stub file. > > No, what I would do is: > * Read the user config file content > * Append the content of the VCS file >

Re: [Geany-devel] Stub project files for sharing

2011-11-08 Thread Nick Treleaven
On 04/11/2011 21:31, Lex Trotman wrote: [...] I see that 'based on' could be useful for making subprojects, and could be added to my proposal. As I see it, this is the same as your proposal, just that we have an explicit pointer from the project file to the stub project file so they don't *hav

[Geany-devel] Short function factoring

2011-11-08 Thread Nick Treleaven
On 04/11/2011 00:21, Lex Trotman wrote: Geany has many places where a short function then calls another short function which calls another short function, none of which are re-used. Personally I find this way of writing code less efficient and very hard to follow and understand as a whole, but o

Re: [Geany-devel] Proposal: Project settings split - adding geany features

2011-11-08 Thread Nick Treleaven
On 04/11/2011 00:21, Lex Trotman wrote: Just one note that the point of raising it in the ML before doing it was to see if anyone had better ideas for a solution. Geany needs more of that, as exhausting as it may be, rather than taking the first suggestion or patch or pre-implemented pull reques

Re: [Geany-devel] Request: multithreaded tag generation?

2011-11-08 Thread Matthew Brush
On 11-11-08 12:49 AM, Thomas Martitz wrote: Am 08.11.2011 03:13, schrieb Lex Trotman: Not so easy, from the sqlite faq: (6) Is SQLite threadsafe? Threads are evil. Avoid them. And what they don't mention is that you can deadlock your system if the access isn't coordinated, ... back to square

Re: [Geany-devel] Request: multithreaded tag generation?

2011-11-08 Thread Lex Trotman
On Tue, Nov 8, 2011 at 7:49 PM, Thomas Martitz wrote: > Am 08.11.2011 03:13, schrieb Lex Trotman: >> >> Not so easy, from the sqlite faq: >> >> (6) Is SQLite threadsafe? >> >>     Threads are evil. Avoid them. >> >> And what they don't mention is that you can deadlock your system if >> the access

Re: [Geany-devel] Request: multithreaded tag generation?

2011-11-08 Thread Thomas Martitz
Am 08.11.2011 03:13, schrieb Lex Trotman: Not so easy, from the sqlite faq: (6) Is SQLite threadsafe? Threads are evil. Avoid them. And what they don't mention is that you can deadlock your system if the access isn't coordinated, ... back to square one. They do mention though that SQL

Re: [Geany-devel] Request: multithreaded tag generation?

2011-11-08 Thread Lex Trotman
On Tue, Nov 8, 2011 at 6:27 PM, Thomas Martitz wrote: > Am 08.11.2011 02:44, schrieb Matthew Brush: >> >> I suspect it's that TagManager, for every single tag, is inserting the tag >> into the tags array, removing duplicates, and then re-sorting the entire >> array. > > Is it possible to fix that