Re: [Geeqie-devel] Geeqie-1.1 LCMS2 Patch

2013-12-14 Thread Niko Sauer
On 12/13/13 14:08, Michael Schwendt wrote: > On Fri, 13 Dec 2013 06:43:25 +0200, Niko Sauer wrote: > >>> Let me try to explain. In the code snippet above, the two conditionals >>> build a logical AND, so that in order to build with LCMS2, both >>> HAVE_LCMS and HAVE_LCMS2 must be defined. If HAVE

Re: [Geeqie-devel] Geeqie-1.1 LCMS2 Patch

2013-12-13 Thread Michael Schwendt
On Fri, 13 Dec 2013 06:43:25 +0200, Niko Sauer wrote: > > Let me try to explain. In the code snippet above, the two conditionals > > build a logical AND, so that in order to build with LCMS2, both > > HAVE_LCMS and HAVE_LCMS2 must be defined. If HAVE_LCMS were undefined, > > the HAVE_LCMS2 conditi

Re: [Geeqie-devel] Geeqie-1.1 LCMS2 Patch

2013-12-12 Thread Niko Sauer
On 12/12/13 11:07, Michael Schwendt wrote: > On Thu, 12 Dec 2013 06:34:54 +0200, Niko Sauer wrote: > > Which line have you deleted? There's a bug in the patch, because HAVE_LCMS > is undefined, and that leads to some files (such as exif_common.c) not > including lcms2.h and breaking c

Re: [Geeqie-devel] Geeqie-1.1 LCMS2 Patch

2013-12-12 Thread Michael Schwendt
On Thu, 12 Dec 2013 06:34:54 +0200, Niko Sauer wrote: > >>> Which line have you deleted? There's a bug in the patch, because HAVE_LCMS > >>> is undefined, and that leads to some files (such as exif_common.c) not > >>> including lcms2.h and breaking compilation. > >>> > >>> > >> It is line 296 whic

Re: [Geeqie-devel] Geeqie-1.1 LCMS2 Patch

2013-12-11 Thread Niko Sauer
On 12/11/13 12:06, Michael Schwendt wrote: > On Wed, 11 Dec 2013 06:47:40 +0200, Niko Sauer wrote: > >> On 12/09/13 19:43, Michael Schwendt wrote: >>> On Fri, 06 Dec 2013 03:20:53 +, Omari Stephens wrote: >>> Niko: do you know if render speed is affected? >>> >>> It appears to be visibly

Re: [Geeqie-devel] Geeqie-1.1 LCMS2 Patch

2013-12-11 Thread Michael Schwendt
On Wed, 11 Dec 2013 06:47:40 +0200, Niko Sauer wrote: > On 12/09/13 19:43, Michael Schwendt wrote: > > On Fri, 06 Dec 2013 03:20:53 +, Omari Stephens wrote: > > > >> Niko: do you know if render speed is affected? > > > > It appears to be visibly faster here. > > > >> ISTR that render speed > >

Re: [Geeqie-devel] Geeqie-1.1 LCMS2 Patch

2013-12-10 Thread Niko Sauer
On 12/09/13 19:43, Michael Schwendt wrote: > On Fri, 06 Dec 2013 03:20:53 +, Omari Stephens wrote: > >> Niko: do you know if render speed is affected? > > It appears to be visibly faster here. > >> ISTR that render speed >> was one downside to LCMS2, but that may have changed since I last hea

Re: [Geeqie-devel] Geeqie-1.1 LCMS2 Patch

2013-12-09 Thread Michael Schwendt
On Fri, 06 Dec 2013 03:20:53 +, Omari Stephens wrote: > Niko: do you know if render speed is affected? It appears to be visibly faster here. > ISTR that render speed > was one downside to LCMS2, but that may have changed since I last heard > that, and also it might not be significant (I ha

Re: [Geeqie-devel] Geeqie-1.1 LCMS2 Patch

2013-12-09 Thread Niko Sauer
Dear Omari I could not detect a change of speed in Geeqie. The version of lcms2 I have on my system is 2.3. The system is "Beyond Linux From Scratch" based on Linux-3.3.7. That system has moved on quite a bit and now touts lcms2-2.5. I think it can only be faster. I might also add that I re-co

Re: [Geeqie-devel] Geeqie-1.1 LCMS2 Patch

2013-12-05 Thread Omari Stephens
Niko: do you know if render speed is affected? ISTR that render speed was one downside to LCMS2, but that may have changed since I last heard that, and also it might not be significant (I haven't used a project using LCMS2 before). --xsdg On 12/05/2013 04:47 AM, Niko Sauer wrote: > I found a

[Geeqie-devel] Geeqie-1.1 LCMS2 Patch

2013-12-04 Thread Niko Sauer
I found a patch that will enable lcms2 when compiling Geeqie-1.1.This is Gitorious Commit 1548a68. There is a small bug in the patch that I remedied by deleting one single line. The new patch is attached. Since it changes configure.in, one should run autoconf before configuring. Geeqie's colour r