Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/#review5223 --- src/dev/etherswitch.cc

Re: [gem5-dev] Review Request 2167: mem: refactor LRU cache tags and add random replacment tags

> On July 22, 2014, 2:24 p.m., Ali Saidi wrote: > > src/mem/cache/tags/lru.cc, line 177 > > > > > > why not unsigned? > > > > Anthony Gutierrez wrote: > I made it unsigned because CacheBlk's set field is an int, as well

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/ --- (Updated July 22, 2014, 6:36 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

> On July 10, 2014, 12:48 p.m., Andreas Hansson wrote: > > src/dev/Ethernet.py, line 60 > > > > > > port speed? this is the fabric links' speed. i changed the name to be more descriptive. > On July 10, 2014, 12:48 p.m., An

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/ --- (Updated July 22, 2014, 6:25 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/ --- (Updated July 22, 2014, 6:25 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2167: mem: refactor LRU cache tags and add random replacment tags

> On July 22, 2014, 2:24 p.m., Ali Saidi wrote: > > src/mem/cache/tags/lru.cc, line 177 > > > > > > why not unsigned? > > I made it unsigned because CacheBlk's set field is an int, as well as the fact that extractSet() ret

Re: [gem5-dev] Review Request 2167: mem: refactor LRU cache tags and add random replacment tags

On July 22, 2014, 4:26 p.m., Anthony Gutierrez wrote: > > Some style-related suggestions, for the rest it looks great. Feel free to > > punt this to a later patch. I'd prefer to put it in a later patch, this is all pre-existing code. - Anthony ---

Re: [gem5-dev] Review Request 2167: mem: refactor LRU cache tags and add random replacment tags

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2167/#review5218 --- src/mem/cache/tags/base_set_assoc.cc

Re: [gem5-dev] Review Request 2167: mem: refactor LRU cache tags and add random replacment tags

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2167/#review5217 --- Ship it! src/mem/cache/tags/lru.hh

[gem5-dev] Cron /z/m5/regression/do-regression quick

* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/inorder-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simp