----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/#review5223 -----------------------------------------------------------
src/dev/etherswitch.cc <http://reviews.gem5.org/r/2305/#comment4773> Not sure what the style guide says about the spacing here, but I've been using for (auto i: list) Does anyone have a strong opinion? src/dev/etherswitch.cc <http://reviews.gem5.org/r/2305/#comment4770> Could merge these src/dev/etherswitch.cc <http://reviews.gem5.org/r/2305/#comment4771> seems a bit excessive :-) src/dev/etherswitch.cc <http://reviews.gem5.org/r/2305/#comment4772> Why is the copy needed? Could you add a comment? Some very minor things. Thanks for all the changes. - Andreas Hansson On July 22, 2014, 6:36 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2305/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 6:36 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10259:2d25a9f9969a > --------------------------- > dev: add an ethernet switch model > > this patch adds a very simple ethernet switch model. the basic design > behind the switch is to modularize the interface, fabric, and overall > switch model as much as possible. The switch model: > > 1) buffers incoming/outgoing packets in the ports > 2) utilizes Links from EtherLink as the point-to-point connections > in the switch fabric > 3) uses a simple least-recently-granted arbitration policy to forward packets, > and doesn't provide any support for things like flow control. it also does > not provide any features outside the link layer, which some switches may > support e.g., ARP, filtering, etc. > > > Diffs > ----- > > src/dev/Ethernet.py 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/SConscript 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/etherint.hh 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/etherlink.hh 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/etherlink.cc 23384aa97d8533f6e3f812d015dccaab3c0267af > src/dev/etherswitch.hh PRE-CREATION > src/dev/etherswitch.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2305/diff/ > > > Testing > ------- > > Successfully ran 3 systems with 1 memcached server and 2 memcached clients > simultaneously issuing requests. > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
