Re: [gem5-dev] Review Request 2874: sim: Decouple draining from the SimObject hierarchy

2015-06-27 Thread Andreas Sandberg
> On June 27, 2015, 6:44 p.m., Nilay Vaish wrote: > > src/python/m5/simulate.py, line 335 > > > > > > Why do we not need this resume()? Resume is now called automatically by simualte() if simulate is called on a drained sy

Re: [gem5-dev] Review Request 2873: sim: Move mem(Writeback|Invalidate) to SimObject

2015-06-27 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2873/#review6633 --- Ship it! Ship It! - Nilay Vaish On June 8, 2015, 11:34 a.m., Andreas

Re: [gem5-dev] Review Request 2874: sim: Decouple draining from the SimObject hierarchy

2015-06-27 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2874/#review6632 --- I'll read the patch once more after you have answered my queries, src/p

Re: [gem5-dev] Review Request 2880: scons: remove dead leading underscore check

2015-06-27 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2880/#review6631 --- Ship it! Ship It! - Nilay Vaish On June 8, 2015, 11:35 p.m., Curtis D

Re: [gem5-dev] Review Request 2876: sim: Fix broken event unserialization

2015-06-27 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2876/#review6630 --- Ship it! Seems fine to me. - Nilay Vaish On June 8, 2015, 5:05 p.m.,

Re: [gem5-dev] Review Request 2875: sim: Refactor and simplify the drain API

2015-06-27 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2875/#review6629 --- Ship it! Ship It! - Nilay Vaish On June 21, 2015, 8:02 p.m., Andreas

Re: [gem5-dev] Review Request 2845: ruby: Expose MessageBuffers as SimObjects

2015-06-27 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2845/#review6628 --- Please post a snippet of the config.ini file generated after this patch i

Re: [gem5-dev] Review Request 2925: mem: Convert Request static const flags to enums

2015-06-27 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2925/#review6626 --- Ship it! Ship It! - Nilay Vaish On June 26, 2015, 9:26 p.m., Andreas

Re: [gem5-dev] pd-gem5: simulating a parallel/distributed system on multiple physical hosts

2015-06-27 Thread Mohammad Alian
Hi All, Curtis-Thank you for listing some of the differences. I was waiting for the completed multi-gem5 patch before I send my review. Please see my inline response below. I’ve addressed the concerns that you’ve raised. Also, I’ve added a bit more to the comparison. -* Synchronization. pd-gem

[gem5-dev] Cron /z/m5/regression/do-regression quick

2015-06-27 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple

Re: [gem5-dev] Solution to sporadic undefined references

2015-06-27 Thread Andreas Hansson
Hi Alex, http://stackoverflow.com/questions/3025997/defining-static-const-integer-me mbers-in-class-definition Andreas On 27/06/2015 00:04, "gem5-dev on behalf of Dutu, Alexandru" wrote: >Hi Andreas, > >I remember to be valid to define static const class members in header >files, is that not