Re: [gem5-dev] Review Request 3230: dist, dev: add an ethernet switch model

2016-01-12 Thread Mohammad Alian
> On Jan. 12, 2016, 3:19 p.m., Andreas Hansson wrote: > > src/dev/net/etherswitch.cc, line 531 > > > > > > It really irks me that we schedule this every clock period, even if > > there is nothing to do. > > > > Eve

Re: [gem5-dev] Review Request 3230: dist, dev: add an ethernet switch model

2016-01-12 Thread Mohammad Alian
> On Jan. 8, 2016, 5:22 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.cc, line 529 > > > > > > This is not a very nice way to design things... > > > > It would be much better if this module was event based. I

Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

2016-01-12 Thread Brad Beckmann
> On Nov. 13, 2015, 11:03 p.m., Joel Hestness wrote: > > src/mem/ruby/system/Sequencer.py, line 77 > > > > > > Why is this default initialized to 16? > > Brad Beckmann wrote: > Thank you for pointing this out. We will r

Re: [gem5-dev] Review Request 3235: stats: organize and clarify resettable stats

2016-01-12 Thread Lena Olson
> On Jan. 11, 2016, 11:52 p.m., Joel Hestness wrote: > > src/cpu/minor/cpu.cc, line 335 > > > > > > Just a note that this is interesting... looks like this fixes an > > inconsistency: MinorCPU appears to collect inst stats

Re: [gem5-dev] Review Request 3230: dist, dev: add an ethernet switch model

2016-01-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3230/#review7868 --- src/dev/net/etherswitch.cc (line 531)

Re: [gem5-dev] Review Request 3230: dist, dev: add an ethernet switch model

2016-01-12 Thread Andreas Hansson
> On Jan. 8, 2016, 5:22 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.cc, line 529 > > > > > > This is not a very nice way to design things... > > > > It would be much better if this module was event based. I

[gem5-dev] Cron /z/m5/regression/do-regression quick

2016-01-12 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing passed. * build/ALPHA/tests/opt/quick/se/30.eio-mp/alpha/eio/simple-atomic-mp passed. * build/ALPHA/tests/opt/quick/se/03.learning-gem5