[gem5-dev] Cron /z/m5/regression/do-regression quick

2018-11-28 Thread Cron Daemon
scons: *** [build/ALPHA/systemc/utils/vcd.do] Error 1 scons: *** [build/MIPS/systemc/utils/vcd.do] Error 1 scons: *** [build/NULL/systemc/utils/vcd.do] Error 1 scons: *** [build/NULL_MOESI_hammer/systemc/utils/vcd.do] Error 1 scons: *** [build/NULL_MESI_Two_Level/systemc/utils/vcd.do] Error 1 scons

[gem5-dev] Change in gem5/gem5[master]: tests: Convert IniFile unit test to a GTest

2018-11-28 Thread Giacomo Travaglini (Gerrit)
Giacomo Travaglini has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14615 ) Change subject: tests: Convert IniFile unit test to a GTest .. tests: Convert IniFile unit test to

[gem5-dev] Change in gem5/gem5[master]: base, arch-arm: clang compilation fixes

2018-11-28 Thread Giacomo Travaglini (Gerrit)
Hello Andreas Sandberg, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/14617 to review the following change. Change subject: base, arch-arm: clang compilation fixes ..

[gem5-dev] Change in gem5/gem5[master]: arch-arm: clang compilation fixes

2018-11-28 Thread Giacomo Travaglini (Gerrit)
Hello Andreas Sandberg, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/14617 to look at the new patch set (#2). Change subject: arch-arm: clang compilation fixes .. a

[gem5-dev] Change in gem5/gem5[master]: arch-arm: clang compilation fixes

2018-11-28 Thread Giacomo Travaglini (Gerrit)
Giacomo Travaglini has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14617 ) Change subject: arch-arm: clang compilation fixes .. arch-arm: clang compilation fixes Fix 1: std:

[gem5-dev] Change in gem5/gem5[master]: base: Add missing overrides in statistics header

2018-11-28 Thread Nikos Nikoleris (Gerrit)
Hello Giacomo Travaglini, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/14619 to review the following change. Change subject: base: Add missing overrides in statistics header

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Add missing template declaration

2018-11-28 Thread Nikos Nikoleris (Gerrit)
Hello Giacomo Travaglini, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/14618 to review the following change. Change subject: arch-arm: Add missing template declaration ..

[gem5-dev] Change in gem5/gem5[master]: cpu, arch-arm: Initialise data members

2018-11-28 Thread Giacomo Gabrielli (Gerrit)
Giacomo Gabrielli has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/13125 ) Change subject: cpu,arch-arm: Initialise data members .. cpu,arch-arm: Initialise data members The

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Support for page crossing prefetches

2018-11-28 Thread Javier Bueno Hedo (Gerrit)
Hello Giacomo Travaglini, Andreas Sandberg, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/14620 to review the following change. Change subject: mem-cache: Support for page crossing prefetches ...

[gem5-dev] Change in gem5/gem5[master]: cpu: Change raw pointers to STL Containers

2018-11-28 Thread Giacomo Travaglini (Gerrit)
Giacomo Travaglini has uploaded a new patch set (#12) to the change originally created by Giacomo Gabrielli. ( https://gem5-review.googlesource.com/c/public/gem5/+/13126 ) Change subject: cpu: Change raw pointers to STL Containers ..

[gem5-dev] Change in gem5/gem5[master]: base: increase the GDB buffer size dynamically

2018-11-28 Thread Ciro Santilli (Gerrit)
Hello Gabe Black, Jason Lowe-Power, Giacomo Travaglini, Andreas Sandberg, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/14497 to look at the new patch set (#3). Change subject: base: increase the GDB buffer size dynamically ..

[gem5-dev] Change in gem5/gem5[master]: base: increase the GDB buffer size dynamically

2018-11-28 Thread Ciro Santilli (Gerrit)
Hello Gabe Black, Jason Lowe-Power, Giacomo Travaglini, Andreas Sandberg, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/14497 to look at the new patch set (#4). Change subject: base: increase the GDB buffer size dynamically ..

[gem5-dev] Change in gem5/gem5[master]: base: Ported circlebuf to CircularQueue

2018-11-28 Thread Giacomo Travaglini (Gerrit)
Giacomo Travaglini has uploaded a new patch set (#17) to the change originally created by Giacomo Gabrielli. ( https://gem5-review.googlesource.com/c/public/gem5/+/13128 ) Change subject: base: Ported circlebuf to CircularQueue .

[gem5-dev] Change in gem5/gem5[master]: base: Iterable CircularQueue implementation

2018-11-28 Thread Giacomo Travaglini (Gerrit)
Giacomo Travaglini has uploaded a new patch set (#16) to the change originally created by Giacomo Gabrielli. ( https://gem5-review.googlesource.com/c/public/gem5/+/13127 ) Change subject: base: Iterable CircularQueue implementation .

[gem5-dev] Change in gem5/gem5[master]: base: Ported circlebuf to CircularQueue

2018-11-28 Thread Giacomo Travaglini (Gerrit)
Giacomo Travaglini has uploaded a new patch set (#18) to the change originally created by Giacomo Gabrielli. ( https://gem5-review.googlesource.com/c/public/gem5/+/13128 ) Change subject: base: Ported circlebuf to CircularQueue .

[gem5-dev] Change in gem5/gem5[master]: cpu: Added new stats to TAGE and LTAGE branch predictors

2018-11-28 Thread Pau Cabre (Gerrit)
Pau Cabre has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14535 ) Change subject: cpu: Added new stats to TAGE and LTAGE branch predictors .. cpu: Added new stats to TAGE and

[gem5-dev] Change in gem5/gem5[master]: cpu: split LTAGE implementation into a base TAGE and a derived LTAGE

2018-11-28 Thread Pau Cabre (Gerrit)
Pau Cabre has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14435 ) Change subject: cpu: split LTAGE implementation into a base TAGE and a derived LTAGE .. cpu: split LTAGE

[gem5-dev] Change in gem5/gem5[master]: base: Add missing overrides in statistics header

2018-11-28 Thread Nikos Nikoleris (Gerrit)
Nikos Nikoleris has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14619 ) Change subject: base: Add missing overrides in statistics header .. base: Add missing overrides in sta

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Add missing template declaration

2018-11-28 Thread Nikos Nikoleris (Gerrit)
Nikos Nikoleris has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14618 ) Change subject: arch-arm: Add missing template declaration .. arch-arm: Add missing template declarati

[gem5-dev] Unit test naming convention

2018-11-28 Thread Gabe Black
Hi folks. We have a few unit tests now, and they are mostly consistently named by adding test to the file name. For instance the tests for foo.cc would be in footest.cc. There are two minor downsides to that. First, that's a bit ugly to read, and it may look weird if files, for instance, use _ to

Re: [gem5-dev] Unit test naming convention

2018-11-28 Thread Jason Lowe-Power
That's fine with me! +1 On Wed, Nov 28, 2018 at 4:54 PM Gabe Black wrote: > Hi folks. We have a few unit tests now, and they are mostly consistently > named by adding test to the file name. For instance the tests for foo.cc > would be in footest.cc. > > There are two minor downsides to that. Fi

[gem5-dev] Change in gem5/gem5[master]: systemc: Make verify.py recognize a DEPS file in test dirs.

2018-11-28 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14516 ) Change subject: systemc: Make verify.py recognize a DEPS file in test dirs. .. systemc: Make verify.py reco

[gem5-dev] Change in gem5/gem5[master]: systemc: Run the systemc tests with the CWD in the build directory.

2018-11-28 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14518 ) Change subject: systemc: Run the systemc tests with the CWD in the build directory. .. systemc: Run the

[gem5-dev] Change in gem5/gem5[master]: systemc: Add DEPS files for some tests with non-source file dependenc...

2018-11-28 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14517 ) Change subject: systemc: Add DEPS files for some tests with non-source file dependencies. .. systemc: Ad

[gem5-dev] Change in gem5/gem5[master]: systemc: Run the systemc tests directly from their build directories.

2018-11-28 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14519 ) Change subject: systemc: Run the systemc tests directly from their build directories. .. systemc: Run th

[gem5-dev] Change in gem5/gem5[master]: base: Change the unit test binary names to use .test, and to be consi...

2018-11-28 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/14677 Change subject: base: Change the unit test binary names to use .test, and to be consistent. .. base: Change the u

[gem5-dev] Change in gem5/gem5[master]: base: Rename unit test cc files to be *.test.cc.

2018-11-28 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/14676 Change subject: base: Rename unit test cc files to be *.test.cc. .. base: Rename unit test cc files to be *.test.cc.

[gem5-dev] Change in gem5/gem5[master]: base: Fix include order in the inifile unit test.

2018-11-28 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/14675 Change subject: base: Fix include order in the inifile unit test. .. base: Fix include order in the inifile unit tes

[gem5-dev] Change in gem5/gem5[master]: base: Fix include order in the inifile unit test.

2018-11-28 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14675 ) Change subject: base: Fix include order in the inifile unit test. .. base: Fix include order in the inifile

[gem5-dev] custom allocator for Request/Packet objects

2018-11-28 Thread Gabe Black
I was just wondering whether it would make sense to have custom allocators defined for Request and Packet types which would keep around a pool of them rather than defaulting to the normal allocator. I suspect since both types of objects are allocated very frequently this could save a lot of heap ov