Re: [gem5-dev] Port configuration overhaul

2019-03-07 Thread Steve Reinhardt
Thanks for digging this up, Jason. I knew this issue had been addressed multiple times before (I think I even had a patch at one point that was a smaller change, but held it off in favor of Andreas's version). I don't know why Andreas's change was never committed either. Anyway, it will be good

Re: [gem5-dev] Port configuration overhaul

2019-03-07 Thread Jason Lowe-Power
Hey Gabe, I was digging through the old reviewboard and found this patch that also re-did this interface: http://reviews.gem5.org/r/1301 I'm not sure why this was never committed. I believe Andreas H's goal was to enable TLM-2 interfaces with the gem5, IIRC. Just something to consider. Cheers,

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Added extra information to PrefetchInfo

2019-03-07 Thread Javier Bueno Hedo (Gerrit)
Hello Nikos Nikoleris, Daniel Carvalho, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/16583 to look at the new patch set (#7). Change subject: mem-cache: Added extra information to PrefetchInfo

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Added extra information to PrefetchInfo

2019-03-07 Thread Javier Bueno Hedo (Gerrit)
Hello Nikos Nikoleris, Daniel Carvalho, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/16583 to look at the new patch set (#6). Change subject: mem-cache: Added extra information to PrefetchInfo

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Implement multi-level TLB

2019-03-07 Thread Ivan Pizarro (Gerrit)
Hello Nikos Nikoleris, Daniel Carvalho, Giacomo Travaglini, Andreas Sandberg, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/14118 to look at the new patch set (#10). Change subject: arch-arm: Implement multi-level TLB ..

Re: [gem5-dev] Port configuration overhaul

2019-03-07 Thread Gabe Black
Hey folks, specifically folks looking at this doc. I have a series of patches which largely implement what I was going for, although it turned out differently than what I have in my doc. I'll update the doc soon(ish) to describe the current version. Go ahead and review the CLs if you want, although

[gem5-dev] Change in gem5/gem5[master]: dev: Make EtherInt inherit from Port.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17035 Change subject: dev: Make EtherInt inherit from Port. .. dev: Make EtherInt inherit from Port. This way a common fu

[gem5-dev] Change in gem5/gem5[master]: python: Switch to the new getPort mechanism to connect ports.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17039 Change subject: python: Switch to the new getPort mechanism to connect ports. .. python: Switch to the new getPor

[gem5-dev] Change in gem5/gem5[master]: mem: Move the Port base class into sim.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17036 Change subject: mem: Move the Port base class into sim. .. mem: Move the Port base class into sim. The Port class i

[gem5-dev] Change in gem5/gem5[master]: python: Teach cxxMethod how to set return_value_policy.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17034 Change subject: python: Teach cxxMethod how to set return_value_policy. .. python: Teach cxxMethod how to set return

[gem5-dev] Change in gem5/gem5[master]: python: Change || to && for MessageBuffers in connectPorts.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17031 Change subject: python: Change || to && for MessageBuffers in connectPorts. .. python: Change || to && for MessageBu

[gem5-dev] Change in gem5/gem5[master]: mem: Move bind() and unbind() into the Port class.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17038 Change subject: mem: Move bind() and unbind() into the Port class. .. mem: Move bind() and unbind() into the Port cl

[gem5-dev] Change in gem5/gem5[master]: arch, cpu, dev, gpu, mem, sim, python: start using getPort.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17040 Change subject: arch, cpu, dev, gpu, mem, sim, python: start using getPort. .. arch, cpu, dev, gpu, mem, sim, python

[gem5-dev] Change in gem5/gem5[master]: dev: Make the EtherDevice class inherit EtherObject.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17029 Change subject: dev: Make the EtherDevice class inherit EtherObject. .. dev: Make the EtherDevice class inherit Ethe

[gem5-dev] Change in gem5/gem5[master]: python: Simplify connectPorts() around EtherObject/EtherDevice.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17030 Change subject: python: Simplify connectPorts() around EtherObject/EtherDevice. .. python: Simplify connectPorts(

[gem5-dev] Change in gem5/gem5[master]: mem: Track the MemObject owner in MasterPort and SlavePort.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17032 Change subject: mem: Track the MemObject owner in MasterPort and SlavePort. .. mem: Track the MemObject owner in Mas

[gem5-dev] Change in gem5/gem5[master]: dev: Turn EtherObject into an interface class.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17028 Change subject: dev: Turn EtherObject into an interface class. .. dev: Turn EtherObject into an interface class. Th

[gem5-dev] Change in gem5/gem5[master]: sim: Add a getPort function to SimObject.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17037 Change subject: sim: Add a getPort function to SimObject. .. sim: Add a getPort function to SimObject. This will re

[gem5-dev] Change in gem5/gem5[master]: python: Teach PyBindMethod how to set return_value_policy.

2019-03-07 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/17033 Change subject: python: Teach PyBindMethod how to set return_value_policy. .. python: Teach PyBindMethod how to set

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Added the Indirect Memory Prefetcher

2019-03-07 Thread Javier Bueno Hedo (Gerrit)
Hello Nikos Nikoleris, Daniel Carvalho, Andreas Sandberg, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/16223 to look at the new patch set (#10). Change subject: mem-cache: Added the Indirect Memory Prefetcher

[gem5-dev] Change in gem5/gem5[master]: sim: Add size to array unserialization error message

2019-03-07 Thread Daniel Carvalho (Gerrit)
Daniel Carvalho has uploaded a new patch set (#3). ( https://gem5-review.googlesource.com/c/public/gem5/+/16542 ) Change subject: sim: Add size to array unserialization error message .. sim: Add size to array unserialization e

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Allow tag-only accesses on latency calculation

2019-03-07 Thread Daniel Carvalho (Gerrit)
Daniel Carvalho has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14878 ) Change subject: mem-cache: Allow tag-only accesses on latency calculation .. mem-cache: Allow tag-only

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Add lookup latency to access' whenReady

2019-03-07 Thread Daniel Carvalho (Gerrit)
Daniel Carvalho has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14877 ) Change subject: mem-cache: Add lookup latency to access' whenReady .. mem-cache: Add lookup latency to

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Add header delay to handleFill whenReady

2019-03-07 Thread Daniel Carvalho (Gerrit)
Daniel Carvalho has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14895 ) Change subject: mem-cache: Add header delay to handleFill whenReady .. mem-cache: Add header delay to

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Use header delay on latency calculation

2019-03-07 Thread Daniel Carvalho (Gerrit)
Daniel Carvalho has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14876 ) Change subject: mem-cache: Use header delay on latency calculation .. mem-cache: Use header delay on l

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Fix recvTimingReq doWritebacks tick

2019-03-07 Thread Daniel Carvalho (Gerrit)
Daniel Carvalho has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14736 ) Change subject: mem-cache: Fix recvTimingReq doWritebacks tick .. mem-cache: Fix recvTimingReq doWrite

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Remove old todo about latency in hit function

2019-03-07 Thread Daniel Carvalho (Gerrit)
Daniel Carvalho has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/14875 ) Change subject: mem-cache: Remove old todo about latency in hit function .. mem-cache: Remove old todo

[gem5-dev] Cron /z/m5/regression/do-regression quick

2019-03-07 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux