[gem5-dev] changeset in gem5: cpu: Fix memoryIssueLimit checking in Minor

2014-12-02 Thread Andrew Bardsley via gem5-dev
changeset 953d7b741619 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=953d7b741619 description: cpu: Fix memoryIssueLimit checking in Minor This patch fixes the checking of the number of memory instructions issued per cycles in the Minor CPU.

[gem5-dev] changeset in gem5: config: SystemC Gem5Control top level additions

2014-12-02 Thread Andrew Bardsley via gem5-dev
changeset 5d7af9fa9809 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=5d7af9fa9809 description: config: SystemC Gem5Control top level additions This patch cleans up a few style issues and adds a few capabilities to the SystemC top level

[gem5-dev] changeset in gem5: cpu: Fix retries on barrier/store in Minor's ...

2014-12-02 Thread Andrew Bardsley via gem5-dev
changeset 7c4f1d0a8cff in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=7c4f1d0a8cff description: cpu: Fix retries on barrier/store in Minor's store buffer This patch fixes a case where a store in Minor's store buffer never leaves the store buffer as

[gem5-dev] changeset in gem5: config: Fix to SystemC example's event handling

2014-12-02 Thread Andrew Bardsley via gem5-dev
changeset 997be6ba467e in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=997be6ba467e description: config: Fix to SystemC example's event handling This patch fixes checkpoint restore in the SystemC hosting example by handling early PollEvent events

[gem5-dev] changeset in gem5: arm: Fix TLB ignoring faults when table walking

2014-12-02 Thread Andrew Bardsley via gem5-dev
changeset e622a3e2ed14 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=e622a3e2ed14 description: arm: Fix TLB ignoring faults when table walking This patch fixes a case where the Minor CPU can deadlock due to the lack of a response to TLB request

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Andrew Bardsley via gem5-dev
On Nov. 19, 2014, 12:22 a.m., Cagdas Dirik wrote: Please ignore my last review. I made a mistake with my patches. In FS, X86 mode I was able to boot with python variant, checkpoint, run a short program. Then I was able to restore from checkpoint and run the same program again. And

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Andrew Bardsley via gem5-dev
On Nov. 19, 2014, 12:22 a.m., Cagdas Dirik wrote: Please ignore my last review. I made a mistake with my patches. In FS, X86 mode I was able to boot with python variant, checkpoint, run a short program. Then I was able to restore from checkpoint and run the same program again. And

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-20 Thread Andrew Bardsley via gem5-dev
The convention is even documented (by gem5's documentation standards that must almost make it a law): http://gem5.org/SimObjects point 9: Later, the first time that the user script calls simulate(), call startup() on each SimObject. This is the point where SimObjects that do self-initiated

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-19 Thread Andrew Bardsley via gem5-dev
On Nov. 19, 2014, 12:22 a.m., Cagdas Dirik wrote: Please ignore my last review. I made a mistake with my patches. In FS, X86 mode I was able to boot with python variant, checkpoint, run a short program. Then I was able to restore from checkpoint and run the same program again. And

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-19 Thread Andrew Bardsley via gem5-dev
On Nov. 19, 2014, 12:22 a.m., Cagdas Dirik wrote: Please ignore my last review. I made a mistake with my patches. In FS, X86 mode I was able to boot with python variant, checkpoint, run a short program. Then I was able to restore from checkpoint and run the same program again. And

Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

2014-11-18 Thread Andrew Bardsley via gem5-dev
The member functions before_end_of_elaboration and end_of_elaboration are defined on sc_core::sc_module and the SystemC simulation kernel handles calling them at the appropriate times. Try printing something in main.cc:SimControl::before_end_of_elaboration and you should see that print

[gem5-dev] changeset in gem5: config: Fix checkpoint restore in C++ config ...

2014-11-14 Thread Andrew Bardsley via gem5-dev
changeset 1a9e235cab09 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=1a9e235cab09 description: config: Fix checkpoint restore in C++ config example This patch fixes the checkpoint restore option in the example of C++ configuration (util/cxx_config).

Re: [gem5-dev] how do checkpoint save/restore, switch cpu options work in tandem?

2014-11-14 Thread Andrew Bardsley via gem5-dev
It's better to see the cxx_config and systemc examples as just that, examples. The -s/-r check in SystemC is just forgotten. I really expected only one feature to be tried at a time, so -s/-r together with -c is not well explained. I expect any practical use of either feature to involve

Re: [gem5-dev] Review Request 2458: sim: SystemC hosting

2014-11-10 Thread Andrew Bardsley via gem5-dev
OK, Cagdas. I've pushed the fix I had in mind to our local repo. You should see it with the next set of patches that Ali or Andreas push. - Andrew -Original Message- From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Andrew Bardsley via gem5-dev Sent: 08 November 2014 17

Re: [gem5-dev] Review Request 2458: sim: SystemC hosting

2014-11-08 Thread Andrew Bardsley via gem5-dev
The PollEvent seems to be the GDB connect mechanism. I don't know if that's changed or I didn't sufficiently test the checkpoint restore. Oh well. llEvent seems to be the GDB connect mechanism. I don't know if that's changed to insert an earlier event (I have a vague memory of some GDB fix

Re: [gem5-dev] Review Request 2430: config: Add the ability to read a config file using C++ and Python

2014-11-06 Thread Andrew Bardsley via gem5-dev
Cagdas, can you try adding the line: config_manager-startup() at line 268 in util/cxx_config/main.cc (after the loadState(checkpoint) line). I've tried your ARM example (superficially, on my home machine) and it seems to fix the problem there with running 'hello' with your setup instructions.

[gem5-dev] changeset in gem5: cpu: Fix barrier push to store buffer when fu...

2014-10-29 Thread Andrew Bardsley via gem5-dev
changeset 58d5d471b598 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=58d5d471b598 description: cpu: Fix barrier push to store buffer when full bug in Minor This patch fixes a bug where a completing load or store which is also a barrier can push a

[gem5-dev] changeset in gem5: base: Reimplement the DPRINTF mechanism in a ...

2014-10-16 Thread Andrew Bardsley via gem5-dev
changeset 5744891a444b in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=5744891a444b description: base: Reimplement the DPRINTF mechanism in a Logger class This patch adds a Logger class encapsulating dprintf. This allows variants of DPRINTF logging

[gem5-dev] changeset in gem5: sim: SystemC hosting

2014-10-16 Thread Andrew Bardsley via gem5-dev
changeset 16fd06ecdb64 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=16fd06ecdb64 description: sim: SystemC hosting This patch hosts gem5 onto SystemC scheduler. There's already an upstream review board patch that does something similar but this

Re: [gem5-dev] Review Request 2456: base: Reimplement the DPRINTF mechanism in a Logger class

2014-10-09 Thread Andrew Bardsley via gem5-dev
On Sept. 29, 2014, 1:19 p.m., Nathan Binkert wrote: src/base/trace.cc, line 5 http://reviews.gem5.org/r/2456/diff/1/?file=42022#file42022line5 This isn't necessary for stuff in base, right? Andrew Bardsley wrote: Is there a copyright policy thing I don't know about base?

Re: [gem5-dev] Review Request 2425: config: Add a --without-python option to build process

2014-10-09 Thread Andrew Bardsley via gem5-dev
On Sept. 29, 2014, 1:08 p.m., Nathan Binkert wrote: src/SConscript, line 66 http://reviews.gem5.org/r/2425/diff/1/?file=41733#file41733line66 Why not just have one flag called skip_no_python? Andrew Bardsley wrote: I left the swig related and embedded python-related flags

Re: [gem5-dev] Review Request 2456: base: Reimplement the DPRINTF mechanism in a Logger class

2014-09-29 Thread Andrew Bardsley via gem5-dev
On Sept. 29, 2014, 1:19 p.m., Nathan Binkert wrote: src/base/trace.cc, line 5 http://reviews.gem5.org/r/2456/diff/1/?file=42022#file42022line5 This isn't necessary for stuff in base, right? Is there a copyright policy thing I don't know about base? On Sept. 29, 2014, 1:19 p.m.,

Re: [gem5-dev] Review Request 2425: config: Add a --without-python option to build process

2014-09-29 Thread Andrew Bardsley via gem5-dev
On Sept. 29, 2014, 1:08 p.m., Nathan Binkert wrote: src/SConscript, line 66 http://reviews.gem5.org/r/2425/diff/1/?file=41733#file41733line66 Why not just have one flag called skip_no_python? I left the swig related and embedded python-related flags separate as I thought it was

[gem5-dev] changeset in gem5: config: Cleanup .json config file generation

2014-09-20 Thread Andrew Bardsley via gem5-dev
changeset ec1af95a2958 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=ec1af95a2958 description: config: Cleanup .json config file generation This patch 'completes' .json config files generation by adding in the SimObject references and String-valued

[gem5-dev] changeset in gem5: base: Add getSectionNames to IniFile

2014-09-20 Thread Andrew Bardsley via gem5-dev
changeset 3f943443ae30 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=3f943443ae30 description: base: Add getSectionNames to IniFile Add an accessor to IniFile to list all the sections in the file. diffstat: src/base/inifile.cc | 10 ++

[gem5-dev] changeset in gem5: cpu: Fix memory access in Minor not setting p...

2014-09-12 Thread Andrew Bardsley via gem5-dev
changeset a7cb233caa7b in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=a7cb233caa7b description: cpu: Fix memory access in Minor not setting parent Request flags This patch fixes cases where uncacheable/memory type flags are not set correctly on a

[gem5-dev] changeset in gem5: style: Fix line continuation, especially in d...

2014-09-12 Thread Andrew Bardsley via gem5-dev
changeset bf52480abd01 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=bf52480abd01 description: style: Fix line continuation, especially in debug messages This patch closes a number of space gaps in debug messages caused by the incorrect use of line

[gem5-dev] changeset in gem5: sim: Fix checkpoint restore for Ticked

2014-09-03 Thread Andrew Bardsley via gem5-dev
changeset 82a4fa2d19a0 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=82a4fa2d19a0 description: sim: Fix checkpoint restore for Ticked This patch makes restoring the 'lastStopped' value for Ticked-containing objects (including MinorCPU) optional so

[gem5-dev] changeset in gem5: arm: ISA X31 destination register fix

2014-09-03 Thread Andrew Bardsley via gem5-dev
changeset 85001c018d4c in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=85001c018d4c description: arm: ISA X31 destination register fix This patch substituted the zero register for X31 used as a destination register. This prevents false dependencies

[gem5-dev] changeset in gem5: cpu: Minor CPU add regression tests for ARM a...

2014-07-24 Thread Andrew Bardsley via gem5-dev
changeset 384d554cea8c in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=384d554cea8c description: cpu: Minor CPU add regression tests for ARM and ALPHA This patch adds regression tests results and test harnesses for the Minor CPU on ARM and ALPHA.

[gem5-dev] changeset in gem5: cpu: `Minor' in-order CPU model

2014-07-24 Thread Andrew Bardsley via gem5-dev
changeset ebb376f73dd2 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=ebb376f73dd2 description: cpu: `Minor' in-order CPU model This patch contains a new CPU model named `Minor'. Minor models a four stage in-order execution pipeline (fetch lines,

Re: [gem5-dev] Review Request 2279: cpu: `Minor' in-order CPU model

2014-07-14 Thread Andrew Bardsley via gem5-dev
. Your proposal sounds great to me. Thanks a lot for being flexible. Steve On Tue, Jul 1, 2014 at 10:33 AM, Andrew Bardsley via gem5-dev gem5-dev@gem5.org wrote: Only slight modification to your proposal: How about I get rid of Ticked and flatten evaluate/minorTrace into the classes which need

Re: [gem5-dev] Review Request 2279: cpu: `Minor' in-order CPU model

2014-07-01 Thread Andrew Bardsley via gem5-dev
Only slight modification to your proposal: How about I get rid of Ticked and flatten evaluate/minorTrace into the classes which need it. I think that there aren't actually any cases where there need to be virtual calls to any of its member functions. I assume that by ClockedModule you mean

Re: [gem5-dev] Review Request 2279: cpu: `Minor' in-order CPU model

2014-06-18 Thread Andrew Bardsley via gem5-dev
On June 4, 2014, 8:15 p.m., Steve Reinhardt wrote: src/cpu/minor/Expr.py, line 48 http://reviews.gem5.org/r/2279/diff/1/?file=39827#file39827line48 This is pretty interesting... it would be nice to generalize this capability and not make it Minor-specific Andrew Bardsley

Re: [gem5-dev] Review Request 2279: cpu: `Minor' in-order CPU model

2014-06-05 Thread Andrew Bardsley via gem5-dev
On June 4, 2014, 8:15 p.m., Steve Reinhardt wrote: Nice! I didn't have time to read all the code closely, but I did notice a few things, and wanted to give feedback before I forgot. Basically the comments boil down to three things: 1. There are several pieces (Named,

[gem5-dev] changeset in gem5: cpu: Timebuf const accessors

2014-05-09 Thread Andrew Bardsley via gem5-dev
changeset 1ab8753de4d8 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=1ab8753de4d8 description: cpu: Timebuf const accessors Add const accessors for timebuf elements. diffstat: src/cpu/timebuf.hh | 32 +--- 1 files changed, 21

[gem5-dev] changeset in gem5: cpu: Useful getters for ActivityRecorder

2014-05-09 Thread Andrew Bardsley via gem5-dev
changeset 0f00b9e7305a in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=0f00b9e7305a description: cpu: Useful getters for ActivityRecorder Add some useful getters to ActivityRecorder diffstat: src/cpu/activity.hh | 11 +-- 1 files changed, 9

[gem5-dev] changeset in gem5: cpu: Allow setWhen on trace objects

2014-05-09 Thread Andrew Bardsley via gem5-dev
changeset 590ba8823163 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=590ba8823163 description: cpu: Allow setWhen on trace objects Allow setting of 'when' in trace records. This allows later times than the arbitrary record creation point to be used

[gem5-dev] changeset in gem5: arm: Add branch flags onto macroops

2014-05-09 Thread Andrew Bardsley via gem5-dev
changeset 6cf40d777682 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=6cf40d777682 description: arm: Add branch flags onto macroops Mark branch flags onto macroops to allow branch prediction before microop decomposition diffstat:

[gem5-dev] changeset in gem5: cpu: Add flag name printing to StaticInst

2014-05-09 Thread Andrew Bardsley via gem5-dev
changeset 30a20d2072c1 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=30a20d2072c1 description: cpu: Add flag name printing to StaticInst This patch adds a the member function StaticInst::printFlags to allow all of an instruction's flags to be