Re: [gem5-dev] RISC-V Patches False Dependencies

Hi Alec, I believe you can "cherry-pick" the change in the gerrit UI. Although, it could just be something that admins are allowed to do... Also, I won't comment on how cherry picking the change will affect your local branch. Jason On Wed, Apr 5, 2017 at 2:45 PM Alec Roelke

Re: [gem5-dev] nightly regressions

Hi Gabe, Thanks for going through and updating the stat files for all of the recent changes. The people who used to volunteer to do that haven't had time lately. Is there any reason I shouldn't just check off on all of the stats changes? Is there anything in the changesets to review? Cheers,

Re: [gem5-dev] adding reviewers in gerrit?

Original Message- > From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Jason > Lowe-Power > Sent: Saturday, March 25, 2017 11:38 AM > To: gem5 Developer List <gem5-dev@gem5.org> > Subject: Re: [gem5-dev] adding reviewers in gerrit? > > Hi Gabe, > &g

Re: [gem5-dev] nightly regressions

Hi Gabe, I think you've interpreted everything correctly. I think the only context you're missing is that we're planning to change the regressions such that there is no dependence on proprietary binaries. This will allow all users/developers to run the regressions before committing code. We

Re: [gem5-dev] PyBind11 as a SWIG replacement

Hi Andreas, I think it's OK for us to ignore the warnings. It isn't like SWIG didn't dump out 1000s of warnings before. I'll take a close look at the patch next Wed. or Thurs. Sorry for the delay. Jason On Wed, Mar 29, 2017 at 6:08 AM Andreas Sandberg wrote: > Hi

Re: [gem5-dev] adding reviewers in gerrit?

Hi Gabe, Hmm... It works for me. It's possible that we don't have the permissions set up correctly to allow anyone to add reviewers. I just tested with a non-admin account and it doesn't work for that account either. I'll look into it. Cheers, Jason On Sat, Mar 25, 2017 at 5:32 AM Gabe Black

Re: [gem5-dev] fallocate() not found for old Linux

Hi Paul, Contrary to what I've said in the past, I think it's time to retire support for RHEL5. The end of life for RHEL5 is the end of this month ( https://access.redhat.com/support/policy/updates/errata). We already have a large number of systems that must be tested (most of which we don't

[gem5-dev] Change in public/gem5[master]: misc: add missing copyright/author information in previous c...

Jason Lowe-Power has submitted this change and it was merged. ( https://gem5-review.googlesource.com/2224 ) Change subject: misc: add missing copyright/author information in previous commit .. misc: add missing copyright

[gem5-dev] Change in public/gem5[hpca]: ruby: fix MOESI_hammer directory to work with > 3GB memory

Jason Lowe-Power has submitted this change and it was merged. ( https://gem5-review.googlesource.com/2169 ) Change subject: ruby: fix MOESI_hammer directory to work with > 3GB memory .. ruby: fix MOESI_hammer direct

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

go. If someone has a suggestion for how to assign maintainers, let us know (probably in a new email chain). - Jason Lowe-Power On Feb. 21, 2017, 5:34 p.m., Jason Lowe-Power wrote: > > --- > This is an automatically generat

[gem5-dev] Best method for adding code to ext/

Hi all, There are a couple of patches in review that add a large chunk of code from other repositories to gem5 in ext/. Andreas S. has a patch that adds PyBind11 and Matthias is updating DRAMPower. And we're thinking about including SystemC in a similar way. Is there a better way for us to

Re: [gem5-dev] Migrating to git and gerrit

> command instead: > > git push origin HEAD:refs/for/master%topic=my/topic > > Some users can bypass reviews and push changes straight into the master > branch. This should only be done for code that has been reviewed using the > ReviewBoard-based flow. If you're one of the sel

Re: [gem5-dev] ISA Deprecation

Hi Brandon, See this discussion for some of the history here: http://comments.gmane.org/gmane.comp.emulators.m5.devel/30510 Let me try to summarize for everyone. There are a number of reasons to deprecate/phase out most of the supported ISAs. Briefly: - Less work for contributors especially

Re: [gem5-dev] Review Request 3838: ext: Update DRAMPower

the repo. This comment is not on topic for this patch, sorry. This patch is fine as it is :). - Jason Lowe-Power On Feb. 24, 2017, 9:56 p.m., Matthias Jung wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: [gem5-dev] Review Request 3836: x86: remove unnecessary parameter from functions

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3836/#review9471 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 23, 2017, 10:17 p.m

Re: [gem5-dev] Review Request 3833: style: change NULL to nullptr in syscall files

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3833/#review9463 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 23, 2017, 7:58 p.m

Re: [gem5-dev] Review Request 3832: style: local variable name correction

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3832/#review9462 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 23, 2017, 7:56 p.m

Re: [gem5-dev] Review Request 3821: base: Refactor logging to make log level selection cleaner

> On Feb. 21, 2017, 7:18 p.m., Jason Lowe-Power wrote: > > LGTM (+1). Quick question: Where is the default set? It wasn't obvious to > > me in skimming this, so maybe a comment somewhere? > > Andreas Sandberg wrote: > Logger instances are enabled by default when th

Re: [gem5-dev] Review Request 3819: python: Add a generalized mechanism to configure stats

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3819/#review9454 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 22, 2017, 10:02 a.m

Re: [gem5-dev] Review Request 3822: power: Avoid forward declarations that confuse wrappers

ore clear to call the new files "thermal_node.\*"? - Jason Lowe-Power On Feb. 21, 2017, 7:02 p.m., Andreas Sandberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: [gem5-dev] Review Request 3823: arch: Include generated decoder header after normal headers

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3823/#review9447 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 21, 2017, 6:55 p.m

Re: [gem5-dev] Review Request 3821: base: Refactor logging to make log level selection cleaner

obvious to me in skimming this, so maybe a comment somewhere? - Jason Lowe-Power On Feb. 21, 2017, 6:54 p.m., Andreas Sandberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3820: tests: Disable descriptions in stat files

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3820/#review9444 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 21, 2017, 6:53 p.m

Re: [gem5-dev] Review Request 3819: python: Add a generalized mechanism to configure stats

rience with them, so I could be wrong. - Jason Lowe-Power On Feb. 21, 2017, 6:53 p.m., Andreas Sandberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: [gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

Description --- changesets: 11849:b5f456096b51 "misc: Add a CONTRIBUTING document This document details how to contribute to gem5 based on our new contribution flow with git and gerrit. Signed-off-by: Jason Lowe-Power <ja...@lowepower.com>" Diffs (updated) -

Re: [gem5-dev] Review Request 3815: sim: fix out-of-bounds error in syscall_desc

Note: you should also add braces, if you add this inline comment. - Jason Lowe-Power On Feb. 16, 2017, 5:39 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://revie

[gem5-dev] Migrating to git and gerrit

Hi all, We've been talking about this for a while, but now it's time! Special thanks to Andreas Sandberg for all of his hard work for putting this together. We will be migrating our infrastructure from the self-hosted mercurial repo at repo.gem5.org and reviewboard to git and gerrit hosted on

[gem5-dev] Review Request 3814: misc: Add a CONTRIBUTING document

: 11849:b5f456096b51 "misc: Add a CONTRIBUTING document This document details how to contribute to gem5 based on our new contribution flow with git and gerrit. Signed-off-by: Jason Lowe-Power <ja...@lowepower.com>" Diffs - CONTRIBUTING PRE-CREATION Diff: http://re

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

I just pushed the other patch. Cheers, Jason On Wed, Feb 15, 2017 at 2:48 PM Brandon Potter <brandon.pot...@amd.com> wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3813/ > > On February 15th, 2017, 8:46 p.m. UTC, *Jason

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3813/#review9429 --- Same as http://reviews.gem5.org/r/3801? - Jason Lowe-Power On Feb. 15

Re: [gem5-dev] Thoughts On Project Using C++14

Hi Brandon, I agree with Andreas. It seems to me that it is a little too soon to require GCC 6.1. Until we're confident most people's IT infrastructure is using more recent Linuxes, it's going to be hard to go beyond C++11. Do you have any suggestions on how to make it simple for all of our

Re: [gem5-dev] Review Request 3809: imported patch rr_arbiter_fix

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3809/#review9426 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 12, 2017, 4:36 a.m

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

> On Jan. 25, 2017, 11:28 a.m., Andreas Sandberg wrote: > > Ship It! > > Andreas Hansson wrote: > What was the verdict? Is it just a matter of an updated patch > description/summary and then this should be pushed? > > Andreas Sandberg wrote: > Yes, the description needs to be updated.

Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]

screwed up when pushing all of the patches. I tried to go through and manually fix the rejections, but I'm not confident in how to do it. Could you update this diff on top of the current mainline? I'll commit it immediately once you do. Sorry for the inconvenience. - Jason Lowe-Power On Feb. 5

Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]

> On Feb. 11, 2017, 5:43 p.m., Andreas Hansson wrote: > > I think this one did not get committed. Is that right? Oops. That was an accidental oversight. Thanks for pointing it out. - Jason --- This is an automatically generated e-mail.

[gem5-dev] changeset in gem5: misc: Update #!env calls for python to explic...

"python2" instead of just "python" for all scripts that use #! Reported-by: Sanchayan Maity <maitysancha...@gmail.com> Signed-off-by: Jason Lowe-Power <ja...@lowepower.com> diffstat: ext/mcpat/regression/regression.py| 2 +- ext/mcpat/

[gem5-dev] changeset in gem5: misc: Add Python.h header to pyevents.hh

changeset 7788325d6855 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=7788325d6855 description: misc: Add Python.h header to pyevents.hh Signed-off-by: Jason Lowe-Power <ja...@lowepower.com> diffstat: src/python/swig/pyevent.hh | 2 ++ 1 files chan

[gem5-dev] changeset in gem5: x86: Fix implicit stack addressing in 64-bit ...

tested. See [1] page 9 (pdf page 45) For instructions that are affected see [1] page 519 (pdf page 555). [1] http://support.amd.com/TechDocs/24594.pdf Signed-off-by: Jason Lowe-Power <ja...@lowepower.com> diffstat: src/arch/x86/isa/insts/general_p

Re: [gem5-dev] Review Request 3808: mem: fix printing of 1st cache tags line

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3808/#review9413 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 7, 2017, 2:25 p.m

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

? - Jason Lowe-Power On Jan. 27, 2017, 1:39 p.m., Andreas Sandberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3802: mem, stats: fix typos in CommMonitor and Stats

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3802/#review9409 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 6, 2017, 1:43 p.m

Re: [gem5-dev] Review Request 3807: misc: fix includes in util/systemc

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3807/#review9405 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 5, 2017, 2:06 p.m

Re: [gem5-dev] Review Request 3805: mem: fix fast build breakage from CommMonitor refactoring

Pierre-Yves beat you so we can drop this one? - Jason Lowe-Power On Feb. 3, 2017, 4:49 p.m., Curtis Dunham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3800: x86: fix Mul1u instruction

using to test this? Any chance you can commit the test so we don't accidentally break this again in the future? - Jason Lowe-Power On Feb. 4, 2017, 12:13 a.m., Tony Gutierrez wrote: > > --- > This is an automatically generat

Re: [gem5-dev] Review Request 3801: mem, misc: fix building issue with CommMonitor (unused variables)

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3801/#review9399 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 3, 2017, 9:04 a.m

Re: [gem5-dev] Review Request 3803: sim: Patch to fix the statfs build

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3803/#review9398 --- Ship it! Thanks for fiing this, Bjoern! - Jason Lowe-Power On Feb. 3

Re: [gem5-dev] Review Request 3804: sim: fix build breakage in process.cc after brandon@11801

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3804/#review9397 --- Ship it! Ship It! - Jason Lowe-Power On Feb. 3, 2017, 4:29 p.m

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

x86_64 x86_64 x86_64 GNU/Linux). Linux boot works for both. I can provide the auxilary files I used (config scripts / kernel / disk images) if needed. Cheers, Jason On Fri, Feb 3, 2017 at 12:58 PM Jason Lowe-Power <ja...@lowepower.com> wrote: > Here's the three patches I've been using.

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

> Unfortunately I don't have an SVM capable machine around to test on so I > can't vet things myself, but if you guys have a patch you're confident > doesn't break either Intel or AMD KVM I can pass that along. Please let me > know if there's anything I can do to help. > > Gabe

Re: [gem5-dev] Review Request 3799: misc: Clean up and complete the gem5<->SystemC-TLM bridge [10/6]

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3799/#review9384 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 31, 2017, 10:58 a.m

Re: [gem5-dev] Review Request 3798: misc: Clean up and complete the gem5<->SystemC-TLM bridge [9/6]

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3798/#review9364 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 30, 2017, 4:40 p.m

Re: [gem5-dev] Review Request 3798: misc: Clean up and complete the gem5<->SystemC-TLM bridge [9/6]

> On Jan. 31, 2017, 4:10 p.m., Jason Lowe-Power wrote: > > I don't follow why you don't need to pay for the payload delay. Is that > > taken care of at some other point in the System-C model? > > Christian Menard wrote: > Simply paying for the payload delay in the t

Re: [gem5-dev] Review Request 2557: x86: kvm: Fix the KVM CPU in SE and FS on Intel CPUs.

> On Jan. 30, 2017, 10:31 p.m., Gabe Black wrote: > > Hi folks. I put together this patch a long time ago, there was some > > discussion about it, and then I lost track of what was going on with it. > > Have the issues it causes with AMD cpus been tracked down? Glancing through > > this

Re: [gem5-dev] Review Request 3798: misc: Clean up and complete the gem5<->SystemC-TLM bridge [9/6]

. Is that taken care of at some other point in the System-C model? - Jason Lowe-Power On Jan. 30, 2017, 4:40 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3797: misc: Clean up and complete the gem5<->SystemC-TLM bridge [8/6]

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3797/#review9354 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 30, 2017, 4:38 p.m

Re: [gem5-dev] Review Request 3378: scons: make build better on FreeBSD

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3378/#review9352 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 31, 2017, 1:44 p.m

Re: [gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

. 27, 2017, 10:59 p.m., Jason Lowe-Power wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3793/ > --- &g

Re: [gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

" to build/run/test gem5. Thanks, Jason Lowe-Power ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Ideas for sprint projects

zel? It feels to me > "replacing scons with cmake" will be more beneficial (assuming cmake is > more common for gem5 developers than bazel). > > Cagdas > > -Original Message- > From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Jason > Lowe-Power > Se

Re: [gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

" to build/run/test gem5. Thanks, Jason Lowe-Power ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

e handled correctly. On Jan. 26, 2017, 6:47 p.m., Jason Lowe-Power wrote: > > If we were trying to keep things clean, I'd suggest adding new micro-ops > > like ld.ss and st.ss that would wrap ld an st and automatically set > > segment=ss, implicitStack=True, addressS

[gem5-dev] Review Request 3795: misc: Add Python.h header to pyevents.hh

Python.h header to pyevents.hh Diffs - src/python/swig/pyevent.hh cd7f3a1dbf55 Diff: http://reviews.gem5.org/r/3795/diff/ Testing --- Thanks, Jason Lowe-Power ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo

Re: [gem5-dev] Review Request 3792: misc: Update #!env calls for python to explicit version

n/bash" to build/run/test gem5. Thanks, Jason Lowe-Power ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3792: misc: Update #!env calls for python to explicit version

-mail. To reply, visit: http://reviews.gem5.org/r/3792/#review9337 --- On Jan. 26, 2017, 4:47 p.m., Jason Lowe-Power wrote: > > --- > This is an automatically generated e-mail.

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

> On Jan. 27, 2017, 3 p.m., Jason Lowe-Power wrote: > > Oops. I should have included this in my description of > > http://reviews.gem5.org/r/3792/. I think another solution is to include > > Python.h in src/python/swig/pyevent.hh. See my change in > > http://reviews

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

> On Jan. 27, 2017, 3 p.m., Jason Lowe-Power wrote: > > Oops. I should have included this in my description of > > http://reviews.gem5.org/r/3792/. I think another solution is to include > > Python.h in src/python/swig/pyevent.hh. See my change in > > http://reviews

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

://reviews.gem5.org/r/3792/. I think another solution is to include Python.h in src/python/swig/pyevent.hh. See my change in http://reviews.gem5.org/r/3792/diff/1/#33. If my fix does work, I think it's better to just include Python.h there instead of changing the style. - Jason Lowe-Power On Jan. 27

Re: [gem5-dev] Compilation error for gem5 after statfs change

low cost and > effort of deployment. Virtualbox + some flavour of BSD would do it. > > Andreas > > On 25/01/2017, 23:18, "gem5-dev on behalf of Jason Lowe-Power" > <gem5-dev-boun...@gem5.org on behalf of ja...@lowepower.com> wrote: > > >Yeah, it's a major problem t

Re: [gem5-dev] Ideas for sprint projects

> >> > >>Large projects: > >> * Get scons to build basic components only once and share them > >>between architectures > >> > >> > >>I'd like to throw cmake in to the build system mix as well. I started > >>hacking on a small proto

Re: [gem5-dev] Bug in x86 stack instructions

on, you need to know how to truncate the result you get, or sign > extension, carry bits, etc., cause a problem and, if I remember correctly, > cause spurious GP faults. > > This could all be simplified if the TLB applied the segment bases, but then > I think that would likely complic

Re: [gem5-dev] Review Request 3756: cpu: Result refactoring

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3756/#review9322 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 26, 2017, 1:40 p.m

Re: [gem5-dev] Review Request 3756: cpu: Result refactoring

> On Jan. 19, 2017, 10:18 p.m., Jason Lowe-Power wrote: > > Does converting this to a class have any impact on performance? > > Rekai Gonzalez Alberquilla wrote: > The honest reply is I do not know. The long reply is: I did differential > performance analysis betw

[gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

-it powerjg/arch-dev /bin/bash" to build/run/test gem5. Thanks, Jason Lowe-Power ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3792: misc: Update #!env calls for python to explicit version

t; to build/run/test gem5. Thanks, Jason Lowe-Power ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Compilation error for gem5 after statfs change

on a long-term solution here? Cheers, Jason On Tue, Jan 24, 2017 at 5:46 PM Bjoern A. Zeeb < bzeeb-li...@lists.zabbadoz.net> wrote: On 24 Jan 2017, at 22:08, Jason Lowe-Power wrote: > Hi Brandon, > > I think this is a "real" bug: > http://qa.gem5.org//1905/compiling

Re: [gem5-dev] Bug in x86 stack instructions

t; stack segment, it's address size should be set to the stack size when > > doing > > > memory operations. Adding addressSize=ssz to the st microop should do > > that. > > > > > > According to that pseudo code, the size of the target IP is also the > >

Re: [gem5-dev] Review Request 3791: dev: net/i8254xGBe add two more wakeup registers to ignore

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3791/#review9317 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 25, 2017, 11:28 a.m

Re: [gem5-dev] Bug in x86 stack instructions

en). > There's probably a cleaner way, but that's the easiest path I can think of > (if it even works). > > [1] http://grok.gem5.org/xref/gem5/src/arch/x86/decoder.cc#195 > [2] http://grok.gem5.org/xref/gem5/src/arch/x86/decoder.cc#390 > [3] http://grok.gem5.org/source/xref/gem5/src/

[gem5-dev] Compilation error for gem5 after statfs change

Hi Brandon, I think this is a "real" bug: http://qa.gem5.org//1905/compiling-problem-gem5-mac-os-10-11-6-scons-build-arm-gem5-opt. I think there are a few more places that need an #ifdef NO_STATFS. Could you look into it and post a patch if there's a problem? If not, please reply to the gem5 QA

Re: [gem5-dev] Bug in x86 stack instructions

/gem5/src/arch/x86/isa.cc#91 [3] http://grok.gem5.org/xref/gem5/src/arch/x86/decoder.cc#400 On Mon, Jan 23, 2017 at 4:04 PM, Jason Lowe-Power <ja...@lowepower.com> wrote: > To those of you with more x86 ISA implementation knowledge than I have: > > I've been working through a b

Re: [gem5-dev] Review Request 3754: cpu: Simplify the rename interface and use RegId

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3754/#review9309 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 16, 2017, 11:46 a.m

Re: [gem5-dev] Review Request 3790: x86: fixed branching computation for branch uops that only changes nupc and not npc

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3790/#review9308 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 23, 2017, 3:39 p.m

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3785/#review9307 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 17, 2017, 10:04 p.m

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

> On Jan. 18, 2017, 4:02 p.m., Jason Lowe-Power wrote: > > Is there any way you can remove the #if USE_KVM from the system.cc file? I > > don't have any suggestions off the top of my head, though. > > Curtis Dunham wrote: > We agree that it's not the best, bu

[gem5-dev] Bug in x86 stack instructions

To those of you with more x86 ISA implementation knowledge than I have: I've been working through a bug one of our users found (thanks Sanchayan!). It looks like current versions of ld use the 0x67 instruction prefix (address size override) as an optimization instead of using a nop. See

Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9290 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 19, 2017, 6:28 p.m

Re: [gem5-dev] Review Request 3778: Fix order of object construction in the CxxConfigManager

calls findObject("root"), then it calls findObject() on each of root's children, and so on. So there wasn't any need for the findObject call here. - Jason Lowe-Power On Jan. 9, 2017, 1:53 p.m., Christ

Re: [gem5-dev] Review Request 3757: arch: added generic vector register

. Will a new person be able to come in and understand what's going on? Though, it isn't like any of this ISA code is understandable until you put weeks or months of effort in. So, feel free to ignore this comment. - Jason Lowe-Power On Jan. 16, 2017, 11:54 a.m., Rekai Gonzalez Alberquilla wrote

Re: [gem5-dev] Review Request 3756: cpu: Result refactoring

/cpu/base_dyn_inst.hh (line 169) <http://reviews.gem5.org/r/3756/#comment7932> Why is this now a deque? Seems like you still only push_back and pop_front. - Jason Lowe-Power On Jan. 16, 2017, 11:52 a.m., Rekai Gonzalez Alberquilla

Re: [gem5-dev] Review Request 3754: cpu: Simplify the rename interface and use RegId

this code. Other than the small question below, it looks OK to me. src/cpu/reg_class_impl.hh (line 1) <http://reviews.gem5.org/r/3754/#comment7931> Why is this an implemenation header file? - Jason Lowe-Power On Jan. 16, 2017, 11:46 a.m., Rekai Gonzalez Alberquilla

Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3670/#review9272 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 17, 2016, 3:14 p.m

Re: [gem5-dev] Review Request 3783: mem: Update DRAM configuration names

> On Jan. 18, 2017, 3:21 p.m., Jason Lowe-Power wrote: > > While you're on this code, I have a question. Maybe Andreas H. can answer > > too. Why are all of the configurations for the memory controllers in > > src/mem/DRAMCtrl.py? They could all be in configs/d

Re: [gem5-dev] Review Request 3780: riscv: Fix crash when syscall argument reg index is too high

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3780/#review9267 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 18, 2017, 5:39 p.m

Re: [gem5-dev] Review Request 3780: riscv: Fix crash when syscall argument reg index is too high

> On Jan. 18, 2017, 4:06 p.m., Jason Lowe-Power wrote: > > src/arch/riscv/process.cc, line 222 > > <http://reviews.gem5.org/r/3780/diff/1/?file=64366#file64366line222> > > > > Two comments: > > 1. Shouldn't this at least have a warnin

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

> On Jan. 18, 2017, 4:04 p.m., Jason Lowe-Power wrote: > > tests/test-progs/insttest/src/riscv/rv64i.cpp, line 238 > > <http://reviews.gem5.org/r/3781/diff/1/?file=64383#file64383line238> > > > > Can you block-comment instead of delete? I think we'll want

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

ttp://reviews.gem5.org/r/3781/#comment7923> Can you block-comment instead of delete? I think we'll want to add this back in sometime in the relatively near future (e.g., when we have functional-only tests). - Jason Lowe-Power On Jan. 12, 2017, 9:18 p.m., Alec Roelke

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

? I don't have any suggestions off the top of my head, though. - Jason Lowe-Power On Jan. 17, 2017, 10:04 p.m., Curtis Dunham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3786: arm, kvm: implement MuxingKvmGic

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3786/#review9256 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 17, 2017, 10:04 p.m

Re: [gem5-dev] Review Request 3788: arm, kvm: remove KvmGic

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3788/#review9258 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 17, 2017, 10:04 p.m

Re: [gem5-dev] Review Request 3787: arm, kvm: Automatically use the MuxingKvmGic

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3787/#review9257 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 17, 2017, 10:04 p.m

<    4   5   6   7   8   9   10   11   12   >