Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-23 Thread Jason Lowe-Power
I think that makes sense. I'll put a patch on RB for this soon. Jason On Wed, Nov 23, 2016 at 5:09 AM Fernando Endo wrote: > Hi all, > > Then, considering Arthur's answer, I suppose that we can remove > BPredUnit::predictInOrder() rather than updating and not testing it. > > Regards, > > -- > F

Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-23 Thread Fernando Endo
Hi all, Then, considering Arthur's answer, I suppose that we can remove BPredUnit::predictInOrder() rather than updating and not testing it. Regards, -- Fernando A. Endo, Post-doc INRIA Rennes-Bretagne Atlantique France 2016-11-21 19:19 GMT+01:00 Arthur Perais : > I suppose it was called by

Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-21 Thread Arthur Perais
I suppose it was called by the InOrder CPU once upon a time. Now the Minor CPU uses the same branch prediction code as the o3 CPU, which may have led to the current inconsistencies in how branch predictors handle out-of-order mispredictions (or not :)). I've submitted a patch regarding this re

Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-21 Thread Jason Lowe-Power
Hi Fernando, I don't know what he original use of predictInOrder was, but you're right, it doesn't look like it's in use now. You may be able to figure out what it was used for by inferring its function from the code. Jason On Sun, Nov 13, 2016 at 2:37 PM Jason Lowe-Power wrote: > Hi Fernando,

Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-13 Thread Jason Lowe-Power
Hi Fernando, I have no idea, off the top of my head. I'd have to look into the code and/or the history of the file to figure it out. I'm busy with an ISCA submission right now, but I can find time to look into this in a week or so. Cheers, Jason On Sun, Nov 13, 2016 at 2:26 PM Fernando Endo wr

Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-13 Thread Fernando Endo
Hi Jason, I've been working a bit on the integration, and I wondered what is and where this method is used: BPredUnit::predictInOrder() I greped the source and built code and did not find a calling point. Thanks, -- Fernando A. Endo, Post-doc INRIA Rennes-Bretagne Atlantique France 2016-11-

Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-06 Thread Jason Lowe-Power
Hi Fernando, Yes, it seems like a good idea to include a TAGE predictor in gem5. Please make patches and post them to the reviewboard. We welcome the contribution. Additionally, I believe there was a recent email about a possible bug when updating the branch predictor state on a mis-speculation.

[gem5-dev] Patches of TAGE branch predictor

2016-11-04 Thread Fernando Endo
Hello all, I'd like to know if the gem5 community would like to have a TAGE branch prediction in gem5. In my branch it seems to be working, so if you give me a positive feedback I may spend some spare time to rebase and test the patch over mainstream. More specifically, I took the CBP2016 winner