[gem5-dev] Finalizing new testing framework

2018-07-05 Thread Jason Lowe-Power
Hi all, I'm hoping that we can finalize the new testing framework, and I can push it in within the next week or so. All of the important changes have at least one +2, but I want to give everyone one last chance to object or suggest changes. I've been talking to Sean, and while there's more that co

Re: [gem5-dev] Finalizing new testing framework

2018-07-09 Thread Gabe Black
Hi Jason, thanks for making sure everybody has a chance to chime in. I haven't looked at the changes in a while, but I'm also comfortable with them going in without looking them over again given that other people have +2-ed them, the high likelihood it will improve on the status quo, and that we sh

Re: [gem5-dev] Finalizing new testing framework

2018-07-13 Thread Andreas Sandberg
Hi Jason, Thanks for doing this. I haven't had a chance to look at the code in details myself, but from what I have seen it looks like a real improvement. Ideally, I'd like someone from our side (probably Giacomo T) to have a look at it. However, Giacomo is currently travelling and I have othe

Re: [gem5-dev] Finalizing new testing framework

2018-08-02 Thread Jason Lowe-Power
Hi all, Some more follow up. Sorry that this is going so slowly. Sean just did a pretty major reworking of the main library. See https://gem5-review.googlesource.com/4421. I'll let him address Andreas's questions below. I think we're pretty close to having all three. I would really like to get t

Re: [gem5-dev] Finalizing new testing framework

2018-08-03 Thread Andreas Sandberg
OK, that sounds reasonable. We shouldn't have any issues with that. I'd like someone from us to have a look as well, most likely Giacomo since I won't be able to find the time myself. However, don't let that block anything. Last time I looked at the code, it looked reasonable. I'm sure we can f

Re: [gem5-dev] Finalizing new testing framework

2018-08-03 Thread Jason Lowe-Power
Sounds good. We can give it a week or so before we push. I won't have any time to work on much between now and then anyway. Cheers, Jason On Fri, Aug 3, 2018 at 2:50 AM Andreas Sandberg wrote: > OK, that sounds reasonable. We shouldn't have any issues with that. > > I'd like someone from us to