Re: [gem5-dev] Review Request 2304: base: fix some bugs in EthAddr

2014-07-02 Thread Anthony Gutierrez via gem5-dev
> On July 2, 2014, 12:08 a.m., Steve Reinhardt wrote: > > src/base/inet.hh, line 101 > > > > > > seems like it would be more consistent with the other code to do a loop > > up to ETH_ADDR_LEN, but this works too. fixed -

Re: [gem5-dev] Review Request 2304: base: fix some bugs in EthAddr

2014-07-02 Thread Anthony Gutierrez via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2304/ --- (Updated July 2, 2014, 3:51 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2304: base: fix some bugs in EthAddr

2014-07-01 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2304/#review5174 --- Ship it! src/base/inet.hh

Re: [gem5-dev] Review Request 2304: base: fix some bugs in EthAddr

2014-06-26 Thread Ali Saidi via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2304/#review5167 --- Ship it! Ship It! - Ali Saidi On June 26, 2014, 9:49 p.m., Anthony Gu

[gem5-dev] Review Request 2304: base: fix some bugs in EthAddr

2014-06-26 Thread Anthony Gutierrez via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2304/ --- Review request for Default. Repository: gem5 Description --- Changeset 10243