Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

> On Dec. 8, 2014, 2:36 p.m., Andreas Hansson wrote: > > src/cpu/kvm/vm.cc, line 374 > > > > > > I think this causes problems with some of the officially supported > > compilers. It's just a hunch, but please check. > > Ga

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

> On Dec. 8, 2014, 2:36 p.m., Andreas Hansson wrote: > > src/cpu/kvm/vm.cc, line 374 > > > > > > I think this causes problems with some of the officially supported > > compilers. It's just a hunch, but please check. Ugh. Y

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2510/#review5653 --- src/cpu/kvm/vm.cc I t

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2510/#review5652 --- Ship it! I'm still not happy with the setupMemSlot()/disableMemSlot() na

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

I think it’s fine that a device wants to do this, I’d just like it to use an thin interface on the System object as a matter of clean interfaces in the object hierarchy, so unrelated objects don’t have to know about each other. Ali On Dec 3, 2014, at 11:54 AM, Gabe Black via gem5-dev wrote:

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

> On Dec. 3, 2014, 11:42 a.m., Andreas Hansson wrote: > > As this is quite invasive, how broadly would this be used? Also, is there > > any chance of rather using devices that do not have memory of their own > > (and rely on the "normal" system memory that is already mapped)? The one example I

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2510/#review5613 --- As this is quite invasive, how broadly would this be used? Also, is there

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2510/#review5611 --- Ping - Gabe Black On Nov. 23, 2014, 2:51 p.m., Gabe Black wrote: > >

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2510/ --- (Updated Nov. 23, 2014, 2:51 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

> On Nov. 19, 2014, 4:39 p.m., Andreas Sandberg wrote: > > src/cpu/kvm/vm.hh, line 354 > > > > > > Would it make sense to rename this to mapMemSlot? In my opinion, that'd > > be more descriptive. No, I don't think so. A sl

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

On Nov. 19, 2014, 4:39 p.m., Gabe Black wrote: > > Overall, I'd prefer this to be an internal API and have some way of > > notifying the VM through the System instead of allowing objects to poke > > around directly. See my reply in the email thread for RB #2513. The device is asking for a spec

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2510/#review5489 --- src/cpu/kvm/vm.hh The

[gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2510/ --- Review request for Default. Repository: gem5 Description --- Changeset 10546