Re: [gem5-dev] Review Request 2619: cpu: Add L-TAGE branch predictor

2015-03-06 Thread Nilay Vaish via gem5-dev
On Fri, 6 Mar 2015, Dibakar Gope wrote: On March 4, 2015, 6:54 p.m., Nilay Vaish wrote: OK. I am sorry for not realizing that so many changes would be required to separate out the params just meant for LTAGE. Had I had realized that, I probably would not have asked for it. I think we

Re: [gem5-dev] Review Request 2619: cpu: Add L-TAGE branch predictor

2015-03-04 Thread Nilay Vaish via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2619/#review5938 --- OK. I am sorry for not realizing that so many changes would be required

Re: [gem5-dev] Review Request 2619: cpu: Add L-TAGE branch predictor

2015-03-04 Thread Nilay Vaish via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2619/#review5936 --- Several lines seem to have more than 80 characters.

Re: [gem5-dev] Review Request 2619: cpu: Add L-TAGE branch predictor

2015-03-03 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2619/#review5927 --- Ship it! Some minor formatting issues, but overall it looks good.

Re: [gem5-dev] Review Request 2619: cpu: Add L-TAGE branch predictor

2015-02-03 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2619/#review5816 --- Something is still not quite right with the diffs. - Andreas Hansson