Re: [gem5-dev] Review Request 2871: python: Remove redundant drain when changing memory modes

2015-07-05 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2871/#review6712 --- Ship it! - Steve Reinhardt On June 8, 2015, 4:32 a.m., Andreas Sandber

Re: [gem5-dev] Review Request 2871: python: Remove redundant drain when changing memory modes

2015-07-05 Thread Andreas Sandberg
> On July 4, 2015, 6:32 p.m., Steve Reinhardt wrote: > > So is the assumption here that, if you're switching memory modes, you will > > always call switchCpus with do_drain=True? Other than that I don't see > > where the redundant drain is coming from. > > > > Also, if the system is already dr

Re: [gem5-dev] Review Request 2871: python: Remove redundant drain when changing memory modes

2015-07-04 Thread Steve Reinhardt
> On July 4, 2015, 10:32 a.m., Steve Reinhardt wrote: > > So is the assumption here that, if you're switching memory modes, you will > > always call switchCpus with do_drain=True? Other than that I don't see > > where the redundant drain is coming from. > > > > Also, if the system is already d

Re: [gem5-dev] Review Request 2871: python: Remove redundant drain when changing memory modes

2015-07-04 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2871/#review6700 --- So is the assumption here that, if you're switching memory modes, you wil

Re: [gem5-dev] Review Request 2871: python: Remove redundant drain when changing memory modes

2015-06-19 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2871/#review6509 --- Ship it! Ship It! - Nilay Vaish On June 8, 2015, 11:32 a.m., Andreas

[gem5-dev] Review Request 2871: python: Remove redundant drain when changing memory modes

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2871/ --- Review request for Default. Repository: gem5 Description --- Changeset 10869