Re: [gem5-dev] Review Request 3691: hsail: fix unsigned offset bug in address calculation

2016-11-01 Thread Tony Gutierrez
> On Nov. 1, 2016, 7:09 a.m., Jason Lowe-Power wrote: > > LGTM. Just to double check, if the offset is -3, then offset.hi is 0 and > > offset.low is -3 in two's complement? I.e., if the instruction is 32-bits, > > the offset is NOT sign extended in BRIG? Yep. That is precisely the scenario

Re: [gem5-dev] Review Request 3691: hsail: fix unsigned offset bug in address calculation

2016-11-01 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3691/#review9009 --- Ship it! LGTM. Just to double check, if the offset is -3, then

[gem5-dev] Review Request 3691: hsail: fix unsigned offset bug in address calculation

2016-10-31 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3691/ --- Review request for Default. Repository: gem5 Description --- Changeset