Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-12-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3743/#review9215 --- Ship it! Ship It! - Jason Lowe-Power On Dec. 16, 2016, 3:17 p.m.,

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-12-15 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3743/#review9209 --- src/cpu/pred/ltage.hh (line 379)

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-12-15 Thread Jason Lowe-Power
> On Nov. 23, 2016, 3:17 p.m., Jason Lowe-Power wrote: > > src/cpu/pred/BranchPredictor.py, line 100 > > > > > > Comment is now wrong. > > > > Also, does it make more sense to call this histBufferEntries (or > >

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-11-23 Thread Arthur Perais
> On nov. 23, 2016, 3:17 après-midi, Jason Lowe-Power wrote: > > src/cpu/pred/BranchPredictor.py, line 100 > > > > > > Comment is now wrong. > > > > Also, does it make more sense to call this histBufferEntries (or

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-11-23 Thread Nathanael Premillieu
> On Nov. 23, 2016, 3:17 p.m., Jason Lowe-Power wrote: > > src/cpu/pred/BranchPredictor.py, line 100 > > > > > > Comment is now wrong. > > > > Also, does it make more sense to call this histBufferEntries (or > >

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-11-23 Thread Nathanael Premillieu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3743/#review9159 --- Ship it! Ship It! - Nathanael Premillieu On Nov. 23, 2016, 2:52

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-11-23 Thread Arthur Perais
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3743/ --- (Updated nov. 23, 2016, 2:52 après-midi) Review request for Default. Changes

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-11-22 Thread Arthur Perais
Jason, thanks for the feedback, I'll do my best to address everything tomorrow, but I've added some replies to your comments inline. - Mail original - > De: "Jason Lowe-Power" > À: "Default" , "Jason Lowe-Power" , >

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-11-22 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3743/#review9154 --- A few thing below. Overall, could you please add more comments? No need

[gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-11-22 Thread Arthur Perais
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3743/ --- Review request for Default. Repository: gem5 Description --- Changeset