Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

2017-02-07 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3794/#review9412 --- Ship it! Update the commit message with a link to the python manual? -

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

2017-02-07 Thread Andreas Sandberg
> On Jan. 27, 2017, 3 p.m., Jason Lowe-Power wrote: > > Oops. I should have included this in my description of > > http://reviews.gem5.org/r/3792/. I think another solution is to include > > Python.h in src/python/swig/pyevent.hh. See my change in > >

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

2017-01-27 Thread Jason Lowe-Power
> On Jan. 27, 2017, 3 p.m., Jason Lowe-Power wrote: > > Oops. I should have included this in my description of > > http://reviews.gem5.org/r/3792/. I think another solution is to include > > Python.h in src/python/swig/pyevent.hh. See my change in > >

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

2017-01-27 Thread Andreas Sandberg
> On Jan. 27, 2017, 3 p.m., Jason Lowe-Power wrote: > > Oops. I should have included this in my description of > > http://reviews.gem5.org/r/3792/. I think another solution is to include > > Python.h in src/python/swig/pyevent.hh. See my change in > >

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

2017-01-27 Thread Jason Lowe-Power
> On Jan. 27, 2017, 3 p.m., Jason Lowe-Power wrote: > > Oops. I should have included this in my description of > > http://reviews.gem5.org/r/3792/. I think another solution is to include > > Python.h in src/python/swig/pyevent.hh. See my change in > >

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

2017-01-27 Thread Andreas Sandberg
> On Jan. 27, 2017, 3 p.m., Jason Lowe-Power wrote: > > Oops. I should have included this in my description of > > http://reviews.gem5.org/r/3792/. I think another solution is to include > > Python.h in src/python/swig/pyevent.hh. See my change in > >

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

2017-01-27 Thread Pierre-Yves Péneau
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3794/#review9332 --- Ship it! Ship It! - Pierre-Yves Péneau On Jan. 27, 2017, 2:39 p.m.,

Re: [gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

2017-01-27 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3794/#review9331 --- Oops. I should have included this in my description of

[gem5-dev] Review Request 3794: style: Force Python.h to be included before main header

2017-01-27 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3794/ --- Review request for Default. Repository: gem5 Description --- Changeset