Dear all,
I'm currently in the process of updating CONTRIBUTING.md with some Gerrit Code
Review guidelines (please see my WIP change here:
https://gem5-review.googlesource.com/c/public/gem5/+/21419 ). My reason for
doing this is finding out no one really knows the procedure for addressing some
Behalf Of Bobby Bruce
Sent: Friday, October 4, 2019 11:21 AM
To: gem5 Developer List
Subject: [gem5-dev] Updating Contribution.md review guidelines. Feedback
appreciated.
[CAUTION: External Email]
Dear all,
I'm currently in the process of updating CONTRIBUTING.md with some Gerrit Code
Re
Sent: Friday, October 4, 2019 1:23 PM
To: gem5 Developer List
Subject: Re: [gem5-dev] Updating Contribution.md review guidelines. Feedback
appreciated.
Thanks Bobby.
Most of this looks good to me, except can we extend the "no response period" in
1) from 48 hours to 2 weeks? Abandoning
stuff.
From: gem5-dev on behalf of Bobby Bruce
Sent: Friday, October 4, 2019 7:21 PM
To: gem5 Developer List
Subject: [gem5-dev] Updating Contribution.md review guidelines. Feedback
appreciated.
Dear all,
I'm currently in the process of updating CONTRIBUTING.md with some Gerrit Co
Hi
An alternative solution could be to flag these commits with "pending adoption."
In the past, I've been interested in pending commits, and I've added them to my
watchlist, waiting to know the outcome. In other cases, I have personally used
a commit waiting to be submitted (for example, all th
l, UC Davis
Davis,
CA, 95616
From: gem5-dev on behalf of Andrea Mondelli
Sent: Saturday, October 5, 2019 9:02 AM
To: gem5 Developer List
Subject: Re: [gem5-dev] Updating Contribution.md review guidelines. Feedback
appreciated.
Hi
An alternative solution could be to
