Re: [gem5-dev] m5 utility patch series

2020-04-08 Thread Gabe Black
On Wed, Apr 8, 2020 at 5:39 PM Jason Lowe-Power wrote: > Hey Gabe, > > I still don't feel like this gives me enough context to do a good job > reviewing these changesets. For instance, before, I would go to util/m5 and > run `make -f Makefile.` to create the m5 utility. What is the new >

Re: [gem5-dev] m5 utility patch series

2020-04-08 Thread Jason Lowe-Power
Hey Gabe, I still don't feel like this gives me enough context to do a good job reviewing these changesets. For instance, before, I would go to util/m5 and run `make -f Makefile.` to create the m5 utility. What is the new process? It seems to be done with scons? Where is the binary created when

Re: [gem5-dev] m5 utility patch series

2020-04-07 Thread Gabe Black
Hi Jason. As I've said somewhere before (maybe this thread?), that is mostly not changing. There will still be an m5 library for use in other programs, a java and lua wrapper, an m5 utility which takes basically the same commands (with some cruft removed), etc. The changes are that I'm refactoring

Re: [gem5-dev] m5 utility patch series

2020-04-07 Thread Jason Lowe-Power
Hey Gabe, I'd love to review your patches that you've posted improving the m5 utility, but I don't feel that I can review them well without understanding what the end goal is. If you could provide some documentation on how you see the m5 utility being used, then I can try to carve out some time

Re: [gem5-dev] m5 utility patch series

2020-03-31 Thread Gabe Black
Hi Jason, replies inline. On Tue, Mar 31, 2020 at 3:29 PM Jason Lowe-Power wrote: > Oh, one more comment... > > Do you think it's worth changing the name to "gem5" instead of "m5". Since > we're making big changes, it seems like now might be right time. > That's not a bad idea, although there

Re: [gem5-dev] m5 utility patch series

2020-03-31 Thread Jason Lowe-Power
Oh, one more comment... Do you think it's worth changing the name to "gem5" instead of "m5". Since we're making big changes, it seems like now might be right time. Cheers, Jason On Tue, Mar 31, 2020 at 3:10 PM Jason Lowe-Power wrote: > Hey Gabe, > > First of all, thanks for this cleanup.

Re: [gem5-dev] m5 utility patch series

2020-03-31 Thread Jason Lowe-Power
Hey Gabe, First of all, thanks for this cleanup. We've needed to update this code for a long time! Do you have a pointer to what would be "new" documentation on the m5 ops tools? I was briefly going through your changes and it's not clear how you're envisioning people using this library now. For

[gem5-dev] m5 utility patch series

2020-03-27 Thread Gabe Black
Hi folks. I just uploaded a series (mostly small) patches which revamp the m5 utility as described in a design document I sent out a while ago. I've done some very preliminary sanity testing, but a lot more testing can/should be done to make sure I didn't screw anything up. One thing in