Re: [gem5-dev] Review Request: SLICC: Add a check function for State Machine

2011-06-10 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/723/#review1320 --- src/mem/slicc/symbols/StateMachine.py

Re: [gem5-dev] Single Header File for Debug Flags

2011-06-09 Thread nathan binkert
> Well, I guess the recompilation tradeoff is worth the temporary annoyance of > adding the specific debug flag header file everywhere. > > I'm also hoping that the new changes will allow us to eventually make > compound flags of compound flags. The changes are already in the tree (and have been fo

Re: [gem5-dev] Single Header File for Debug Flags

2011-06-08 Thread nathan binkert
Oh, and I forgot. Compound flags generate a header file as well. debug/O3CPUAll.hh for example would have all of the flags that O3CPUAll covers On Wed, Jun 8, 2011 at 9:40 PM, nathan binkert wrote: >> What do people (mostly Nate) think about having a single header file for all >>

Re: [gem5-dev] Single Header File for Debug Flags

2011-06-08 Thread nathan binkert
> What do people (mostly Nate) think about having a single header file for all > debug flags? > > Instead of "#include "debug/MyFlag.hh" for every flag you want in a DPRINTF, > you could say "#include "debug/debugflags.hh" and that would cover all the > debug flags available for DPRINTF. > > Would

Re: [gem5-dev] changeset in m5: scons: rename TraceFlags to DebugFlags

2011-06-08 Thread nathan binkert
> Why not just let TraceFlags be interpreted as DebugFlags, so TraceFlags still > works for users. For better or worse, I renamed trace flags to debug flags and I should have changed the name of TraceFlags to DebugFlags when I did that, so this was just correcting that and removing an inconsisten

Re: [gem5-dev] [m5-dev] Review Request: stats: move code that loops over all stats into python

2011-06-08 Thread nathan binkert
> I'm trying to call a global function implemented in C++ from a function in > the Python __init__.py file, how can I do that? Is that a good example that I > can follow? Just add your function foo() to src/python/swig/core.i and then you can access it from m5.internal.core.foo() Most of the fu

Re: [gem5-dev] [m5-dev] Review Request: stats: move code that loops over all stats into python

2011-06-06 Thread nathan binkert
> Where in the code is the signal from "kill -USR1" handled to dump stats? % grep -nR USR1 src src/sim/init.cc:97:signal(SIGUSR1, dumpStatsHandler); ___ gem5-dev mailing list gem5-dev@m5sim.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] changeset in m5: scons: rename TraceFlags to DebugFlags

2011-06-02 Thread Nathan Binkert
changeset 9228e00459d4 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=9228e00459d4 description: scons: rename TraceFlags to DebugFlags diffstat: src/SConscript | 2 - src/arch/SConscript | 6 +- src/arch/arm/SConscript

[gem5-dev] changeset in m5: scons: rename some things from m5 to gem5

2011-06-02 Thread Nathan Binkert
changeset 483e936f44f0 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=483e936f44f0 description: scons: rename some things from m5 to gem5 The default generated binary is now gem5. instead of m5.. The latter does still work but gem5. will be generated fir

[gem5-dev] changeset in m5: copyright: Add code for finding all copyright b...

2011-06-02 Thread Nathan Binkert
fornia +Copyright (c) 2006-2009 Nathan Binkert +Copyright (c) 2001 The NetBSD Foundation, Inc. +Copyright (c) 2010-2011 Gabe Black +Copyright (c) 1994 Adam Glass +Copyright (c) 1990-1992 MIPS Computer Systems, Inc. +Copyright (c) 2004 Richard J. Wagner +Copyright (c) 2000 Computer Engineering and Communi

[gem5-dev] changeset in m5: copyright: clean up copyright blocks

2011-06-02 Thread Nathan Binkert
changeset 23711432221f in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=23711432221f description: copyright: clean up copyright blocks diffstat: src/arch/alpha/kgdb.h | 4 ++-- src/arch/alpha/remote_gdb.cc | 4

[gem5-dev] Review Request: scons: rename some things from m5 to gem5

2011-06-02 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/727/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] Review Request: scons: rename TraceFlags to DebugFlags

2011-06-02 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/728/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] Review Request: copyright: Add code for finding all copyright blocks and create a COPYING file

2011-06-02 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/726/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] Review Request: copyright: clean up copyright blocks

2011-06-02 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/725/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

Re: [gem5-dev] Debug Flags

2011-06-01 Thread nathan binkert
ding off from each other >>> (controlling tracing and debug features), and by partially bundling >>> them together and partially distinguishing them that leads to >>> confusion. The mental model is different from the way you have to >>> control things, and trying to recon

[gem5-dev] Debug Flags

2011-06-01 Thread nathan binkert
Ok, there has been a lot of confusion about debug flags and trace flags. I changed the way the flags stuff worked from a compile perspective which required me to make changes throughout the tree, so I took the opportunity to rename the trace flags to debug flags. The idea behind the change was th

Re: [gem5-dev] Review Request: Config: Add support for a Self.all proxy object

2011-05-27 Thread Nathan Binkert
y, visit: > http://reviews.m5sim.org/r/720/ > --- > > (Updated 2011-05-26 19:17:18) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > Config: Add support

Re: [gem5-dev] registerThreadContext

2011-05-27 Thread nathan binkert
> For #1 and #4, these  are pretty much the same right? The contextID is > really all possible sharers rather then just threadContext. Seems like you > should keep the meaning of contextID as it pertains to thread and then > generate a "sharerID" that would be a superset of the contextIDs. Objects

[gem5-dev] registerThreadContext

2011-05-25 Thread nathan binkert
Hi Everyone, I'm trying to work with Lisa's patch to convert cache vector statistics to record data on a per-context basis where context is anything that executes instructions. (Some things were per-CPU and some things were per-thread and neither make sense). She added a parameter to each cache

[gem5-dev] changeset in m5: style: Make the style hook work in directories ...

2011-05-24 Thread Nathan Binkert
changeset 8b0eee09deaf in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=8b0eee09deaf description: style: Make the style hook work in directories other than the root. diffstat: util/style.py | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diffs (43

[gem5-dev] Review Request: slicc: add a protocol statement and an include statement

2011-05-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/717/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] Review Request: slicc: cleanup slicc code and make it less verbose

2011-05-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/716/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] Review Request: grammar: better encapsulation of a grammar and parsing

2011-05-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/715/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] Review Request: style: Make the style hook work in directories other than the root.

2011-05-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/714/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

Re: [gem5-dev] Review Request: syscall emul: fix Power Linux mmap constant, plus other cleanup

2011-05-23 Thread Nathan Binkert
gt; > (Updated 2011-05-23 16:48:45) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > syscall emul: fix Power Linux mmap constant, plus other cleanup > > We were getting a spur

Re: [gem5-dev] Review Request: util/regress: make default action a more thorough regression

2011-05-20 Thread nathan binkert
> > So I played around with this, and the first problem is that your current code > can't handle default values. I fixed that in options.py, but it still > doesn't print the defaults nicely, e.g., instead of: > > --test-variants=TEST_VARIANTS > comma-separated build var

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-18 Thread nathan binkert
> > I agree that makes sense in some instances, but I've found that when you do > that, it makes it hard to extract stats that can compare to runs of different > systems. For example, when I'm comparing stats across different systems, I > want to easily compare how many times a coherency miss fe

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-18 Thread Nathan Binkert
> On 2011-05-17 12:13:18, Nathan Binkert wrote: > > src/mem/ruby/profiler/Profiler.cc, line 456 > > <http://reviews.m5sim.org/r/704/diff/1/?file=12599#file12599line456> > > > > How did you pick this magic number? Can we at least make it a constant > >

[gem5-dev] changeset in m5: gcc: fix an uninitialized variable warning from...

2011-05-18 Thread Nathan Binkert
changeset d1ce92fd3245 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=d1ce92fd3245 description: gcc: fix an uninitialized variable warning from G++ 4.5 diffstat: src/arch/arm/isa/insts/macromem.isa | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diffs (13

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-18 Thread Nathan Binkert
> On 2011-05-17 12:13:18, Nathan Binkert wrote: > > src/mem/ruby/profiler/AddressProfiler.cc, line 235 > > <http://reviews.m5sim.org/r/704/diff/1/?file=12593#file12593line235> > > > > .name should really have name() as part of the name. Is the &g

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-17 Thread nathan binkert
> > These histograms dynamically size. > > Does the default in M5 do the same? and using the same resizing algorithm? > > The histogram itself dynamically resizes, but the vector that's here doesn't need to be dynamic. Nate ___ gem5-dev mailing list ge

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-17 Thread nathan binkert
> > I had trouble getting my individual patches uploaded to review board (it > said they were diffs?), so I merged them into one. You should ignore the > first request that came through, as it is included below. In the future, it's best to use the reviewboard mercurial extension and use the comm

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-17 Thread Nathan Binkert
s.m5sim.org/r/704/#comment1723> Is this used outside of stats? src/mem/slicc/symbols/StateMachine.py <http://reviews.m5sim.org/r/704/#comment1724> is this used outside of stats? - Nathan On 2011-05-16 15:06:16, Derek Hower wrote: > > ---

[gem5-dev] Review Request: gcc: fix an uninitialized variable warning from G++ 4.5

2011-05-17 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/705/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

Re: [m5-dev] Review Request: O3: Removed unnecessary unserialize instruction flags.

2011-05-13 Thread Nathan Binkert
im.org/r/694/ > --- > > (Updated 2011-05-13 14:34:53) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > O3: Removed unnecessary unserialize instruction flags. > &g

[m5-dev] changeset in m5: stats: delete mysql support

2011-05-12 Thread Nathan Binkert
BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * L

[m5-dev] changeset in m5: stats: move code that loops over all stats into...

2011-05-12 Thread Nathan Binkert
changeset be7f03723412 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=be7f03723412 description: stats: move code that loops over all stats into python diffstat: src/base/SConscript | 2 - src/base/statistics.cc | 60 +++-

[m5-dev] changeset in m5: stats: better expose statistics to python.

2011-05-12 Thread Nathan Binkert
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, -# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT -# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, -# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY -# THEORY OF LI

Re: [m5-dev] Review Request: stats: better expose statistics to python.

2011-05-12 Thread Nathan Binkert
ply, visit: http://reviews.m5sim.org/r/689/#review1221 ------- On 2011-05-10 06:08:21, Nathan Binkert wrote: > > --- > This is an automatically gene

Re: [m5-dev] Review Request: stats: better expose statistics to python.

2011-05-12 Thread Nathan Binkert
689/#comment1694> Actually, this is fixed in the subsequent diff. This code is already in the tree and was just part of the rename from stats.py to stats/__init__.py - Nathan On 2011-05-10 06:08:21, Nathan Binkert wrote: > > ---

Re: [m5-dev] Review Request: stats: better expose statistics to python.

2011-05-11 Thread Nathan Binkert
689/#comment1692> yeah, yeah. src/python/m5/stats/__init__.py <http://reviews.m5sim.org/r/689/#comment1693> good point. - Nathan On 2011-05-10 06:08:21, Nathan Binkert wrote: > > --- > This is an automatically gener

Re: [m5-dev] Review Request: stats: move code that loops over all stats into python

2011-05-11 Thread Nathan Binkert
pstats from an m5op or from kill -USR1, you don't want to dump twice in the same cycle because stuff just doesn't work well. - Nathan On 2011-05-10 06:08:36, Nathan Binkert wrote: > > --- > This is an automatically g

[m5-dev] Review Request: stats: delete mysql support

2011-05-10 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/691/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[m5-dev] Review Request: stats: move code that loops over all stats into python

2011-05-10 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/690/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[m5-dev] Review Request: stats: better expose statistics to python.

2011-05-10 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/689/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[m5-dev] changeset in m5: work around gcc 4.5 warning

2011-05-09 Thread Nathan Binkert
changeset 44f8c2507d85 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=44f8c2507d85 description: work around gcc 4.5 warning diffstat: src/cpu/inorder/resource_pool.cc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diffs (21 lines): diff -r db269e704d07

[m5-dev] gem5 Tutorial @ ISCA 2011

2011-05-09 Thread nathan binkert
Call for Participation: ISCA 2011 Tutorial gem5: A Multiple-ISA Full System Simulator with Detailed Memory Modeling Sunday, June 5, 2011 http://www.gem5.org The gem5 simulator is a merger of two of the computer architecture community’s most popular, open source simulators: M5 and GEMS. The best fe

Re: [m5-dev] [m5-users] Tracing does not work

2011-05-07 Thread nathan binkert
> I was thinking og doing it since Nate is not around. I'll do it soon. >> instance, "trace-flags", and "trace-file" are still accepted, but they >> don't >> do anything now.  They should be eliminated from the message.  We're also >> missing the equivalent of "trace-start" and "trace-file".  Do

Re: [m5-dev] Review Request: Cache: fix vector stats in classic cache to have matching lengths

2011-05-05 Thread nathan binkert
>> I don't know.  Is it?  I haven't opened a file in dev/ in years.  Does this >> involve changing all device models?  Changing something in a port interface? >>  Which?  I don't know.  I have not looked into it at all.  I tried to page >> out as little of what I was doing to fix this vector len

Re: [m5-dev] Review Request: Trace: Allow printing ASIDs and selectively tracing based on user/kernel code.

2011-05-04 Thread Nathan Binkert
d 2011-05-04 18:42:30) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > Trace: Allow printing ASIDs and selectively tracing based on user/kernel code. > > Debug flags are ExecUser, ExecK

Re: [m5-dev] changeset in m5: debug: fix help output

2011-05-04 Thread nathan binkert
> So --trace-start, --trace-ignore, and --trace-file didn't get renamed? Yeah, the idea was that there was more to the flags than tracing, but the start, ignore, and file things were specific to tracing. Nate ___ m5-dev mailing list m5-dev@m5sim.org h

Re: [m5-dev] Review Request: ruby-stats: support for dump_stats instruction

2011-05-04 Thread Nathan Binkert
changes > > would be required to change the name of base/time.hh's version of Time. > > Nathan Binkert wrote: > While I wouldn't be opposed to changing the time in base/time.hh if we > needed both, but don't we need to move ruby away from its own

Re: [m5-dev] changeset in m5: debug: fix help output

2011-05-04 Thread nathan binkert
s the flags for tracing (-FLAG disables a flag) > --trace-start=TIME      Start tracing at TIME (must be in ticks) > --trace-file=FILE       Sets the output file for tracing [Default: cout] > --trace-ignore=EXPR     Ignore EXPR sim objects > > > On Wed, May 4, 2011 at 7:07 AM,

[m5-dev] changeset in m5: debug: fix help output

2011-05-04 Thread Nathan Binkert
d disable(); }; diff -r 3f49ed206f46 -r 5a9a639ce16f src/python/m5/debug.py --- a/src/python/m5/debug.pyMon May 02 12:40:32 2011 -0700 +++ b/src/python/m5/debug.pyWed May 04 10:08:08 2011 -0400 @@ -26,24 +26,36 @@ # # Authors: Nathan Binkert +from UserDict import DictMixin + impor

Re: [m5-dev] Review Request: ruby-stats: support for dump_stats instruction

2011-05-03 Thread Nathan Binkert
- > > (Updated 2011-05-03 11:20:58) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > ruby-stats: support for dump_stats instruction > *** > NOTE: The c

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 247 > > <http://reviews.m5sim.org/r/668/diff/1/?file=12211#file12211line247> > > > > Should we prompt the user for permission? That way the user would at > > least know that somethi

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 243 > > <http://reviews.m5sim.org/r/668/diff/1/?file=12211#file12211line243> > > > > I know you didn't change this, but should we check for both hooks? (I > > added the pre-qr

Re: [m5-dev] Review Request: Debug: Add a function to cause the simulator to create a checkpoint from GDB.

2011-05-02 Thread Nathan Binkert
ws.m5sim.org/r/672/ > --- > > (Updated 2011-05-02 15:42:09) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > Debug: Add a functi

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
- > > (Updated 2011-05-02 12:34:56) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > SConstruct: automatically update .hg/hgrc with style hooks > > Seems easier than pestering

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 247 > > <http://reviews.m5sim.org/r/668/diff/1/?file=12211#file12211line247> > > > > Should we prompt the user for permission? That way the user would at > > least know that somethi

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
gt; > (Updated 2011-05-02 12:34:56) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > SConstruct: automatically update .hg/hgrc with style hooks > > Seems easier than pestering peopl

Re: [m5-dev] Review Request: debug: fix help output

2011-04-28 Thread Nathan Binkert
I want a reference in the constructor for sure because I don't want people to pass NULL or anything like that. Since I want a reference in the constructor, it's easier to have a reference here. - Nathan On 2011-04-28 16:48:33, Nath

[m5-dev] Review Request: debug: fix help output

2011-04-28 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/666/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[m5-dev] changeset in m5: event: fix PythonEvent

2011-04-28 Thread Nathan Binkert
changeset f2ec56fd42c0 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=f2ec56fd42c0 description: event: fix PythonEvent order of %includes since they matter for this case diffstat: src/python/swig/event.i | 4 +++- 1 files changed, 3 insertions(+), 1 deletions

[m5-dev] Code Reviewing

2011-04-27 Thread nathan binkert
Hi Everyone, We don't have an official policy on code reviews, but I think we're being a bit pedantic with them. While I definitely want us to err on the side of having code review is the author has any doubt, I think it is completely unnecessary to have reviews on things like changing comments a

Re: [m5-dev] Trace not working

2011-04-25 Thread nathan binkert
X86_SE_MOESI_hammer/python/m5/internal/vptype_AddrRange.i -> > _wrap.cc, .py > scons: *** [build/X86_SE_MOESI_hammer/mem/port.do] Error 1 >  [    SWIG] X86_SE_MOESI_hammer/python/m5/internal/vptype_Process.i -> > _wrap.cc, .py > scons: building terminated because of errors. &

Re: [m5-dev] Trace not working

2011-04-25 Thread nathan binkert
> However, I am confused as well on how to add a new TraceFlag/DebugFlag.  It > seems that all the previous flags are still specified using the "TraceFlag()" > function, but I can't seem to be able to specify a new one.    Also to be > consistent, should we change the name of the TraceFlag funct

[m5-dev] changeset in m5: stats: update 20.parser o3 now that it works. ...

2011-04-25 Thread Nathan Binkert
changeset b02bca5aed04 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=b02bca5aed04 description: stats: update 20.parser o3 now that it works. realview-o3 works too. diffstat: tests/long/10.linux-boot/ref/arm/linux/realview-o3/status |2 +- tests/long/20.parser/re

Re: [m5-dev] Review Request: Util: Replace mkblankimage.sh with the new gem5img.py.

2011-04-23 Thread nathan binkert
> All that said, if you want to take the script and move things into > m5.util, or rework it so it uses m5.util, or make it handle paths > better, or whatever, I certainly won't try to stop you. I think my > version is an improvement over the original, but it's definitely not > perfect. I didn't m

Re: [m5-dev] Review Request: Util: Replace mkblankimage.sh with the new gem5img.py.

2011-04-23 Thread nathan binkert
> > I looked at it and it is similar, but it's different enough that they can't > be interchanged. My functions all allow passing a string in as standard input > and return the error code, but readCommand doesn't. I could extend it to take > an input string, but it's not clear how to return the

Re: [m5-dev] Review Request: network: convert links & switches to first class C++ SimObjects

2011-04-23 Thread Nathan Binkert
gt; This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/653/ > --- > > (Updated 2011-04-22 15:16:58) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and

Re: [m5-dev] Review Request: ruby: moved topology to the top network directory

2011-04-23 Thread Nathan Binkert
s.m5sim.org/r/651/ > --- > > (Updated 2011-04-22 15:16:44) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > ruby: moved topology to the top network directory > >

Re: [m5-dev] Review Request: ruby: moved topology to the top network directory

2011-04-23 Thread Nathan Binkert
s.m5sim.org/r/651/ > --- > > (Updated 2011-04-22 15:16:44) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > ruby: moved topology to the top network directory > >

[m5-dev] changeset in m5: tests: updates for stat name change

2011-04-22 Thread Nathan Binkert
changeset 6e368a935ac0 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=6e368a935ac0 description: tests: updates for stat name change diffstat: tests/long/00.gzip/ref/alpha/tru64/o3-timing/simout | 4 +- tests/long/00.gzip/ref/alpha/tru64/o3-

[m5-dev] changeset in m5: stats: ensure that stat names are valid

2011-04-22 Thread Nathan Binkert
changeset d69720504203 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=d69720504203 description: stats: ensure that stat names are valid diffstat: src/base/statistics.cc | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diffs

[m5-dev] changeset in m5: stats: one more name violation

2011-04-22 Thread Nathan Binkert
changeset acf4b902c02e in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=acf4b902c02e description: stats: one more name violation diffstat: src/cpu/o3/lsq_unit_impl.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diffs (12 lines): diff -r 914389024c33 -r a

Re: [m5-dev] Review Request: Cache: fix vector stats in classic cache to have matching lengths

2011-04-22 Thread Nathan Binkert
> On 2011-04-22 18:51:32, Nathan Binkert wrote: > > src/mem/cache/base.hh, line 503 > > <http://reviews.m5sim.org/r/654/diff/1/?file=11759#file11759line503> > > > > This can pretty easily be done with a template: > > > > template >

Re: [m5-dev] Review Request: Cache: fix vector stats in classic cache to have matching lengths

2011-04-22 Thread Nathan Binkert
rg/r/654/ > --- > > (Updated 2011-04-22 17:16:05) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > Cache: fix vector stats in

Re: [m5-dev] what scons can do

2011-04-22 Thread nathan binkert
> Is that 1%/99% a statement of a clean build for m5.fast?  I think the much > more common case is you edit one .cc file and rebuild.  In that situation, it > sure seems like a lot more than 1% of the time is spent by scons regenerating > and reanalyzing SLICC files. > > Whatever it may be, it s

Re: [m5-dev] Review Request: O3: Tighten memory order violation checking to 16 bytes.

2011-04-22 Thread nathan binkert
looks like the assert shouldn't be there and is hit during some miss > speculation. > > > - Ali > > On March 30th, 2011, 8:41 a.m., Ali Saidi wrote: > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > By Ali Saidi.

Re: [m5-dev] what scons can do

2011-04-21 Thread nathan binkert
> Maybe so... I think there's a subconscious impression that it takes a while > because there's a phase in the build that takes a noticeable amount of time > and that's all the output you see.  If in fact that delay is 10% running > SLICC and 90% scons doing other stuff silently then I agree it's n

Re: [m5-dev] what scons can do

2011-04-21 Thread nathan binkert
> Making it not work that way would likely be very painful. The parser part is > finicky (like they all are in any language) and we have lots and lots of > very intricate code built on top of it in the form of the descriptions > themselves. Perhaps we should talk about it on the phone. Making it s

Re: [m5-dev] what scons can do

2011-04-21 Thread nathan binkert
> Are you sure?  Running SLICC every time just to get a (typically unchanging) > list of files is not exactly instantaneous, and the names of the SLICC > output files hardly ever change.  What about this approach: It is pretty fast (and this includes starting the python interpreter) 0.48s user 0.03

Re: [m5-dev] what scons can do

2011-04-21 Thread nathan binkert
> That doesn't really fit with how the ISA files work. They get broken into an > AST, but that gets consumed as it goes, Does it have to be? > and it has a lot of anonymous python > in it that just gets executed somehow. I want to move more into the python, > so the AST will be less and less usefu

Re: [m5-dev] what scons can do

2011-04-21 Thread nathan binkert
> A mechanism where I can say binary foo needs file bar, and then when I tell > it to build foo it build's it with bar, and bar doesn't get mixed in to > other things. I think you're new widget that was like mercurial patch guards > would help with that, right? You could have a guard for each extra

[m5-dev] changeset in m5: python: fix another bug from changes to main.py

2011-04-21 Thread Nathan Binkert
changeset 914389024c33 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=914389024c33 description: python: fix another bug from changes to main.py diffstat: configs/common/cpu2000.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diffs (12 lines): diff -r a9

Re: [m5-dev] what scons can do

2011-04-21 Thread nathan binkert
> Anyway, it seems like it would be useful to be able to have multiple > binaries that can be built by scons, specifically the utility stuff and > unit tests. That way we could avoid having a hodge podge of small build > systems which are either isolated or not in not quite the right ways. I > know

Re: [m5-dev] Review Request: Util: Replace mkblankimage.sh with the new gem5img.py.

2011-04-21 Thread Nathan Binkert
> On 2011-04-18 21:20:49, Nathan Binkert wrote: > > util/gem5img.py, line 51 > > <http://reviews.m5sim.org/r/644/diff/1/?file=11664#file11664line51> > > > > I'm not going to make you change it or anything, but this whole class &g

Re: [m5-dev] Error while compiling (changeset 8229)

2011-04-21 Thread nathan binkert
I say commit it then. Nate > The bug exists in 8246. Following works for me - > > > diff -r a9d06c894afe src/base/stats/mysql.hh > --- a/src/base/stats/mysql.hh   Wed Apr 20 18:45:03 2011 -0700 > +++ b/src/base/stats/mysql.hh   Thu Apr 21 15:28:29 2011 -0500 > @@ -37,6 +37,7 @@ >  #include > >

Re: [m5-dev] Review Request: util/regress: make default action a more thorough regression

2011-04-21 Thread Nathan Binkert
erated e-mail. To reply, visit: > http://reviews.m5sim.org/r/649/ > --- > > (Updated 2011-04-20 22:42:16) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > >

Re: [m5-dev] Introducing...InOrder AlphaFS!

2011-04-21 Thread nathan binkert
Great work! On Thu, Apr 21, 2011 at 12:12 AM, Korey Sewell wrote: > For 1-4 wide, InOrder Cores running in ALPHA FS mode... Observe terminal > output: > "M5 console: m5AlphaAccess @ 0xFD02 > Got Configuration 623 > memsize 800 pages 4000 > First free page after ROM 0xFC018

Re: [m5-dev] Error while compiling (changeset 8229)

2011-04-20 Thread nathan binkert
> Because that file is being included regardless.  I'm actively trying > to squash all of these bugs and I'll be committing some changes soon. > This one is trivial to fix. I can't reproduce this bug on my machine, even with USE_MYSQL=False. Can you try the attached diff? If it works for you, fee

[m5-dev] changeset in m5: fix some build problems from prior changesets

2011-04-20 Thread Nathan Binkert
changeset a9d06c894afe in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=a9d06c894afe description: fix some build problems from prior changesets diffstat: src/arch/arm/interrupts.hh| 1 + src/arch/arm/linux/system.cc | 1 + src/arch/arm/table_walker.cc | 3 +++

Re: [m5-dev] Error while compiling (changeset 8229)

2011-04-20 Thread nathan binkert
> Nate, since I have provided the option USE_MYSQL=False, why should mysql.hh > even come in to picture? Because that file is being included regardless. I'm actively trying to squash all of these bugs and I'll be committing some changes soon. This one is trivial to fix. Nate __

Re: [m5-dev] Error while compiling (changeset 8229)

2011-04-20 Thread nathan binkert
The solution is to #include "base/types.hh" in mysql.hh, but to be honest, I'm not sure how this is even happening. Perhaps you need to blow away your build directory and compile again. That said, I did not compile with USE_MYSQL=False, so this could just be a bug that shows up in that instance.

Re: [m5-dev] another compilation error in the tree (!!)

2011-04-20 Thread nathan binkert
I'm certain that I compiled the whole tree with debug, opt, and fast, in addition to running regressions. I pretty much do that every time. What I must not have done was compile all of the different coherence protocols though (I didn't realize that more were run in regressions since I last update

Re: [m5-dev] Error while compiling (changeset 8229)

2011-04-20 Thread nathan binkert
You need changeset 8230. You need the sort includes changeset and the one following it that fixes bugs. Nate > I am trying to compile m5 and the scons exits with errors. > Following is the compilation command -- > > scons -j 12 CXX=g++44 CC=gcc44 USE_MYSQL=False RUBY=True > build/ALPHA_SE_MESI

Re: [m5-dev] Stats Bug

2011-04-20 Thread nathan binkert
> There's more to it than that.  I started it yesterday and I'll post a diff > today and you can see what I mean. > So one question to you Nate, is what do you prefer, doing a single #if > FULL_SYSTEM in the C++, or doing a if buildEnv[FULL_SYSTEM] in the python so > that the value passed into the

Re: [m5-dev] Stats Bug

2011-04-19 Thread nathan binkert
> Yes, Steve's got it right.  In the C++ you replace the instances of the 3 > lengths Nate mentions with a single var (that can be more aptly named as > Steve wants) that is pythonically calculated and passed in from the > configuration.  I'm making up words here :). > > I think I can do this tonig

  1   2   3   4   5   6   7   8   9   10   >