Re: [m5-dev] Split Translation

2009-04-28 Thread nathan binkert
> I don't see much benefit in doing the split twice (once for page crossings > and a second time for cache line crossings), though if there was a way to > isolate the bulk of the code in a single function that gets called twice it > wouldn't be too bad.  There is some merit in only calling the TLB

Re: [m5-dev] Split Translation

2009-04-28 Thread Steve Reinhardt
On Tue, Apr 28, 2009 at 1:19 PM, nathan binkert wrote: > >> 2) You split the translation if the address crosses blocks. It seems > >> that it'd be better to check to see if the access crosses pages, not > >> blocks to save the extra work. > > > > I was told I should use the peer block size becau

Re: [m5-dev] Split Translation

2009-04-28 Thread nathan binkert
>> [ I wrote this e-mail almost a month and a half ago and I just noticed >> that it never got sent.  I think it is still relevant] >> >> I've started looking at your patch and in particular some of the >> translation code in the TimingSimpleCPU.  I have a couple of comments. >> >> 1) You call dcac

Re: [m5-dev] Split Translation

2009-04-28 Thread Gabriel Michael Black
Quoting nathan binkert : > Hi Gabe, > > [ I wrote this e-mail almost a month and a half ago and I just noticed > that it never got sent. I think it is still relevant] > > I've started looking at your patch and in particular some of the > translation code in the TimingSimpleCPU. I have a couple o

[m5-dev] Split Translation

2009-04-28 Thread nathan binkert
Hi Gabe, [ I wrote this e-mail almost a month and a half ago and I just noticed that it never got sent. I think it is still relevant] I've started looking at your patch and in particular some of the translation code in the TimingSimpleCPU. I have a couple of comments. 1) You call dcachePort.pe