Re: [m5-dev] changeset in m5: CPU: Prepare CPU models for the new in-order CP...

2009-02-10 Thread nathan binkert
> Just one little nit to pick: this function definition here should be in > static_inst.cc and not static_inst.hh. It certainly doesn't need to be > inlined for performance reasons, and since it's virtual it won't get inlined > anyway, so there's no point in cluttering the header file with it. Th

Re: [m5-dev] changeset in m5: CPU: Prepare CPU models for the new in-order CP...

2009-02-10 Thread Steve Reinhardt
Thanks Korey! Nice to see all this get in. Just one little nit to pick: this function definition here should be in static_inst.cc and not static_inst.hh. It certainly doesn't need to be inlined for performance reasons, and since it's virtual it won't get inlined anyway, so there's no point in cl

[m5-dev] changeset in m5: CPU: Prepare CPU models for the new in-order CP...

2009-02-10 Thread Korey Sewell
changeset 54ed46881217 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=54ed46881217 description: CPU: Prepare CPU models for the new in-order CPU model. Some new functions and forward declarations are necessary to make things work diffstat: 3 files changed, 17