Re: [QUESTION] do pom files need to have a license header

2023-02-06 Thread PJ Fanning
Thanks everyone for the responses. I have raised an issue to investigate the possibilities about getting a header comment in the pom files we generate. I suspect we will need a change to the sbt build tool or one of its plugins. On 2023/01/30 14:01:28 Jean-Baptiste Onofré wrote: > Hi, > > It's

Re: [QUESTION] do pom files need to have a license header

2023-01-30 Thread Jean-Baptiste Onofré
Hi, It's a better to have ASF header in all files where it's possible. However, it's sometime difficult (test static files, web content, ..). So if you can, it's better Pekko community fixes it. Thanks, Regards JB On Sun, Jan 29, 2023 at 6:31 PM PJ Fanning wrote: > > Hi everyone, > > The

Re: [QUESTION] do pom files need to have a license header

2023-01-29 Thread Justin Mclean
Hi, In general, it is best to have ASF headers on all possible files. That way if they become separated from the source bundle, people will know what license it’s under and where it comes from. (Also see [3]) People reviewing releases are less likely to ask if these are 3rd party files. The

Re: [QUESTION] do pom files need to have a license header

2023-01-29 Thread Greg Stein
The source archive/tarball includes a LICENSE and NOTICE which specifies the license for that artifact. The individual files' header simply reinforces that. In some release artifacts, individual files have a slightly different license (eg. a third-party MIT-licensed piece of source), which

[QUESTION] do pom files need to have a license header

2023-01-29 Thread PJ Fanning
Hi everyone, The Apache Pekko builds use the sbt tool for building and this generates pom files for us. They do not include any headers (example [1]). It seems the norm to add an XML comment with Apache License info (example from log4j [2]). Does the Pekko team need to fix this or is it just a