Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

2018-05-23 Thread Jun Liu
Hi All, I am canceling this vote and prepare for a new release candidate RC2. Thanks for Willem, Ian and Justin for pointing out the issues in this candidate, we expect to address the following issues RC2: - Resolve scheme compatibility problems[1]. - Remove the MD5 hashes in RC1 - Rename the

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

2018-05-21 Thread sebb
On 21 May 2018 at 21:16, Justin Mclean wrote: > Hi, > >> I don't think there should be anything in the source release that is >> not in the source repo. > > It reasonably common (from my review of 100’s of releases) that the build > process may modify and/or add some

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

2018-05-21 Thread Justin Mclean
Hi, > I don't think there should be anything in the source release that is > not in the source repo. It reasonably common (from my review of 100’s of releases) that the build process may modify and/or add some files (e.g config files). I wouldn’t expect any code to change or be added.

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

2018-05-21 Thread sebb
On 21 May 2018 at 08:59, Justin Mclean wrote: > Hi, > >> As I cannot build the binary without doing some changes on the pom file, I >> had to vote -1 (binding) here. > > You don’t need to modify the pom file to compile you can specify > -Dcheckstyle.skip to compile id

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

2018-05-21 Thread Ian Luo
We decide to withdraw this release vote, and redo this release. Not only because we want a better release which honors feedbacks especially from William and Justin, but also because we need to address one compatibility issue found recently [1]. Thank you all for your feedback, hopefully we can

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

2018-05-21 Thread Justin Mclean
Hi, > As I cannot build the binary without doing some changes on the pom file, I > had to vote -1 (binding) here. You don’t need to modify the pom file to compile you can specify -Dcheckstyle.skip to compile id check style is acting up for you. Up to you if you want to vote -1 but I just want

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

2018-05-21 Thread Jun Liu
> 1. there is bunch of dubbo-2.6.2-SNAPSHOT in the pom.xml file, I guess the > maven release plugin doesn't take all of them. > .//bom/pom.xml: dubbo-2.6.2-SNAPSHOT > .//dependencies-bom/pom.xml: dubbo-2.6.2-SNAPSHOT > .//distribution/pom.xml:2.6.2-SNAPSHOT-SNAPSHOT >

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

2018-05-20 Thread Willem Jiang
Hi, I did some check on the source zip and binary zip, the License and Notice files looks good. But I also found some issues here. As I cannot build the binary without doing some changes on the pom file, I had to vote -1 (binding) here. Here are the issues that I found: 1. there is bunch of

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

2018-05-18 Thread Justin Mclean
Hi, +1 (binding) Carrying my vote over form the dev list and all the usual checks done. There’s a few very minor / trivial documentation issues that need fixed but hashes, signatures, license, notice etc etc is all good. Thanks, Justin

[VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

2018-05-18 Thread Jun Liu
Hello All, This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2. The Apache Dubbo community has voted on and approved a proposal to release Apache Dubbo (Incubating) version 2.6.2. We now kindly request the Incubator PMC members review and vote on this incubator release.