[VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

Hello All, This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3. The Apache Dubbo community has voted on and approved a proposal to release Apache Dubbo (Incubating) version 2.6.3. We now kindly request the Incubator PMC members review and vote on this incubator release.

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

Here're some tips of how to verify the RC: 1. Check signatures and hashes are good sha512 dubbo-incubating-${release_version}-bin-release.zip.sha512 sha512 dubbo-incubating-${release_version}-source-release.zip.sha512 gpg2 --keyserver pgpkeys.mit.edu --recv-key 208B0AB1D630

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

I checked 2.6.3 RC3, it looks good. I've checked: 1. signatures and hashes are good 2. directory is correct in sources 3. DISCLAIMER exists in sources 4. LICENSE and NOTICE exists in sources 5. files and license header looks good in sources 6. compilation passes 7. unit test can pass on my laptop

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

> sha512 dubbo-incubating-${release_version}-bin-release.zip.sha512 > sha512 dubbo-incubating-${release_version}-source-release.zip.sha512 Sorry, the right command: shasum -c dubbo-incubating-${release_version}-source-release.zip.sha512 shasum -c dubbo-incubating-${release_version}-bin-release.zip

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

On 15 August 2018 at 03:56, Jun Liu wrote: > Here're some tips of how to verify the RC: > > 1. Check signatures and hashes are good > sha512 dubbo-incubating-${release_version}-bin-release.zip.sha512 > sha512 dubbo-incubating-${release_version}-source-release.zip.sha512 > g

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

Hi, +1 binding I checked: - incubating in name - signatures and hashed all good - DISCLAIMER exists - LICENSE and NOTICE have minor issues (see below) - No unexpected binary files - All source files (other than a few pom files) have ASF headers - Can compile from source In LICENSE there’s no nee

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

> Better to get the key from the KEYS file. I think that would be: 1. download and import the KEYS from https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS 2. gpg2 --verify dubbo-incubating-2.6.2-source-release.zip.asc dubbo

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

> In LICENSE there’s no need to list hessian-lite license as it’s not been > bundled. We have noticed this issue during vote in Dubbo Community and it will be removed in the next release. > A couple of other very minor issues exist: > - Netty has a (poor) NOTICE file [1] given a couple of files

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

On 16 August 2018 at 12:56, Jun Liu wrote: >> Better to get the key from the KEYS file. > > I think that would be: > 1. download and import the KEYS from > https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS > > 2. gpg2 --veri

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

> ING=/tmp/keyring.$$ > gpg2 --keyring $RING --no-default-keyring --import KEYS > gpg2 --keyring $RING --no-default-keyring --verify … Thanks Sebb, I will try it later. Would you mind to help verify the Release Candidate? Best regards, Jun > On 16 Aug 2018, at 20:39, sebb wrote: > > On 16 Au

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

We still lack 2 binding votes,l kindly ask for the PMCs to help to verify and vote. Best regards, Jun > On 15 Aug 2018, at 10:56, Jun Liu wrote: > > Here're some tips of how to verify the RC: > > 1. Check signatures and hashes are good > sha512 dubbo-incubating-${release_version}-bin-re

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

On 12/08/18 08:12, Jun Liu wrote: > Please vote accordingly: > [ ] +1 approve > [ ] +0 no opinion > [X] -1 disapprove with the reason (binding) The sha512 hashes are missing the '*' marker that indicates they are hashes for binary files rather than text files. Trivial issue. Can be addressed

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

I checked the source.zip file data, it is same with the data with the tag, but the pom version was not same with the git repo as Mark already point out. I guess you did use the maven release plugin to do the latest release, as we cannot see the release plugin commit log there. After going through

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

> The 2.6.3 tag does not agree with the source release. This is a > significant issue and enough for me to vote against the release. A diff > shows most (all?) of the pom.xml have a version of "2.6.4-SNAPSHOT" in > the tag but "2.6.3" in the source release. > > I dug into this a little. At first I

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

> I guess you did use the maven release plugin to do the latest release, as > we cannot see the release plugin commit log there. Yes, we used maven release plugin to do the latest release, and it has automatically changed the version to ‘2.6.4-SNAPSHOT’. I forgot to change it back when tag in t

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

hi, I suggest the next iteration of development should be on another branch such as "2.6.4" or "2.6.x". We indeed should keep the pre-release branch clean (I just do some local work changing versions for our own nexus repo before). best regards, Jason > On Aug 20, 2018, at 11:02, Jun Liu wr

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

Hi Liu Jun, You may need to close this vote if we want to start a new round of release. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Mon, Aug 20, 2018 at 11:27 AM, Jun Liu wrote: > > I guess you did use the maven release plugin to do the latest release, as > > we cannot see the relea

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.3 [RC3]

> You may need to close this vote if we want to start a new round of release. Thanks for reminding. I am closing this vote now. We’ve solved the issues reported in this round, I will start a new vote thread later. Best regards, Jun > On 22 Aug 2018, at 17:02, Willem Jiang wrote: > > Hi Liu J