Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

Hello Sergio, This is how the NOTICE file looks at the moment - https://github.com/apache/incubator-mxnet/blob/v1.0.0/NOTICE I had worked on the NOTICE file prior to the 0.11.0 Release and had followed the link you mentioned. I had added a few notices into this file, including Caffe, MS coco etc

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

Hi Sergio, Thanks for guidance. The binary file has been removed now. See: https://github.com/dmlc/tvm/tree/master/apps/android_rpc/gradle/wrapper We are testing the changes currently and expect to submit a new RC by end of today. Regards, Bhavin Thaker. On Thu, Nov 30, 2017 at 9:40 AM Sergio

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

Generally speaking, I follow these key aspects: * Don't put anything in NOTICE for the sake of an MIT or a 3-clause BSD licensed dependency. * For an ALv2 dependency, follow the instructions in the licensing howto: http://www.apache.org/dev/licensing-howto.html * For all other licenses, either

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

On Wed, Nov 29, 2017 at 7:52 PM Hen wrote: > On Wed, Nov 29, 2017 at 3:18 PM, Justin Mclean > wrote: > > > Hi, > > > > >> - A number of source file are missing license headers e.g. [15][16] > [18] > > >> [19] and many others > > >> > > > > > > Many of

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

On Wed, Nov 29, 2017 at 3:18 PM, Justin Mclean wrote: > Hi, > > >> - A number of source file are missing license headers e.g. [15][16] [18] > >> [19] and many others > >> > > > > Many of these are not Apache MXNet files but from dependencies. I'll > > suggest on dev@ that

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

Hello Justin, Henri, Thank you for your input. Justin, Chris ran Apache Rat on MXNet this morning. Several issues found here, in addition to your comments that needed a fix have been addressed in the following 2 PRS - 1. https://github.com/apache/incubator-mxnet/pull/8873/ 2.

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

Hi, >> - A number of source file are missing license headers e.g. [15][16] [18] >> [19] and many others >> > > Many of these are not Apache MXNet files but from dependencies. I'll > suggest on dev@ that these submodules be moved into a third-party/ > directory. Having that clearly identified

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

Thanks Justin. Some comments inline on ones I don't think need fixing; but afaict from MXNet dev@ activity the plan is to produce a new release and restart the vote. On Tue, Nov 28, 2017 at 3:54 PM, Justin Mclean wrote: > Hi, > > -1 binding due to license, header

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

Hi, -1 binding due to license, header issues and having a compiled jar in a source release. I checked: - incubating in name - signatures and hashes correct - DISCLAIMER exists - LICENSE has issues (see below) I also note that license issues brought up last time have not all been addressed.

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

Thank you Dave, Sergio and Henri for your comments. I will make sure to follow the points specified by you in future emails. Sergio, In reference to the two points you mentioned for your negative vote, I would like to add this - 1. Tianqi Chen has confirmed (via slack) that for this binary '

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

Thank you for the review Sergio :) On Mon, Nov 27, 2017 at 7:37 PM, Sergio Fernández wrote: > Hi, > > * Incubator DISCLAIMER included. > * LICENSE file contains information that should go in the NOTICE. > Interested in which you think should be in there. The license file is

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

I correct myself, this is not the first incubating release. My bad, I couldn't find traces of previous incubating releases to download from the podling site. I'll go back to check if previous VOTEs had similar issues. So all my comments on 1.0.0-RC0 still remain valid though. On Mon, Nov 27, 2017

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

Hi, * Incubator DISCLAIMER included. * LICENSE file contains information that should go in the NOTICE. * Build worked fine on my desktop (Ubuntu 17.10, GCC 7.2.0). * I'd put the install instruction somewhere more prominent than docs/install/index.md, and probably more CLI-friendly text document.

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

Hi - > On Nov 27, 2017, at 4:26 PM, Chris Olivier wrote: > > Hello All, > > > This is a call for releasing Apache MXNet (incubating) 1.0.0, release > candidate 0. > > > Apache MXNet community has voted and approved the release. > > > *Vote thread:* > >

[VOTE] Apache MXNet (incubating) 1.0.0 release RC0

Hello All, This is a call for releasing Apache MXNet (incubating) 1.0.0, release candidate 0. Apache MXNet community has voted and approved the release. *Vote thread:* https://lists.apache.org/thread.html/568bf0c9960f14640b753a5fb6766c 7b0074339d286f405c04ffec96@%3Cdev.mxnet.apache.org%3E