Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC3

2018-05-19 Thread Anirudh
Hi, Thank you all for voting and providing your inputs. The vote has passed with three +1 binding votes and no -1 or 0 votes. +1 (binding): Sergio Henri Sebastian I will follow up on Monday, on the next steps for the release. Anirudh On Sat, May 19, 2018 at 2:08 PM, Sebastian

Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC3

2018-05-19 Thread Sebastian
+1 - checked signatures - checked building from source under ubuntu 16 On 19.05.2018 19:25, Hen wrote: I am only reviewing the "diff -r" between RC2 and RC3. Confirmed that the DevGuide.md is removed. There is a fix ( https://github.com/apache/incubator-mxnet/issues/10837 ) to Dockerfiles,

Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC3

2018-05-19 Thread Hen
I am only reviewing the "diff -r" between RC2 and RC3. Confirmed that the DevGuide.md is removed. There is a fix ( https://github.com/apache/incubator-mxnet/issues/10837 ) to Dockerfiles, and a pom.xml fix adding a parent tag to the scala-package. These seem fine and rectifies the blocking item

Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC3

2018-05-19 Thread Justin Mclean
Hi, > I had a look at the files and found that the key required to verify the > signature is not contained in the KEYS file in the tar ball. AFAIK having the KEY file in the tar ball is not really helpful at all as it could be modified and republished. The KEY file needs to be stored

Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC3

2018-05-19 Thread Sebastian
Hi, I had a look at the files and found that the key required to verify the signature is not contained in the KEYS file in the tar ball. It has to be downloaded from an external keyserver. Not sure about the consequences of that, is it a minor thing or should a new RC be cut? Best,

Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC3

2018-05-18 Thread Sergio Fernández
+1 (binding) So far I've checked: * signatures and digests * source releases file layouts * matched git tags and commit ids * incubator suffix and disclaimer * LICENSE & NOTICE files look good despite the many third-party code (CC-BY files from RC2 are gone) * no binary files in the source

[VOTE] Apache MXNet (incubating) 1.2.0 release RC3

2018-05-15 Thread Anirudh Subramanian
Hi all, This is a call for releasing Apache MXNet (incubating) 1.2.0, release candidate RC3. As suggested by Justin and Henri, we have removed the two category b license files: DevGuide.md from the release source tarball. Apache MXNet (incubating) community has voted and approved the release.