[RESULT][VOTE] Release Apache Milagro (incubating) Crypto Libraries v1.0.0

2019-08-27 Thread John McCane-Whitney
Hi, Re tags: https://github.com/apache/incubator-milagro-crypto-c/releases/tag/1.0.0 https://github.com/apache/incubator-milagro-crypto-js/releases/tag/1.0.0 The vote to release the above is now closed and has passed with 3 x +1 binding votes: Julian Feinauer Justin Mclean Furkan Kamaci And

Re: [VOTE] Release Apache Milagro (incubating) Crypto Libraries v1.0.0

2019-08-24 Thread ซ่อยค่อย ลืมเขาแน่
แสดข้อความที่ยกมา เมื่อ 25 ส.ค. 2019 08:56 "ซ่อยค่อย ลืมเขาแน่" <0989132858...@gmail.com> เขียนว่า > > เมื่อ 25 ส.ค. 2019 05:06 "Justin Mclean" > เขียนว่า > >> Hi, >> >> > All of the code was either written from scratch >> >> Thanks for that. I just thought it would be a little odd to do given

Re: [VOTE] Release Apache Milagro (incubating) Crypto Libraries v1.0.0

2019-08-24 Thread ซ่อยค่อย ลืมเขาแน่
เมื่อ 25 ส.ค. 2019 05:06 "Justin Mclean" เขียนว่า > Hi, > > > All of the code was either written from scratch > > Thanks for that. I just thought it would be a little odd to do given the > standard nature of some of the algorithms in there (calculating hashes and > the like). > > Thanks, >

Re: [VOTE] Release Apache Milagro (incubating) Crypto Libraries v1.0.0

2019-08-24 Thread Justin Mclean
Hi, > All of the code was either written from scratch Thanks for that. I just thought it would be a little odd to do given the standard nature of some of the algorithms in there (calculating hashes and the like). Thanks, Justin

Re: [VOTE] Release Apache Milagro (incubating) Crypto Libraries v1.0.0

2019-08-24 Thread Brian Spector
: Justin Mclean Sent: 24 August 2019 1:29 AM To: general@incubator.apache.org Subject: Re: [VOTE] Release Apache Milagro (incubating) Crypto Libraries v1.0.0 Hi, +1 (binding) if a question below can be answered I can see that the JS code includes a lot of standard algorithms, but the files

Re: [VOTE] Release Apache Milagro (incubating) Crypto Libraries v1.0.0

2019-08-23 Thread Justin Mclean
Hi, +1 (binding) if a question below can be answered I can see that the JS code includes a lot of standard algorithms, but the files have ASF headers and no 3rd party code is mentioned in LICENSE or in the files themselves that I can see. Was all of this code written entirely from scratch or

Re: [VOTE] Release Apache Milagro (incubating) Crypto Libraries v1.0.0

2019-08-22 Thread Brian Spector
Thanks, Furkan! We'll get on the disclaimer clean-up asap. On 22/08/2019, 10:47, "Furkan KAMACI" wrote: Hi, +1 from me. I checked: - Incubating in name - LICENSE is fine - NOTICE is fine - DISCLAIMER exists - No unexpected binary files - Code

Re: [VOTE] Release Apache Milagro (incubating) Crypto Libraries v1.0.0

2019-08-22 Thread Furkan KAMACI
Hi, +1 from me. I checked: - Incubating in name - LICENSE is fine - NOTICE is fine - DISCLAIMER exists - No unexpected binary files - Code compiles and tests successfully run for both ones One comment: DISCLAIMER files should be tidied up to be more readable at next release i.e.:

Re: [VOTE] Release Apache Milagro (incubating) Crypto Libraries v1.0.0

2019-08-22 Thread Brian Spector
Hi, even though my vote is non-binding, as a member of the PPMC I vote: [ ] +1 approve Please support our effort to get this release out. Thanks Brian On 21/08/2019, 16:10, "John McCane-Whitney" wrote: Hi, This is a call to vote to release the Apache Milagro (incubating)

Re: [VOTE] Release Apache Milagro (incubating) Crypto Libraries v1.0.0

2019-08-21 Thread Julian Feinauer
Hi all, +1 (binding) I checked - Download links are valid - Checksums and PGP signatures are valid for C - Checksums and PGP signatures are valid for JS - DISCLAIMER, LICENCE & NOTICE files are included - Artefacts have incubating in name - No compiled binaries are included - C Libraries build

[VOTE] Release Apache Milagro (incubating) Crypto Libraries v1.0.0

2019-08-21 Thread John McCane-Whitney
Hi, This is a call to vote to release the Apache Milagro (incubating) Crypto Libraries v1.0.0. The Apache Milagro (incubating) community has voted to approve this release with 5 x +1 votes. The vote thread can be found here: