Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

Hi Justin, On behalf of the Apache DevLake community, we made corrections based on your comments in v0.19.0-rc2. So we want to invite you to vote for v0.19.0-rc3 first. The voting thread is available at: https://lists.apache.org/thread/ymth9hgp6p82pclcbtght4cpdvyvz5mf Thank you very much

[CANCEL][VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

Hello everyone, I'm canceling this vote https://lists.apache.org/thread/n611lx48xhpn2ljgx9j9fcfpcn8b1bo4 due to license issues. I'll fix them and start a new vote process. Thanks a lot for all your help. Best, Zikuan An

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

Hi Justin, Thank you once again for your valuable insights. Based on your previous suggestions, I have made some updates to the version. I would greatly appreciate it if you could kindly review it once more to ensure everything is in order. Your expertise and guidance in this matter are immensely

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

hi xuanwo, The repository in the link you posted is incorrect usage. Although it has specified the yarn version in package.json, and yarn.lock also indicates this version, when the user actually uses it, since yarn2 depends on this file, if Not specifying yarnPath will cause yarn to be

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

For example, we can specify "packageManager" in package.json so that we don't need to include this binary in code: https://github.com/apache/incubator-opendal/blob/main/website/package.json#L44C4-L44C18 On Tue, Nov 21, 2023, at 08:22, Xuanwo wrote: >> - It is unclear what license yarn-3.4.1.cjs

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

> - It is unclear what license yarn-3.4.1.cjs is under - why not just say > it contains multiple pieces of 3rd party code under different licenses? yarn-3.4.1.cjs js a binary too. How about use `corepack` to ensure we are using the same version of yarn instead? For more inforamtion about

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

Hi, I think a little more work is needed: - It is unclear what license yarn-3.4.1.cjs is under - why not just say it contains multiple pieces of 3rd party code under different licenses? - You are misisng the BSD license for Yarn. The full text of the license needs to be included. - You still

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

Hi Justin, Thank you for your suggestion very much. I have made the necessary fixes in the version. I would be grateful if you could kindly assist me in reviewing it for accuracy. You can find the updated version here: https://github.com/apache/incubator-devlake/pull/6483/files Kind Regards,

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

Hi, Sorry, but it’s -1 (binding) from me. As I pointed out in my last review, multiple pieces of 3rd party code exist under different licenses, not just one. I suggest you look for copyright statements and work out the 3rd party software and licenses from that. I can see: Copyright (c) 2014

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

Hi Zikuan, Just for the record, adding the license *near* the beginning, as was done with yarn-3.4.1.cjs, is perfectly fine. It just needs to be easily found. That is, there is no need for the license to be the first text, as long as it is not after the real content. Warm regards, Craig > On

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

Hi Felix, The file config-ui/.yarn/releases/yarn-3.4.1.cjs is used to specify the yarn version and is a generated file. I added the BSD License , but it cannot be added at the beginning

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

+1 binding - incubating in name - signature and hash fine - DISCLAIMER is fine - LICENSE and NOTICE are fine - No unexpected binary files - All source files have ASF headers what is this file config-ui/.yarn/releases/yarn-3.4.1.cjs - seems to have code in it (and it does not have a license

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

+1(binding). Here is what I checked: - The checksums and signatures are validated. - The LICENSE and NOTICE files look good to me. - There is a DISCLAIMER file about incubating. - No binary files in the source release. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Nov 10, 2023 at

[VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

Hello everyone, This is a call for the vote to release Apache DevLake (Incubating) v0.19.0-rc2. The Apache DevLake community has voted on and approved a proposal to release Apache DevLake (Incubating) version v0.19.0-rc2. We now kindly request the Incubator PMC members review and vote on this