> On Thu, 09 May 2024, Michał Górny wrote:
>> +# it from being changed. The variable is left writable for use in overlays;
>> +# package naming restrictions would prohibit some otherwise-valid usernames.
> You're not following the original style (double spaces).
This is less about style than
If (after upcasing and replacing hyphens by underscores) ACCT_GROUP_NAME
is set to something that isn't valid in a bash variable name, the eclass
will crash: it uses ACCT_GROUP_NAME to construct the make.conf override
variables in pkg_pretend() and src_install(). This commit constructs the
variable
If (after upcasing and replacing hyphens by underscores) ACCT_USER_NAME
is set to something that isn't valid in a bash variable name, the eclass
will crash: it uses ACCT_USER_NAME to construct the make.conf override
variables in pkg_pretend() and src_install(). This commit constructs the
variable n
The ACCT_GROUP_NAME variable is set to $PN by Gentoo policy. Prior to
this commit, it was also marked "readonly", preventing it from being
changed in an ebuild. In an overlay, and combined with the package
naming restrictions in the PMS, this has the unfortunate side effect of
prohibiting some othe
The ACCT_USER_NAME variable is set to $PN by Gentoo policy. Prior to
this commit, it was also marked "readonly", preventing it from being
changed in an ebuild. In an overlay, and combined with the package
naming restrictions in the PMS, this has the unfortunate side effect of
prohibiting some other
Support changing the user/group name of GLEP81 packages. This is
sometimes required in overlays because package naming restrictions
prohibit valid user/group names from being package names.
We drop "readonly" from the eclasses, and use PN instead of
ACCT_{USER,GROUP}_NAME to construct the make.con
Martin Dummer writes:
> Am 09.05.24 um 14:13 schrieb Sam James:
>
> Martin Dummer writes:
>
>
> Maybe we can agree that the qa-warnings in vdr-eclass make more sense if i
> change them to "eawarn" or "einfo"?
>
>
> Sure, make them eqawarn.
>
> Hmm - current state of vdr-plugin-2.eclass is: t
Am 09.05.24 um 14:13 schrieb Sam James:
Martin Dummer writes:
Maybe we can agree that the qa-warnings in vdr-eclass make more sense if i change them to
"eawarn" or "einfo"?
Sure, make them eqawarn.
Hmm - current state of vdr-plugin-2.eclass is: there are many "eqawarn"
in there.
In m
On Thu, 2024-05-09 at 08:12 -0400, Michael Orlitzky wrote:
> On Thu, 2024-05-09 at 14:03 +0200, Michał Górny wrote:
> > > @ECLASS_VARIABLE: _OVERRIDE_NAME
> >
> > This is not prefixed correctly.
> >
>
> ACCT_USER_OVERRIDE_NAME has an entirely different meaning, but I could
> use _ACCT_USER_OVER
Martin Dummer writes:
> Am 03.05.24 um 06:39 schrieb Sam James:
>
>
> What we really need is:
> a) https://bugs.gentoo.org/162450 to avoid scaring users;
> b) possibly some level of QA notice to distinguish between "check this
> out" (think e.g. qa-vdb LHS where it _might_ be unused, but not
>
On Thu, 2024-05-09 at 14:03 +0200, Michał Górny wrote:
> > @ECLASS_VARIABLE: _OVERRIDE_NAME
>
> This is not prefixed correctly.
>
ACCT_USER_OVERRIDE_NAME has an entirely different meaning, but I could
use _ACCT_USER_OVERRIDE_NAME if that's what you're suggesting.
> > +# @INTERNAL
> > +# @DESC
Am 03.05.24 um 06:39 schrieb Sam James:
What we really need is:
a)https://bugs.gentoo.org/162450 to avoid scaring users;
b) possibly some level of QA notice to distinguish between "check this
out" (think e.g. qa-vdb LHS where it _might_ be unused, but not
necessarily), and "this is definitely
On Thu, 2024-05-09 at 07:57 -0400, Michael Orlitzky wrote:
> If (after upcasing and replacing hyphens by underscores) ACCT_USER_NAME
> is set to something that isn't valid in a bash variable name, the eclass
> will crash: it uses ACCT_USER_NAME to construct the make.conf override
> variables in pkg
On Thu, 2024-05-09 at 07:57 -0400, Michael Orlitzky wrote:
> The ACCT_USER_NAME variable is set to $PN by Gentoo policy. Prior to
> this commit, it was also marked "readonly", preventing it from being
> changed in an ebuild. In an overlay, and combined with the package
> naming restrictions in the
If (after upcasing and replacing hyphens by underscores) ACCT_GROUP_NAME
is set to something that isn't valid in a bash variable name, the eclass
will crash: it uses ACCT_GROUP_NAME to construct the make.conf override
variables in pkg_pretend() and src_install().
This commit relocates the computat
If (after upcasing and replacing hyphens by underscores) ACCT_USER_NAME
is set to something that isn't valid in a bash variable name, the eclass
will crash: it uses ACCT_USER_NAME to construct the make.conf override
variables in pkg_pretend() and src_install().
This commit relocates the computatio
The ACCT_GROUP_NAME variable is set to $PN by Gentoo policy. Prior to
this commit, it was also marked "readonly", preventing it from being
changed in an ebuild. In an overlay, and combined with the package
naming restrictions in the PMS, this has the unfortunate side effect of
prohibiting some othe
The ACCT_USER_NAME variable is set to $PN by Gentoo policy. Prior to
this commit, it was also marked "readonly", preventing it from being
changed in an ebuild. In an overlay, and combined with the package
naming restrictions in the PMS, this has the unfortunate side effect of
prohibiting some other
Support changing the user/group name of GLEP81 packages. This is
sometimes required in overlays because package naming restrictions
prohibit valid user/group names from being package names.
We drop "readonly" from the eclasses, and move the computation of the
make.conf override variable names to g
19 matches
Mail list logo