Re: [gentoo-dev] [PATCH 1/4] acct-user.eclass: make ACCT_USER_NAME writable

2024-05-09 Thread Ulrich Mueller
> On Thu, 09 May 2024, Michał Górny wrote: >> +# it from being changed. The variable is left writable for use in overlays; >> +# package naming restrictions would prohibit some otherwise-valid usernames. > You're not following the original style (double spaces). This is less about style than

[gentoo-dev] [PATCH v2 4/4] eclass/acct-group.eclass: use $PN to construct make.conf override vars

2024-05-09 Thread Michael Orlitzky
If (after upcasing and replacing hyphens by underscores) ACCT_GROUP_NAME is set to something that isn't valid in a bash variable name, the eclass will crash: it uses ACCT_GROUP_NAME to construct the make.conf override variables in pkg_pretend() and src_install(). This commit constructs the variable

[gentoo-dev] [PATCH v2 3/4] eclass/acct-user.eclass: use $PN to construct make.conf override vars

2024-05-09 Thread Michael Orlitzky
If (after upcasing and replacing hyphens by underscores) ACCT_USER_NAME is set to something that isn't valid in a bash variable name, the eclass will crash: it uses ACCT_USER_NAME to construct the make.conf override variables in pkg_pretend() and src_install(). This commit constructs the variable n

[gentoo-dev] [PATCH v2 2/4] acct-group.eclass: make ACCT_GROUP_NAME writable

2024-05-09 Thread Michael Orlitzky
The ACCT_GROUP_NAME variable is set to $PN by Gentoo policy. Prior to this commit, it was also marked "readonly", preventing it from being changed in an ebuild. In an overlay, and combined with the package naming restrictions in the PMS, this has the unfortunate side effect of prohibiting some othe

[gentoo-dev] [PATCH v2 1/4] acct-user.eclass: make ACCT_USER_NAME writable

2024-05-09 Thread Michael Orlitzky
The ACCT_USER_NAME variable is set to $PN by Gentoo policy. Prior to this commit, it was also marked "readonly", preventing it from being changed in an ebuild. In an overlay, and combined with the package naming restrictions in the PMS, this has the unfortunate side effect of prohibiting some other

[gentoo-dev] [PATCH v2 0/4] acct-{user,group}.eclass: make user/group names writable

2024-05-09 Thread Michael Orlitzky
Support changing the user/group name of GLEP81 packages. This is sometimes required in overlays because package naming restrictions prohibit valid user/group names from being package names. We drop "readonly" from the eclasses, and use PN instead of ACCT_{USER,GROUP}_NAME to construct the make.con

Re: [gentoo-dev] [PATCH] vdr-plugin-2.eclass: make qa warning conditional

2024-05-09 Thread Sam James
Martin Dummer writes: > Am 09.05.24 um 14:13 schrieb Sam James: > > Martin Dummer writes: > > > Maybe we can agree that the qa-warnings in vdr-eclass make more sense if i > change them to "eawarn" or "einfo"? > > > Sure, make them eqawarn. > > Hmm - current state of vdr-plugin-2.eclass is: t

Re: [gentoo-dev] [PATCH] vdr-plugin-2.eclass: make qa warning conditional

2024-05-09 Thread Martin Dummer
Am 09.05.24 um 14:13 schrieb Sam James: Martin Dummer writes: Maybe we can agree that the qa-warnings in vdr-eclass make more sense if i change them to "eawarn" or "einfo"? Sure, make them eqawarn. Hmm - current state of vdr-plugin-2.eclass is: there are many "eqawarn" in there. In m

Re: [gentoo-dev] [PATCH 3/4] acct-user.eclass: use an eclass variable for the override variable name

2024-05-09 Thread Michał Górny
On Thu, 2024-05-09 at 08:12 -0400, Michael Orlitzky wrote: > On Thu, 2024-05-09 at 14:03 +0200, Michał Górny wrote: > > > @ECLASS_VARIABLE: _OVERRIDE_NAME > > > > This is not prefixed correctly. > > > > ACCT_USER_OVERRIDE_NAME has an entirely different meaning, but I could > use _ACCT_USER_OVER

Re: [gentoo-dev] [PATCH] vdr-plugin-2.eclass: make qa warning conditional

2024-05-09 Thread Sam James
Martin Dummer writes: > Am 03.05.24 um 06:39 schrieb Sam James: > > > What we really need is: > a) https://bugs.gentoo.org/162450 to avoid scaring users; > b) possibly some level of QA notice to distinguish between "check this > out" (think e.g. qa-vdb LHS where it _might_ be unused, but not >

Re: [gentoo-dev] [PATCH 3/4] acct-user.eclass: use an eclass variable for the override variable name

2024-05-09 Thread Michael Orlitzky
On Thu, 2024-05-09 at 14:03 +0200, Michał Górny wrote: > > @ECLASS_VARIABLE: _OVERRIDE_NAME > > This is not prefixed correctly. > ACCT_USER_OVERRIDE_NAME has an entirely different meaning, but I could use _ACCT_USER_OVERRIDE_NAME if that's what you're suggesting. > > +# @INTERNAL > > +# @DESC

Re: [gentoo-dev] [PATCH] vdr-plugin-2.eclass: make qa warning conditional

2024-05-09 Thread Martin Dummer
Am 03.05.24 um 06:39 schrieb Sam James: What we really need is: a)https://bugs.gentoo.org/162450 to avoid scaring users; b) possibly some level of QA notice to distinguish between "check this out" (think e.g. qa-vdb LHS where it _might_ be unused, but not necessarily), and "this is definitely

Re: [gentoo-dev] [PATCH 3/4] acct-user.eclass: use an eclass variable for the override variable name

2024-05-09 Thread Michał Górny
On Thu, 2024-05-09 at 07:57 -0400, Michael Orlitzky wrote: > If (after upcasing and replacing hyphens by underscores) ACCT_USER_NAME > is set to something that isn't valid in a bash variable name, the eclass > will crash: it uses ACCT_USER_NAME to construct the make.conf override > variables in pkg

Re: [gentoo-dev] [PATCH 1/4] acct-user.eclass: make ACCT_USER_NAME writable

2024-05-09 Thread Michał Górny
On Thu, 2024-05-09 at 07:57 -0400, Michael Orlitzky wrote: > The ACCT_USER_NAME variable is set to $PN by Gentoo policy. Prior to > this commit, it was also marked "readonly", preventing it from being > changed in an ebuild. In an overlay, and combined with the package > naming restrictions in the

[gentoo-dev] [PATCH 4/4] acct-group.eclass: use an eclass variable for the override variable name

2024-05-09 Thread Michael Orlitzky
If (after upcasing and replacing hyphens by underscores) ACCT_GROUP_NAME is set to something that isn't valid in a bash variable name, the eclass will crash: it uses ACCT_GROUP_NAME to construct the make.conf override variables in pkg_pretend() and src_install(). This commit relocates the computat

[gentoo-dev] [PATCH 3/4] acct-user.eclass: use an eclass variable for the override variable name

2024-05-09 Thread Michael Orlitzky
If (after upcasing and replacing hyphens by underscores) ACCT_USER_NAME is set to something that isn't valid in a bash variable name, the eclass will crash: it uses ACCT_USER_NAME to construct the make.conf override variables in pkg_pretend() and src_install(). This commit relocates the computatio

[gentoo-dev] [PATCH 2/4] acct-group.eclass: make ACCT_GROUP_NAME writable

2024-05-09 Thread Michael Orlitzky
The ACCT_GROUP_NAME variable is set to $PN by Gentoo policy. Prior to this commit, it was also marked "readonly", preventing it from being changed in an ebuild. In an overlay, and combined with the package naming restrictions in the PMS, this has the unfortunate side effect of prohibiting some othe

[gentoo-dev] [PATCH 1/4] acct-user.eclass: make ACCT_USER_NAME writable

2024-05-09 Thread Michael Orlitzky
The ACCT_USER_NAME variable is set to $PN by Gentoo policy. Prior to this commit, it was also marked "readonly", preventing it from being changed in an ebuild. In an overlay, and combined with the package naming restrictions in the PMS, this has the unfortunate side effect of prohibiting some other

[gentoo-dev] [PATCH 0/4] acct-{user,group}.eclass: make user/group names writable

2024-05-09 Thread Michael Orlitzky
Support changing the user/group name of GLEP81 packages. This is sometimes required in overlays because package naming restrictions prohibit valid user/group names from being package names. We drop "readonly" from the eclasses, and move the computation of the make.conf override variable names to g