[gentoo-portage-dev] [PATCH] portage/sync/modules/rsync: Fix UnicodeDecodeError: bug 549826

2015-05-18 Thread Brian Dolbec
X-Gentoo-Bug: 549826 X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=549826 X-Gentoo-forums: https://forums.gentoo.org/viewtopic-t-1017380.html --- pym/portage/sync/modules/rsync/rsync.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [gentoo-portage-dev] [PATCH 2/2] man: Document repoman --straight-to-stable

2015-05-18 Thread Brian Dolbec
about extraneous info .TP Thanks, both commits look good. I'll push them in a little while. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] squashdelta sync: fix incorrect use of _fetch()

2015-05-18 Thread Brian Dolbec
could make a pkgcore sync module for it as well and add IUSE flags for each package manager. -- Brian Dolbec dolsen Portage, Layman, Gentoo-keys Lead developer

Re: [gentoo-dev] Re: News item review: SquashDelta syncing support

2015-05-18 Thread Brian Dolbec
add a postsync hook there looking for the gentoo repo argument. And if not exit. If it is the gentoo repo, call your squashmount script to remount it your way. See the example script in that directory. -- Brian Dolbec dolsen

Re: [gentoo-dev] News item review: SquashDelta syncing support

2015-05-16 Thread Brian Dolbec
to wait. There is a few bugs in the commit made to portage for the release. It doesn't run. It is fixed in portage- though. We'll see if we can get it gpg verifying with gkeys for another release. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] config: skip missing profiles/repo_name warning when using layout.conf:repo-name

2015-05-14 Thread Brian Dolbec
for value in ('allow-missing-manifest', 'allow-provide-virtual', 'cache-formats', Yeah, merge please Wasn't there a bug for this? If there is pleas add the bug # to the commit message -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] dispatch-conf: handle file/directory collisions (bug 256376)

2015-05-10 Thread Brian Dolbec
') + dest = %s.dist % archive + if os.path.isdir(dest) and not os.path.islink(dest): + _file_archive_rotate(dest) + os.rename(archive + '.dist.new', dest) looks good -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] VdbMetadataDelta.applyDelta: handle remove events properly (bug 547532)

2015-05-09 Thread Brian Dolbec
] + if not deltas: + break looks good -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] Bundle a minimalistic derivation of Python's formatter module (bug 547732)

2015-05-06 Thread Brian Dolbec
On Wed, 06 May 2015 10:39:26 -0700 Zac Medico zmed...@gentoo.org wrote: On 04/28/15 18:48, Zac Medico wrote: On 04/28/2015 05:07 PM, Brian Dolbec wrote: On Sat, 25 Apr 2015 13:37:10 -0700 Zac Medico zmed...@gentoo.org wrote: Python's formatter module is scheduled for removal in Python

Re: [gentoo-portage-dev] [PATCH] varexpand: fix IndexError (bug 548556)

2015-05-04 Thread Brian Dolbec
) + return + braced = True else: braced = False Yeah, good idea, looks good. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] bintree.populate: binhost connection failure triggers TypeError (bug 532784)

2015-05-04 Thread Brian Dolbec
= needed to not be passed in. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] bintree.populate: binhost connection failure triggers TypeError (bug 532784)

2015-05-04 Thread Brian Dolbec
On Sun, 03 May 2015 23:37:52 -0700 Zac Medico zmed...@gentoo.org wrote: On 05/03/2015 11:25 PM, Brian Dolbec wrote: Isn't this backwards from what was reported. It generated a UnicodeDecodeError when using additional args to unicode(). It was actually a TypeError. It needed

Re: [gentoo-portage-dev] [PATCH] Scheduler: increase visiblity of postinst failures (bug 547778)

2015-05-03 Thread Brian Dolbec
looks good :) -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH v2] PORTAGE_XATTR_EXCLUDE: preserve security.capability (bug 548516)

2015-05-03 Thread Brian Dolbec
:) -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH v3] ebuild-helpers: avoid exec loops or fork bombs in wrappers (bug 547086)

2015-04-28 Thread Brian Dolbec
*/portage/* ]] continue + [[ ${x} == */._portage_reinstall_.* ]] continue + path+=:${x} +done +PATH=${path#:} + if [[ ${implementation} == c ]]; then exec ${INSTALL_XATTR} $@ elif [[ ${implementation} == python ]]; then looks good -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] _unmerge_protected_symlinks: suggest UNINSTALL_IGNORE (bug 428098)

2015-04-28 Thread Brian Dolbec
(s)...)) msg.append() Merge it please :) -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] search: fix addCP so only the specified results are displayed (bug 547736)

2015-04-28 Thread Brian Dolbec
((mytype, match)) iterator = iter(addCP_matches) else: Looks good -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] Make the USE variable readonly (bug 325009)

2015-04-28 Thread Brian Dolbec
} ]] \ - ! has test ${USE} ; then - export USE=${USE} test - fi - local save_sp=${SANDBOX_PREDICT} addpredict / __ebuild_phase pre_src_test Looks good -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH v3] ro_checker: only check nearest parent (bug 547390)

2015-04-28 Thread Brian Dolbec
: + ro_filesystems.add(ro_devs[dev]) + except KeyError: + pass + + return ro_filesystems def empty_ro_checker(dir_list): looks fine -- Brian Dolbec dolsen

[gentoo-portage-dev] [PATCH] portage/util.py: Identify the source of a bad sustitution error message (bug 542796)

2015-04-23 Thread Brian Dolbec
This bug caused great difficulty in determining the cause of the error message. This adds identifying code which states where the error message is coming from. It also adds the actual source which caused the error message in the first place. X-Gentoo-Bug: 542796 X-Gentoo-Bug-url:

Re: [gentoo-dev] Re: git://anongit.gentoo.org is extremely slow

2015-04-22 Thread Brian Dolbec
in repositories.xml. That resulted in failures to update to a new valid url. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] _doebuild_path: add fallback for temp PORTAGE_BIN_PATH (bug 547086)

2015-04-21 Thread Brian Dolbec
(os.path.join(x, ebuild-helpers, bsd)) - path.append(os.path.join(portage_bin_path, ebuild-helpers)) + for x in portage_bin_path: + path.append(os.path.join(x, ebuild-helpers)) path.extend(prerootpath) for prefix in prefixes: LGTM -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCHv2 2/2] MEDIUM: misc-functions: Be more verbose when removing INSTALL_MASK glob

2015-04-19 Thread Brian Dolbec
also set LANG=C for locale independence? Looks good, Zac can you just edit those changes in while you merge it please. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] Contribute squashdelta syncing module

2015-04-16 Thread Brian Dolbec
. Please stub out a function call for it when you address the above issues. I'll fill in the code for it. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] ro_checker: skip parents of EPREFIX dir (bug 544624)

2015-04-05 Thread Brian Dolbec
: try: LGTM -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH v2] fetch(): fix support for digest size=None

2015-04-05 Thread Brian Dolbec
parallel_fetchonly and \ mystat.st_size == mydigests[myfile][size]: OK :) merge please -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] repoman: change metadata.dtd protocol to https

2015-04-05 Thread Brian Dolbec
that was being moved to api.gentoo.org. I just checked and it isn't there... I want to verify that it isn't destined there in the very near future. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] Re: Dynamic USE dependencies

2015-04-03 Thread Brian Dolbec
comments it does not do ;) plus it saves the new file to your user space, you can do what you like with them from there. Editing your detail commented files to match, etc.. stright swap,... -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] Re: Dynamic USE dependencies

2015-04-03 Thread Brian Dolbec
On Fri, 3 Apr 2015 11:52:39 + (UTC) Duncan 1i5t5.dun...@cox.net wrote: Brian Dolbec posted on Thu, 02 Apr 2015 23:59:06 -0700 as excerpted: This is a reminder to you all... since enalyze is little known to users. Thanks for the hint. I'd never heard of enalyze before but it sounds

Re: [gentoo-portage-dev] [PATCH] binarytree.move_ent: fix binpkg-multi-instance _pkg_paths corruption (bug 545252)

2015-04-01 Thread Brian Dolbec
: self._ensure_dir(os.path.dirname(new_path)) _movefile(tbz2path, new_path, mysettings=self.settings) merge it please :) -- Brian Dolbec dolsen

Re: [gentoo-dev] RFC: app-eselect category

2015-03-28 Thread Brian Dolbec
) of packages in a category. Ulrich [1] https://archives.gentoo.org/gentoo-dev/message/4cfd11c209754be96ffa417cb4d40b9f yes, +1 -- Brian Dolbec dolsen pgpJhxXd2_SPR.pgp Description: OpenPGP digital signature

Re: [gentoo-dev] Naming of repositories: gento-x86 edition, bike shedding wanted

2015-03-19 Thread Brian Dolbec
/gentoo, trees/gentoo, repos/gentoo,... The directory name it is installed to MUST be the same as it's repo_name. $ git clone git://anongit.gentoo.org/gentoo-tree.git gentoo The rsync tree generated from the git repo must also be set to clone into a gentoo named directory. - -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] Portage and Update Security

2015-03-15 Thread Brian Dolbec
://archives.gentoo.org/gentoo-portage-dev/message/bda425ee6c676ec7a6b3c9500a9b00bf -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] List moderation issue? was - Re: Portage and Updater Security

2015-03-10 Thread Brian Dolbec
. -- vladimir.v.d...@gmail.com PGP fingerprint = ACCF 9DCA 73B9 862F 93C5 6608 63F8 90AA 1D25 3935 -- -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] WorldSelectedSet: fix load method for bug 542732

2015-03-09 Thread Brian Dolbec
are the expert there ;) -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] Security and Comparison of Portage with other Package Managers

2015-03-07 Thread Brian Dolbec
questions for now is. Do we want to have a post sync hook that checks the tree for invalid Manifest sigs? Or do we just have it verify the manifest for the pkg at build/merge time? Or both? -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] Security and Comparison of Portage with other Package Managers

2015-03-07 Thread Brian Dolbec
On Sat, 07 Mar 2015 18:31:44 -0800 Zac Medico zmed...@gentoo.org wrote: On 03/07/2015 05:24 PM, Brian Dolbec wrote: On Sat, 07 Mar 2015 15:26:26 -0800 Zac Medico zmed...@gentoo.org wrote: On 03/06/2015 09:50 AM, Mark Kubacki wrote: We're on the same side here. Do we have numbers

Re: [gentoo-portage-dev] [PATCH] Don't spawn socks5-server.py for pkg_nofetch (bug 542052)

2015-03-04 Thread Brian Dolbec
(mysettings) except NotImplementedError: LGTM ... now for me to finish some things so I can actually get the the release done... -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] make.conf: expand PORTAGE_CONFIGROOT (bug 511806)

2015-03-03 Thread Brian Dolbec
(PORTAGE_BASE_PATH, cnf, make.globals) LGTM, merge please :) -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] man/emaint.1: Add entry about the merges module

2015-02-28 Thread Brian Dolbec
/ .SH AUTHORS .nf +Pavel Kazakov nullishz...@gentoo.org Mike Frysinger vap...@gentoo.org Brian Dolbec dol...@gentoo.org .fi You forgot to add the merges tracking file to the FILES section -- Brian Dolbec dolsen

[gentoo-portage-dev] [PATCH] emaint.1: Update man page for better clarity

2015-02-28 Thread Brian Dolbec
As recommended by Duncan on the gentoo-portage-dev list. Clarify the all command. Add OPTIONS to all commands, so a user can determine which modules may run when the 'all' command is used. Remove repetitive '(* command only)' text by adding it to the section header. --- man/emaint.1 | 43

Re: [gentoo-portage-dev] [PATCH] emaint.1: Update man page for better clarity

2015-02-28 Thread Brian Dolbec
On Sat, 28 Feb 2015 16:11:56 -0800 Brian Dolbec dol...@gentoo.org wrote: As recommended by Duncan on the gentoo-portage-dev list. Clarify the all command. Add OPTIONS to all commands, so a user can determine which modules may run when the 'all' command is used. Remove repetitive '(* command

Re: [gentoo-portage-dev] [PATCH] use_reduce: support non-string token_class (bug 541198)

2015-02-24 Thread Brian Dolbec
, merge please -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] actions.py: fix missing localization import (bug 541302)

2015-02-24 Thread Brian Dolbec
)) and \ (any(buildpkg in trees[eroot][root_config]. settings.features for eroot in trees) or any(buildsyspkg in trees[eroot][root_config]. LGTM -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] man/portage.5: document sets.conf (bug 541188)

2015-02-23 Thread Brian Dolbec
are installed +in \fB/usr/share/portage/config/sets/portage.conf\fR. +.RE +.TP .BR /var/cache/edb/ .RS This directory is used to store internal portage cache files. The names and looks good :) Thank you -- Brian Dolbec dolsen

Re: [gentoo-dev] [OT] pkgcore bountry or contract work

2015-02-21 Thread Brian Dolbec
at the moment. misc other python coding.. etc -- If we fail to find an interested and qualified candidate I'll probably post bounties Please reply offlist Christopher codestr0m on irc freenode -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] emaint merges: Fix call to emerge

2015-02-21 Thread Brian Dolbec
', - os.path.join(PORTAGE_BIN_PATH, 'emerge'), + os.path.join(EPREFIX or '/', 'usr', 'bin', 'emerge'), + '--ask', '--quiet', '--oneshot', '--complete-graph=y' LGTM, merge please :) -- Brian Dolbec

Re: [gentoo-portage-dev] [PATCH 1/2] Add FEATURES=binpkg-multi-instance (bug 150031)

2015-02-17 Thread Brian Dolbec
On Tue, 17 Feb 2015 11:26:27 -0800 Zac Medico zmed...@gentoo.org wrote: On 02/17/2015 10:42 AM, Brian Dolbec wrote: overall, there is no way I know the code well enough to know if you screwed up. But the code looks decent, so... My only questions are: pym/portage/dbapi

Re: [gentoo-portage-dev] [PATCH] binarytree: avoid unecessary index regeneration

2015-02-17 Thread Brian Dolbec
PGP SIGNATURE- Version: GnuPG v2 iF4EAREIAAYFAlTjWBYACgkQRtClrXBQc7V3CgEAjREJrZasgGrfP0fIdo7/oKZ7 /dMazIA2rnu6+CfeLlABAI9kc06NR2msTo4a1XTq6dxzSIrgqXIYxBfy/oDNY+rh =Fl7x -END PGP SIGNATURE- SURE! just reply to the EASY one ;) - -- Brian Dolbec dolsen -BEGIN PGP SIGNATURE

Re: [gentoo-portage-dev] [PATCH 1/2] Add FEATURES=binpkg-multi-instance (bug 150031)

2015-02-17 Thread Brian Dolbec
(var) except ValueError: if var: var = -1 else: var = default return var -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH 2/2] Add profile-formats=build-id (bug 150031)

2015-02-17 Thread Brian Dolbec
= True + if allow_build_id is None: + allow_build_id = True these can be written as allow_repo = allow_repo or True allow_build_id = allow_build_id or True Otherwise looks decent. -- Brian Dolbec dolsen

Re: [gentoo-dev] Making more repoman checks fatal

2015-02-16 Thread Brian Dolbec
Portage ebuild triggers minorsyn due to a false positive quoting issue. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] Fix random SonameOrChoicesTestCase failure

2015-02-14 Thread Brian Dolbec
if not atom.package: unevaluated_atom = None LGTM -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] repoman: mark errors with explicit '[fatal']

2015-02-10 Thread Brian Dolbec
() if not dofull: if not full and dofail and category in qawarnings: Works for me. merge approved -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] libtool and sysroot

2015-02-07 Thread Brian Dolbec
people to refer to the tree as the gentoo tree (same as the repo name) to help avoid this confusion. This should be submitted to bugzilla, where it will be assigned to the pam maintainer. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] libtool and sysroot

2015-02-07 Thread Brian Dolbec
On Sat, 7 Feb 2015 17:30:42 + Joakim Tjernlund joakim.tjernl...@transmode.se wrote: On Sat, 2015-02-07 at 09:17 -0800, Brian Dolbec wrote: Joakim, email pam-bugs directly. Not the portage-dev list please. I think you are misunderstanding me. The PAM problem is just an example which

Re: [gentoo-portage-dev] Regarding ACKs to the effect of looks OK except...

2015-02-05 Thread Brian Dolbec
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Thu, 05 Feb 2015 15:51:34 +0100 Alexander Berntsen berna...@gentoo.org wrote: On 18/01/15 17:33, Brian Dolbec wrote: Yeah, just move this to sorted order like Arfrever said. Otherwise it looks good, ready to merge. Friends, I want

Re: [gentoo-dev] arm64

2015-02-04 Thread Brian Dolbec
understand the issue. I can give you an accout here; system is Opteron 2000 (i.e., ancient) but it is arm64. Isn't an opteron processor an amd64, not arm64. The arm64 is a very new processor in the arm family, just in the last year or so. -- Brian Dolbec dolsen

Re: [gentoo-dev] Portage news announcement review

2015-02-03 Thread Brian Dolbec
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Mon, 2 Feb 2015 16:54:37 -0800 Brian Dolbec dol...@gentoo.org wrote: On 02.02.2015 22:58, Brian Dolbec wrote: sys-apps/portage-2.2.16 is ready for release and is just waiting for the news announcement about the new plug-in sync

Re: [gentoo-dev] Portage news announcement review

2015-02-03 Thread Brian Dolbec
On Tue, 3 Feb 2015 17:37:49 +0300 Andrew Savchenko birc...@gentoo.org wrote: On Mon, 2 Feb 2015 16:54:37 -0800 Brian Dolbec wrote: Attached is an updated news item. [...] Changes: /etc/portage/repos.conf/* New for all repository types (needed): auto-sync = yes/no, true

Re: [gentoo-dev] Portage news announcement review

2015-02-03 Thread Brian Dolbec
page [1] for more detailed migration instructions. https://wiki.gentoo.org/wiki/Project:Portage/Sync -- Brian Dolbec dolsen signature.asc Description: PGP signature

Re: [gentoo-dev] Portage news announcement review

2015-02-03 Thread Brian Dolbec
On Tue, 3 Feb 2015 20:52:27 +0300 Diamond diam...@hi-net.ru wrote: On Tue, 3 Feb 2015 08:36:54 -0800 Brian Dolbec dol...@gentoo.org wrote: 1. Why autosync is disabled by default? This broke current default for emerge --sync. And if users added overlays, they most definitely want them

Re: [gentoo-dev] Portage news announcement review

2015-02-03 Thread Brian Dolbec
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Tue, 3 Feb 2015 13:25:39 -0500 Rich Freeman ri...@gentoo.org wrote: On Tue, Feb 3, 2015 at 11:36 AM, Brian Dolbec dol...@gentoo.org wrote: You can't fix crap code to both keep the old crap handling while still giving you new decent

[gentoo-dev] Portage news announcement review

2015-02-02 Thread Brian Dolbec
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 sys-apps/portage-2.2.16 is ready for release and is just waiting for the news announcement about the new plug-in sync system being used and the changes in it's operation. Attached is the news announcement for review. - -- Brian Dolbec dolsen

[gentoo-portage-dev] Portage news announcement review

2015-02-02 Thread Brian Dolbec
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 sys-apps/portage-2.2.16 is ready for release and is just waiting for the news announcement about the new plug-in sync system being used and the changes in it's operation. Attached is the news announcement for review. - -- Brian Dolbec dolsen

Re: [gentoo-dev] Portage news announcement review

2015-02-02 Thread Brian Dolbec
On Mon, 2 Feb 2015 19:24:38 -0500 Rich Freeman ri...@gentoo.org wrote: On Mon, Feb 2, 2015 at 4:58 PM, Brian Dolbec dol...@gentoo.org wrote: sys-apps/portage-2.2.16 is ready for release and is just waiting for the news announcement about the new plug-in sync system being used

Re: [gentoo-dev] Portage news announcement review

2015-02-02 Thread Brian Dolbec
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Mon, 02 Feb 2015 23:21:53 +0100 Manuel RĂ¼ger mr...@gentoo.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 02.02.2015 22:58, Brian Dolbec wrote: sys-apps/portage-2.2.16 is ready for release and is just waiting

Re: [gentoo-dev] [PATCH] pym/portage/news.py: let slackers copy+paste the news read command

2015-02-02 Thread Brian Dolbec
.) + print(Use + colorize(GOOD, eselect news read) + to view new items.) print() Wrong list. Plus it's already applied and in git. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH v5] Support escaping network-sandbox through SOCKSv5 proxy

2015-01-31 Thread Brian Dolbec
+ to the client. + + Just missing the function @params otherwise is good to go -- Brian Dolbec dolsen

Re: [gentoo-dev] about the stable requests

2015-01-31 Thread Brian Dolbec
bump and re-Stabilization request for the EAPI/distutils-r1 change. Is that one you prefer we just handle and not add to your list? I wouldn't have for just the berlios url changes. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] lockfile: handle EINTR for bug #538314

2015-01-31 Thread Brian Dolbec
) try: if __PORTAGE_TEST_HARDLINK_LOCKS in os.environ: raise IOError(errno.ENOSYS, Function not implemented) Looks good -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] Re: [gentoo-dev] [PATCH] pym/portage/news.py: let slackers copy+paste the news read command

2015-01-30 Thread Brian Dolbec
better would be 'eselect news read' to view new items? ie. view instead of the second read. Yeah, that's much better. Committed and pushed this last version. Thank you Toralf -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] Generate soname dependency metadata (282639)

2015-01-30 Thread Brian Dolbec
python installations, but that should not be an issue in practice. broken python is not reliable then anyway... I think I like the struct idea better. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] portage sync changes, fixes

2015-01-30 Thread Brian Dolbec
On Thu, 29 Jan 2015 11:45:18 -0800 Brian Dolbec dol...@gentoo.org wrote: From mgorny's recent suggestions and bug report... Plus a final pyflakes cleanup. pushed with suggested change for has_bin -- Brian Dolbec dolsen

[gentoo-portage-dev] [PATCH 2/3] portage/sync/syncbase.py: Change has_bin to an @property function

2015-01-29 Thread Brian Dolbec
This avoids that self.logger is None error in the __init__(). --- pym/portage/sync/syncbase.py | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/pym/portage/sync/syncbase.py b/pym/portage/sync/syncbase.py index c820bcf..973d545 100644 ---

[gentoo-portage-dev] portage sync changes, fixes

2015-01-29 Thread Brian Dolbec
From mgorny's recent suggestions and bug report... Plus a final pyflakes cleanup.

[gentoo-portage-dev] [PATCH 1/3] portage/sync: Break out a NewBase class from SyncBase

2015-01-29 Thread Brian Dolbec
From mgorny's suggestion, rename _sync() to update(). Raise NotImplementedError in base classes. Directly override sync() in websync module. Fix up line spacing to be consistent. --- pym/portage/sync/modules/cvs/cvs.py | 10 +++--- pym/portage/sync/modules/git/git.py | 8 ++---

[gentoo-portage-dev] [PATCH 3/3] portage/sync: Some final pyflakes code cleanup

2015-01-29 Thread Brian Dolbec
--- pym/portage/sync/modules/cvs/cvs.py | 1 - pym/portage/sync/modules/git/git.py | 6 -- pym/portage/sync/modules/svn/svn.py | 5 ++--- pym/portage/sync/modules/websync/websync.py | 4 4 files changed, 2 insertions(+), 14 deletions(-) diff --git

Re: [gentoo-portage-dev] [PATCH v3] Support escaping network-sandbox through SOCKSv5 proxy

2015-01-25 Thread Brian Dolbec
variables should also be changed to instance variables. Yeah, I meant to ask you the same... Do they need to be class wide (multiple instances refer to the same exact variables) or just instance wide ones. But I hadn't looked it over in enough detail yet. And LOOSE the _my prefix. -- Brian Dolbec

Re: [gentoo-dev] Re: Review: news item and script for CPU_FLAGS_X86

2015-01-23 Thread Brian Dolbec
commonplace in usage, it also requires devs to fix their current keys and LDAP data, or generate new GLEP 63 compliant keys. But that is an off topic discussion -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] Support USE_EXPAND prefixes in package.use and relevant files

2015-01-22 Thread Brian Dolbec
. This also needs a man page description update somewhere. We need to have another meeting, decide where to cut off for the next release. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] chpathtool.py: avoid unnecessary optparse import

2015-01-19 Thread Brian Dolbec
. Fixes: d217db2bc76e (Make use of optparse to fix argument parsing for Python 2.6 in bin/chpathtool.py.) --- bin/chpathtool.py | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) Looks good. :) -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] sync: fix module_names enumeration

2015-01-18 Thread Brian Dolbec
an 'all' to the list. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] sync: support sync-clone-depth for DVCS-es (git --depth)

2015-01-18 Thread Brian Dolbec
._native_kwargs(self.spawn_kwargs)) if exitcode != os.EX_OK: -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH v2] svn sync: fix the module

2015-01-18 Thread Brian Dolbec
it doesn't serve any purpose. --- pym/portage/sync/modules/svn/svn.py | 42 +++-- 1 file changed, 17 insertions(+), 25 deletions(-) Looks good, thank you for this update. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] sync: unify syncing messages and reduce noise

2015-01-18 Thread Brian Dolbec
| 2 +- pym/portage/sync/modules/svn/svn.py | 6 -- pym/portage/sync/modules/websync/websync.py | 6 -- 6 files changed, 18 insertions(+), 41 deletions(-) This one is good to merge -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] cvs sync: fix the module

2015-01-18 Thread Brian Dolbec
/portage/sync/modules/cvs/cvs.py | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) Looks good, merge please -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] emerge: default --backtrack=3 (bug #536926)

2015-01-18 Thread Brian Dolbec
/show_bug.cgi?id=536926 --- man/emerge.1| 2 +- pym/_emerge/depgraph.py | 2 +- pym/portage/tests/resolver/test_backtracking.py | 7 ++- 3 files changed, 8 insertions(+), 3 deletions(-) Looks good, merge please. -- Brian Dolbec

Re: [gentoo-portage-dev] [PATCH v2] sync: support sync-depth for DVCS-es (git --depth)

2015-01-18 Thread Brian Dolbec
, + depth_arg, portage._shell_quote(sync_uri)), **portage._native_kwargs(self.spawn_kwargs)) if exitcode != os.EX_OK: -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH v2] git sync: replace 'git rev-parse' with safer '.git' check

2015-01-18 Thread Brian Dolbec
/modules/git/git.py | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) Looks good. Thanks. -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] Re: [PATCH] TestFakedbapi: override EPREFIX for bug #492932

2015-01-18 Thread Brian Dolbec
later on. I didn't think it was ugly, 2 lines of code and some comments... yes, merge please -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH v2] Default MAKEOPTS to -j(ncpus+1) when unset

2015-01-18 Thread Brian Dolbec
/portage/util/cpuinfo.py| 18 ++ 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 pym/portage/util/cpuinfo.py looks good, merge please -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] More = atoms for autounmask USE changes (536392)

2015-01-18 Thread Brian Dolbec
good, merge please -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] compression_probe: support lz4, lzip, lzop

2015-01-18 Thread Brian Dolbec
in _decompressors support -c and -q, as required by BinpkgExtractorAsync. yes, looks good, merge please -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] BinpkgExtractorAsync: xz and gzip decompression (142579)

2015-01-16 Thread Brian Dolbec
= _compression_re.match(f.read(6)) + if m is not None: + for k, v in m.groupdict().items(): + if v is not None: + return k + + return None -- Brian Dolbec dolsen

Re: [gentoo-portage-dev] [PATCH] BinpkgExtractorAsync: xz and gzip decompression (142579)

2015-01-15 Thread Brian Dolbec
On Thu, 15 Jan 2015 20:53:02 -0800 Zac Medico zmed...@gentoo.org wrote: On 01/15/2015 07:00 PM, Brian Dolbec wrote: On Thu, 15 Jan 2015 17:27:23 -0800 Zac Medico zmed...@gentoo.org wrote: # Add -q to bzip2 opts, in order to avoid trailing garbage after # EOF ignored warning

Re: [gentoo-portage-dev] Re: [PATCH] emerge: add --changed-deps/--binpkg-changed-deps (282927)

2015-01-14 Thread Brian Dolbec
changed, 323 insertions(+), 12 deletions(-) create mode 100644 pym/portage/tests/resolver/test_changed_deps.py Any feedback on this? I think it's good to merge. yeah, looks good, merge approved :) -- Brian Dolbec dolsen

Re: [gentoo-dev] First release of Gentoo Keys

2015-01-11 Thread Brian Dolbec
://bugs.gentoo.org/ [3] https://wiki.gentoo.org/wiki/Project:Gentoo-keys [4] https://wiki.gentoo.org/wiki/Project:Gentoo-keys/Fisrt-Use -- Brian Dolbec dolsen

Re: [gentoo-dev] First release of Gentoo Keys

2015-01-11 Thread Brian Dolbec
On Sun, 11 Jan 2015 12:06:18 -0500 Rich Freeman ri...@gentoo.org wrote: On Sun, Jan 11, 2015 at 11:43 AM, Brian Dolbec dol...@gentoo.org wrote: Of the remaining devs, only 16 keys total pass the GLEP 63 requirements. More info can be found in the First-Use wiki page [4] If you

Re: [gentoo-portage-dev] [PATCH] dispatch-conf: avoid symlink File exists error (535850)

2015-01-11 Thread Brian Dolbec
On Sun, 11 Jan 2015 17:39:23 -0800 Zac Medico zmed...@gentoo.org wrote: On 01/11/2015 05:21 PM, Brian Dolbec wrote: On Sun, 11 Jan 2015 00:49:50 -0800 Zac Medico zmed...@gentoo.org wrote: archive) @@ -285,6 +303,12 @@ def file_archive(archive, curconf, newconf, mrgconf): stat.S_ISLNK

<    1   2   3   4   5   6   7   8   >