Re: [gentoo-dev] [PATCH 2/5] Use explicit abi_* flags to select multilib targets.

2013-01-28 Thread Michał Górny
On Sun, 27 Jan 2013 20:27:06 -0300 Alexis Ballier aball...@gentoo.org wrote: On Sun, 27 Jan 2013 23:46:06 +0100 Michał Górny mgo...@gentoo.org wrote: Alexis, Following your remark, I have redesigned the loop to use MULTILIB_ABIS list to order the ABIs. This should ensure the most

Re: [gentoo-dev] [PATCH 2/5] Use explicit abi_* flags to select multilib targets.

2013-01-27 Thread Alexis Ballier
Very nice work; +1 on everything, it seems we'll finally get serious and official multilib support after all those years. I'm looking forward to get this in three :) On Sat, 26 Jan 2013 23:08:13 +0100 Michał Górny mgo...@gentoo.org wrote: [...] # @FUNCTION: multilib_get_enabled_abis #

Re: [gentoo-dev] [PATCH 2/5] Use explicit abi_* flags to select multilib targets.

2013-01-27 Thread Michał Górny
On Sun, 27 Jan 2013 09:34:13 -0300 Alexis Ballier aball...@gentoo.org wrote: Very nice work; +1 on everything, it seems we'll finally get serious and official multilib support after all those years. I'm looking forward to get this in three :) I am writing some kind of spec/summary right now.

Re: [gentoo-dev] [PATCH 2/5] Use explicit abi_* flags to select multilib targets.

2013-01-27 Thread Michał Górny
Alexis, Following your remark, I have redesigned the loop to use MULTILIB_ABIS list to order the ABIs. This should ensure the most valid replacement order. Additionally, I have added an assertion to ensure that DEFAULT_ABI comes last in MULTILIB_ABIS list.

Re: [gentoo-dev] [PATCH 2/5] Use explicit abi_* flags to select multilib targets.

2013-01-27 Thread Alexis Ballier
On Sun, 27 Jan 2013 23:46:06 +0100 Michał Górny mgo...@gentoo.org wrote: Alexis, Following your remark, I have redesigned the loop to use MULTILIB_ABIS list to order the ABIs. This should ensure the most valid replacement order. Great, that's better than what I had thought about

[gentoo-dev] [PATCH 2/5] Use explicit abi_* flags to select multilib targets.

2013-01-26 Thread Michał Górny
This time, following suggestions from Alexis Ballier, the complete list of USE flags and corresponding ABIs is stored in a single variable. I have removed the arch hack and all selected ABIs are validated against $(get_all_abis) from multilib.eclass. --- gx86/eclass/multilib-build.eclass | 36