Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in

2021-04-01 Thread Sam James
> On 31 Mar 2021, at 10:09, Ulrich Mueller wrote: > >> On Wed, 31 Mar 2021, Andreas Sturmlechner wrote: > >> setup-allowed-flags() { >> +[[ ${EAPI} == [0-7] ]] || >> +die "Internal function ${FUNCNAME} is not available in >> >=EAPI-8." >> +_setup-allowed-flags >> +} >

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in

2021-04-01 Thread Andreas Sturmlechner
On Mittwoch, 31. März 2021 12:03:33 CEST Wolfgang E. Sanyer wrote: > I'm curious - why the split e.g. test-flag-PROG() and _test-flag-PROG()? Is > this stylistic, or does it serve a functional purpose? (Hah, "functional", > get it? Because they're functions?!? We prepend `_` to signify internal

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in

2021-03-31 Thread Wolfgang E. Sanyer
I'm curious - why the split e.g. test-flag-PROG() and _test-flag-PROG()? Is this stylistic, or does it serve a functional purpose? (Hah, "functional", get it? Because they're functions?!? Please excuse any formatting oddness I'm not sure how to make plaintext emails from the gmail android client

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in

2021-03-31 Thread Sergei Trofimovich
On Wed, 31 Mar 2021 09:45:52 +0200 Andreas Sturmlechner wrote: > On Mittwoch, 31. März 2021 09:33:21 CEST Sergei Trofimovich wrote: > > On Wed, 31 Mar 2021 08:39:27 +0200 > > > > > > See also: > > > https://qa-reports.gentoo.org/output/eapi-per-eclass/eutils.eclass/ > > >

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in

2021-03-31 Thread Ulrich Mueller
> On Wed, 31 Mar 2021, Andreas Sturmlechner wrote: > setup-allowed-flags() { > + [[ ${EAPI} == [0-7] ]] || > + die "Internal function ${FUNCNAME} is not available in > >=EAPI-8." > + _setup-allowed-flags > +} Strictly speaking, EAPIs are strings, so numeric comparison

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in

2021-03-31 Thread Andreas Sturmlechner
On Mittwoch, 31. März 2021 09:33:21 CEST Sergei Trofimovich wrote: > On Wed, 31 Mar 2021 08:39:27 +0200 > > > > See also: > > https://qa-reports.gentoo.org/output/eapi-per-eclass/eutils.eclass/ > > https://github.com/gentoo/gentoo/pull/20207 > > Please post series as separate patches. > They

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in

2021-03-31 Thread Sam James
> On 31 Mar 2021, at 07:39, Andreas Sturmlechner wrote: > > qa-reports showing >7300 ebuilds with EAPI-7 using eutils.eclass, that can't > be right. > > - Restrict inherit eutils to - Drop bogus multilib.eclass (inherited by toolchain-funcs.eclass anyway) > - Several functions look like

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in

2021-03-31 Thread Sergei Trofimovich
On Wed, 31 Mar 2021 08:39:27 +0200 Andreas Sturmlechner wrote: > qa-reports showing >7300 ebuilds with EAPI-7 using eutils.eclass, that can't > be right. > > - Restrict inherit eutils to - Drop bogus multilib.eclass (inherited by toolchain-funcs.eclass anyway) > - Several functions look like

[gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in

2021-03-31 Thread Andreas Sturmlechner
qa-reports showing >7300 ebuilds with EAPI-7 using eutils.eclass, that can't be right. - Restrict inherit eutils to https://qa-reports.gentoo.org/output/eapi-per-eclass/eutils.eclass/ https://github.com/gentoo/gentoo/pull/20207 diff --git a/eclass/flag-o-matic.eclass