Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-30 Thread Francesco Riosa
Il giorno lun 27 set 2021 alle ore 18:11 Mike Gilbert ha scritto: > I'm looking to solicit opinions on when it is appropriate for an > ebuild to check for kernel config options using linux-info.eclass. I > don't think we have any guidelines documented, instead leaving it up > to the "common

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-28 Thread Michael Orlitzky
On Mon, 2021-09-27 at 15:44 -0400, Mike Gilbert wrote: > On Mon, Sep 27, 2021 at 3:11 PM Peter Stuge wrote: > > > > Mike Gilbert wrote: > > > It's a waste of time and effort to pepper random ebuilds with checks > > > for options that everyone should have enabled in the first place. > > > > It's

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Peter Stuge
Mike Gilbert wrote: > > > It's a waste of time and effort to pepper random ebuilds with checks > > > for options that everyone should have enabled in the first place. > > > > It's not for you to say what everyone should have enabled in their kernel. > > Do you not agree that there are some

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Mike Gilbert
On Mon, Sep 27, 2021 at 4:28 PM Jason A. Donenfeld wrote: > > On Mon, Sep 27, 2021 at 11:44 AM Robin H. Johnson wrote: > > I think we need to strip out a lot of the crap about trying to detect > > things in the stuff being built, and reduce the check to the simplest > > possible form: > > $ time

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Jason A. Donenfeld
On Mon, Sep 27, 2021 at 11:44 AM Robin H. Johnson wrote: > I think we need to strip out a lot of the crap about trying to detect > things in the stuff being built, and reduce the check to the simplest > possible form: > $ time zgrep -w CONFIG_PACKET /proc/config.gz > CONFIG_PACKET=y The results

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Mike Gilbert
On Mon, Sep 27, 2021 at 3:11 PM Peter Stuge wrote: > > Mike Gilbert wrote: > > It's a waste of time and effort to pepper random ebuilds with checks > > for options that everyone should have enabled in the first place. > > It's not for you to say what everyone should have enabled in their kernel.

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Peter Stuge
Mike Gilbert wrote: > It's a waste of time and effort to pepper random ebuilds with checks > for options that everyone should have enabled in the first place. It's not for you to say what everyone should have enabled in their kernel. There's significant value in ebuilds documenting required

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Mike Gilbert
On Mon, Sep 27, 2021 at 1:56 PM Rich Freeman wrote: > > On Mon, Sep 27, 2021 at 1:44 PM Robin H. Johnson wrote: > > > > I think we need to strip out a lot of the crap about trying to detect > > things in the stuff being built, and reduce the check to the simplest > > possible form: > > $ time

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Mike Gilbert
On Mon, Sep 27, 2021 at 12:23 PM Mike Pagano wrote: > > On 9/27/21 12:10 PM, Mike Gilbert wrote: > > I'm looking to solicit opinions on when it is appropriate for an > > ebuild to check for kernel config options using linux-info.eclass. I > > don't think we have any guidelines documented, instead

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Mike Pagano
On 9/27/21 2:15 PM, Mike Gilbert wrote: On Mon, Sep 27, 2021 at 1:44 PM Robin H. Johnson wrote: On Mon, Sep 27, 2021 at 01:15:10PM -0400, Mike Gilbert wrote: On Mon, Sep 27, 2021 at 12:23 PM Mike Pagano wrote: Adding linux-info calls to pkg_pretend or pkg_setup causes slowdowns when

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Mike Gilbert
On Mon, Sep 27, 2021 at 1:44 PM Robin H. Johnson wrote: > > On Mon, Sep 27, 2021 at 01:15:10PM -0400, Mike Gilbert wrote: > > On Mon, Sep 27, 2021 at 12:23 PM Mike Pagano wrote: > > > > Adding linux-info calls to pkg_pretend or pkg_setup causes slowdowns > > > > when running emerge, so we should

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Rich Freeman
On Mon, Sep 27, 2021 at 1:44 PM Robin H. Johnson wrote: > > I think we need to strip out a lot of the crap about trying to detect > things in the stuff being built, and reduce the check to the simplest > possible form: > $ time zgrep -w CONFIG_PACKET /proc/config.gz > CONFIG_PACKET=y > Sure,

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Robin H. Johnson
On Mon, Sep 27, 2021 at 01:15:10PM -0400, Mike Gilbert wrote: > On Mon, Sep 27, 2021 at 12:23 PM Mike Pagano wrote: > > > Adding linux-info calls to pkg_pretend or pkg_setup causes slowdowns > > > when running emerge, so we should do so only when there is a > > > compensating benefit. > > > > Is

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Mike Gilbert
On Mon, Sep 27, 2021 at 12:23 PM Mike Pagano wrote: > > Adding linux-info calls to pkg_pretend or pkg_setup causes slowdowns > > when running emerge, so we should do so only when there is a > > compensating benefit. > > Is this a significant slowdown? Do you have any numbers? Adding a check for

Re: [gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Mike Pagano
On 9/27/21 12:10 PM, Mike Gilbert wrote: I'm looking to solicit opinions on when it is appropriate for an ebuild to check for kernel config options using linux-info.eclass. I don't think we have any guidelines documented, instead leaving it up to the "common sense" of package maintainers.

[gentoo-dev] Guidance on adding kernel config checks to ebuilds

2021-09-27 Thread Mike Gilbert
I'm looking to solicit opinions on when it is appropriate for an ebuild to check for kernel config options using linux-info.eclass. I don't think we have any guidelines documented, instead leaving it up to the "common sense" of package maintainers. Adding linux-info calls to pkg_pretend or