Re: [gentoo-dev] RFC: ban cmake-utils_use_* in EAPI 6

2015-11-19 Thread agentsmith
On 11/18/2015 01:53 PM, Michael Palimaka wrote: What do you think? +1

Re: [gentoo-dev] RFC: ban cmake-utils_use_* in EAPI 6

2015-11-18 Thread Mike Gilbert
On Wed, Nov 18, 2015 at 10:23 AM, Brian Dolbec wrote: > On Wed, 18 Nov 2015 12:02:15 +0100 > Alexis Ballier wrote: > >> On Wed, 18 Nov 2015 21:53:17 +1100 >> Michael Palimaka wrote: >> >> > What do you think? >> >> >> +1 >> >> even

Re: [gentoo-dev] RFC: ban cmake-utils_use_* in EAPI 6

2015-11-18 Thread Michał Górny
On Wed, 18 Nov 2015 07:23:55 -0800 Brian Dolbec wrote: > On Wed, 18 Nov 2015 12:02:15 +0100 > Alexis Ballier wrote: > > > On Wed, 18 Nov 2015 21:53:17 +1100 > > Michael Palimaka wrote: > > > > > What do you think? > > > >

Re: [gentoo-dev] RFC: ban cmake-utils_use_* in EAPI 6

2015-11-18 Thread Davide Pesavento
On Wed, Nov 18, 2015 at 11:53 AM, Michael Palimaka wrote: [...] > > What do you think? +1 for banning them. Thanks, Davide

Re: [gentoo-dev] RFC: ban cmake-utils_use_* in EAPI 6

2015-11-18 Thread Brian Dolbec
On Wed, 18 Nov 2015 12:02:15 +0100 Alexis Ballier wrote: > On Wed, 18 Nov 2015 21:53:17 +1100 > Michael Palimaka wrote: > > > What do you think? > > > +1 > > even if I sometimes use those cmake-utils_use*, they tend to confuse > me and find

Re: [gentoo-dev] RFC: ban cmake-utils_use_* in EAPI 6

2015-11-18 Thread Brian Dolbec
On Wed, 18 Nov 2015 11:47:35 -0500 Mike Gilbert wrote: > On Wed, Nov 18, 2015 at 10:23 AM, Brian Dolbec > wrote: > > On Wed, 18 Nov 2015 12:02:15 +0100 > > Alexis Ballier wrote: > > > >> On Wed, 18 Nov 2015 21:53:17 +1100 > >>

[gentoo-dev] RFC: ban cmake-utils_use_* in EAPI 6

2015-11-18 Thread Michael Palimaka
cmake-utils.eclass currently defines 10 helper functions to assist in configuring packages. For example: local mycmakeargs=( $(cmake-utils_use_with foo LibFoo) ) which outputs -DWITH_LibFoo=ON or OFF Most of these helpers were introduced before, and could be replaced by, usex: local

Re: [gentoo-dev] RFC: ban cmake-utils_use_* in EAPI 6

2015-11-18 Thread Alexis Ballier
On Wed, 18 Nov 2015 21:53:17 +1100 Michael Palimaka wrote: > What do you think? +1 even if I sometimes use those cmake-utils_use*, they tend to confuse me and find -DABCD=$(usex ...) much easier to understand for the occasional user of cmake-utils.eclass.

Re: [gentoo-dev] RFC: ban cmake-utils_use_* in EAPI 6

2015-11-18 Thread Jason Zaman
On Wed, Nov 18, 2015 at 09:53:17PM +1100, Michael Palimaka wrote: > $(cmake-utils_use_with foo LibFoo) > -DWITH_LibFoo=$(usex foo) > > What do you think? Do it! I have no idea what the cmake one is supposed to do without reading docs. The usex one is really obvious.