Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-17 Thread Sebastian Luther
Am 16.01.2014 01:07, schrieb Tom Wijsman: + +archive_formats_eapi_3_to_5 = { + \.tar.xz:app-arch/tar, + \.xz:app-arch/xz-utils, Shouldn't .tar.xz require both tar and xz-utils? Other entries may have the same problem.

Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-17 Thread Sebastian Luther
Am 16.01.2014 22:40, schrieb Tom Wijsman: On Thu, 16 Jan 2014 08:03:03 +0100 Sebastian Luther sebastianlut...@gmx.de wrote: Am 16.01.2014 01:07, schrieb Tom Wijsman: --- bin/repoman | 53 + man/repoman.1 | 4 2 files changed, 57

[gentoo-portage-dev] [PATCH 2/3 v2] Have repoman check that a package directory contains at least one ebuild (bug #245305).

2014-01-17 Thread Tom Wijsman
--- bin/repoman | 8 man/repoman.1 | 3 +++ 2 files changed, 11 insertions(+) diff --git a/bin/repoman b/bin/repoman index d1542e9..44f3d3d 100755 --- a/bin/repoman +++ b/bin/repoman @@ -326,6 +326,7 @@ qahelp = { SRC_URI.mirror: A uri listed in profiles/thirdpartymirrors is

Re: [gentoo-portage-dev] [PATCH 2/3 v2] Have repoman check that a package directory contains at least one ebuild (bug #245305).

2014-01-17 Thread Jesus Rivero (Neurogeek)
On Fri, Jan 17, 2014 at 4:36 PM, Tom Wijsman tom...@gentoo.org wrote: --- bin/repoman | 8 man/repoman.1 | 3 +++ 2 files changed, 11 insertions(+) diff --git a/bin/repoman b/bin/repoman index d1542e9..44f3d3d 100755 --- a/bin/repoman +++ b/bin/repoman @@ -326,6 +326,7 @@

Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-17 Thread Tom Wijsman
On Fri, 17 Jan 2014 09:35:58 +0100 Sebastian Luther sebastianlut...@gmx.de wrote: The if entry not in system_set_atoms line. You're using __contains__ there (with the 'in'). You don't use the additional magic provided by PackageSet (which is a super class of PackagesSystemSet). This is

[gentoo-portage-dev] When must we write tests, when is it optional?

2014-01-17 Thread Tom Wijsman
Hello Looking back on the repoman patches from both me and creffett, we haven't written tests; it's on my plan to still do that, if possible. This makes me wonder: Should writing tests be a requirement? When? -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address :

Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-17 Thread Sebastian Luther
Am 18.01.2014 00:00, schrieb Tom Wijsman: On Fri, 17 Jan 2014 09:35:58 +0100 Sebastian Luther sebastianlut...@gmx.de wrote: The if entry not in system_set_atoms line. You're using __contains__ there (with the 'in'). You don't use the additional magic provided by PackageSet (which is a super

Re: [gentoo-portage-dev] When must we write tests, when is it optional?

2014-01-17 Thread Mike Frysinger
On Saturday 18 January 2014 01:40:04 Mike Frysinger wrote: On Friday 17 January 2014 19:10:56 Tom Wijsman wrote: Looking back on the repoman patches from both me and creffett, we haven't written tests; it's on my plan to still do that, if possible. This makes me wonder: Should writing