Re: [Geoserver-devel] build.geoserver geoserver-main-app-schema-online job maintenance / discussion.

2024-07-09 Thread Niels Charlier via Geoserver-devel
pp schema installation instructions? No... I How do you run the tests locally... -- Jody Garnett On Jul 8, 2024 at 5:29:42 AM, Niels Charlier wrote: Hello Jody I have always run those tests locally whenever making changes that affect app-schema, not sure about Jenkins issues. Kind Regards Niels

Re: [Geoserver-devel] build.geoserver geoserver-main-app-schema-online job maintenance / discussion.

2024-07-08 Thread Niels Charlier via Geoserver-devel
Hello Jody I have always run those tests locally whenever making changes that affect app-schema, not sure about Jenkins issues. Kind Regards Niels On 06/07/2024 00:43, Jody Garnett wrote: I have a PR that looks at some gaps in the GeoTools

[Geoserver-devel] Hibernate version

2024-02-19 Thread Niels Charlier via Geoserver-devel
Hello,Currently, the managed version of Hibernate is 3.6.9. This version is rather ancient, from 2011.  It is used by one extension: geofence-server; and one community module: monitor-hibernate.Taskmanager, a community module that I maintain, uses a more recent version of hibernate: 5.3.20. This

Re: [Geoserver-devel] Upcoming 2.25-RC Release candidate planning

2024-02-19 Thread Niels Charlier via Geoserver-devel
Hi Gabe, I added more information in the pull request. Kind Regards Niels On 16/02/2024 15:36, Gabriel Roldan wrote: Hi, I do want to get involved in the ResourceStore API discussion. Unfortunately, I'll be on vacation next week, so if you don't mind I propose we leave it off from this

Re: [Geoserver-devel] Upcoming 2.25-RC Release candidate planning

2024-02-17 Thread Niels Charlier via Geoserver-devel
if we can work out a compromise. -- Jody Garnett On Feb 16, 2024 at 6:49:35 AM, Niels Charlier via Geoserver-devel wrote: Hello Gabe, Okay, I will do that. I wish I had done it earlier actually, because it would have helped me remember the details which are already fading :) Regards

Re: [Geoserver-devel] Upcoming 2.25-RC Release candidate planning

2024-02-16 Thread Niels Charlier via Geoserver-devel
Hello Gabe, Okay, I will do that. I wish I had done it earlier actually, because it would have helped me remember the details which are already fading :) Regards Niels On 16/02/2024 15:36, Gabriel Roldan wrote: Hi, I do want to get involved in the ResourceStore API discussion.

Re: [Geoserver-devel] Random failure in gs-metadata keeps on breaking builds...

2023-12-01 Thread Niels Charlier via Geoserver-devel
Hello Andrea, You are right on both accounts; that stacktrace should not pollute the output. The other error indeed... shouldn't happen. The spring test runner does not change the behavior of the order of before calls. I cannot find any information on this happening to other people, and the

Re: [Geoserver-devel] reviews pull requests metadata and csw

2023-10-08 Thread Niels Charlier via Geoserver-devel
. -- Jody Garnett On Oct 5, 2023 at 5:51:26 AM, Niels Charlier via Geoserver-devel wrote: Hello, I have two pull requests for metadata and csw extensions: https://github.com/geoserver/geoserver/pull/7072 https://github.com/geoserver/geoserver/pull/7073 Is anyone able/willing to review them

[Geoserver-devel] reviews pull requests metadata and csw

2023-10-05 Thread Niels Charlier via Geoserver-devel
Hello,I have two pull requests for metadata and csw extensions:https://github.com/geoserver/geoserver/pull/7072https://github.com/geoserver/geoserver/pull/7073Is anyone able/willing to review them?@Andrea, you have already commented on both of them, and I addressed your remarks. I absolutely do

Re: [Geoserver-devel] Paths utility class

2023-09-13 Thread Niels Charlier via Geoserver-devel
arified. Niels I am not understanding why you wish paths to be different? Each opportunity to convert between paths produced problems in our codebase that we are seeking to resolve by being strict? What am I missing … On Wed, Sep 13, 2023 at 5:30 AM Niels Charlier wrote: Hello Jody and Gabrie

Re: [Geoserver-devel] Paths utility class

2023-09-13 Thread Niels Charlier via Geoserver-devel
Hello Jody and Gabriel, Sorry for my late response. I have a suggestion to resolve the issue, please let me know what you think, My suggestion is that I would make a pull request with the following proposed changes, and you would review it. 1. The methods Resources.fromPath as well as

[Geoserver-devel] [JIRA] (GEOS-11101) metadata: multiple tabs

2023-08-13 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiY2QwMjA0NTE2MmRmNDI2NGIzZGM4MDI1M2JkZTYyYWYiLCJwIjoiaiJ9 ) / New

[Geoserver-devel] [JIRA] (GEOS-11096) csw: support multiple mappings

2023-08-07 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZThjOTYwNDJkZjkzNDlmZDg3MTU3ODdiM2EwYjkzOTkiLCJwIjoiaiJ9 ) / New

Re: [Geoserver-devel] ResourceStore API workparty

2023-08-04 Thread Niels Charlier via Geoserver-devel
Jody, My apologies if I sound or have sounded agitated in this discussion. I do hope we find a solution. Thanks for the analysis I believe we are now working on the same problem: clarifying api design Yes, I share your goal but we don't seem to find a way to agree? I have done a proposal

Re: [Geoserver-devel] ResourceStore API workparty

2023-08-03 Thread Niels Charlier via Geoserver-devel
javadoc about it. Unless this is rolled back, we may as well delete the 'jdbcstore' module and give up entirely on the resource API. If that is the chose direction, fine, it is not up to me, but then be clear about it. Kind Regards Niels On 03/08/2023 08:46, Niels Charlier via Geoser

Re: [Geoserver-devel] ResourceStore API workparty

2023-08-03 Thread Niels Charlier via Geoserver-devel
Store API, and I am asking you to consider the application as a whole. We do have paths in the application including absolute paths. The QA activity to check that these are handled correctly is the work. Paths are not only for ResourceStore. Jody On Tue, Aug 1, 2023 at 11:55 PM Niels Charlier wrote:

Re: [Geoserver-devel] ResourceStore API workparty

2023-08-03 Thread Niels Charlier via Geoserver-devel
rnett wrote: Niels: Comments inline -- Jody Garnett On Aug 2, 2023 at 12:20:43 PM, Niels Charlier wrote: Hi Jody, I do support checking everything is handled correctly. Thanks Niels, sorry I am a bit frustrated these days so am probably not explaining clearly. I just don't seem the

Re: [Geoserver-devel] ResourceStore API workparty

2023-08-02 Thread Niels Charlier via Geoserver-devel
andled correctly is the work. Paths are not only for ResourceStore. Jody On Tue, Aug 1, 2023 at 11:55 PM Niels Charlier wrote: Hello Jody, Unfortunately I am not really on board with your plan. I really don't think we need to make a new branch and do a lot of work. This seems li

Re: [Geoserver-devel] ResourceStore API workparty

2023-08-02 Thread Niels Charlier via Geoserver-devel
Hello Jody, Unfortunately I am not really on board with your plan. I really don't think we need to make a new branch and do a lot of work. This seems like a lot of unnecessary work. I think the original design is fine, and does not require breaking the code base. We just need to go back to

Re: [Geoserver-devel] changes to ResourceStore

2023-08-02 Thread Niels Charlier via Geoserver-devel
file system. - absolute: process as File. If needed for a test case or something there is a wrapper that can pretend a random File location is a resource. Jody On Mon, Jul 31, 2023 at 4:23 AM Niels Charlier wrote: Hello Jody, I have been looking into this, but I do not think that throw

Re: [Geoserver-devel] changes to ResourceStore

2023-07-31 Thread Niels Charlier via Geoserver-devel
ation a very clear sentence about resource store not supporting absolute paths. Jody On Fri, Jul 21, 2023 at 4:01 AM Niels Charlier wrote: Hey Jody, How do we proceed practically? I am happy to make a PR to fix resource store and make the agreed upon core changes.

[Geoserver-devel] [JIRA] (GEOS-11086) Taskmanager: database access improvements

2023-07-31 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiOWUyODVkOWEyMzVlNDMzNmFlZDcyNjViNmI1YzBlODQiLCJwIjoiaiJ9

[Geoserver-devel] [JIRA] (GEOS-11082) Taskmanager: support for keycloak

2023-07-24 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZjU4ZGUzZjAwZTU3NGY1MzgyYmZmYjk1OWU1MGIwMDEiLCJwIjoiaiJ9

Re: [Geoserver-devel] changes to ResourceStore

2023-07-21 Thread Niels Charlier via Geoserver-devel
the code to march. On Thu, Jul 13, 2023 at 1:42 AM Niels Charlier wrote: In theory I agree but there is always a risk to changing lenient behavior to throwing exceptions, if there is code or production configs that have relied on paths starting with '/' just passing as relative

[Geoserver-devel] [JIRA] (GEOS-11078) DefaultCatalogFacade.list throws NPE when trying to sort on path with maps

2023-07-18 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZGU2NDA5OGRhMzdhNDRiM2ExZWUwMDYxZDhjY2ZkOTEiLCJwIjoiaiJ9 ) / Bug

Re: [Geoserver-devel] changes to ResourceStore

2023-07-13 Thread Niels Charlier via Geoserver-devel
? -- Jody Garnett On Jul 9, 2023 at 10:53:22 PM, Niels Charlier wrote: Hello Jody, My comment about deprecating the file() was in response to what Gabriel said about that. Resource: urls are indeed for instance supported by SLD, if you want to link to a resource inside your data directory

[Geoserver-devel] [JIRA] (GEOS-11073) csw: add "url.base" property

2023-07-13 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZGE3MjRmM2Y3ZmQ0NDJmZWIyNTYxNjc3OTFmNDYxNmEiLCJwIjoiaiJ9

Re: [Geoserver-devel] changes to ResourceStore

2023-07-09 Thread Niels Charlier via Geoserver-devel
configuration.  I guess we could talk resource: URL here in the developers docs explicitly. Do we know who wrote that (I hope it was not me). Still let's take this discussion and update the docs and API. -- Jody Garnett On Jul 5, 2023 at 11:48:50 PM, Niels Charlier wrote: Hello Gabriel

Re: [Geoserver-devel] changes to ResourceStore

2023-07-06 Thread Niels Charlier via Geoserver-devel
eady to adhere to lax interface contracts (catalog's default workspace hello) as to keep on making it more and more difficult. So what do we do? can we get to an agreement that the contract in the interfaces is mandatory and work from there? cheers, On Tue, 4 Jul 2023 at 17:49,

Re: [Geoserver-devel] changes to ResourceStore

2023-07-04 Thread Niels Charlier via Geoserver-devel
had drifted away from the intended use over time. Now that you are present in the discussion it would be a good opportunity to discuss this with the parties involved. -- Jody Garnett On Jul 3, 2023 at 2:50:02 PM, Niels Charlier wrote: Hello Jody and others, I am having trouble understanding

[Geoserver-devel] changes to ResourceStore

2023-07-03 Thread Niels Charlier via Geoserver-devel
Hello Jody and others, I am having trouble understanding the changes that were made about 6 months ago to the ResourceStore's expected behaviour. In particular, in the class 'org.geoserver.platform.resource.ResourceTheoryTest', the unit test 'theoryRootSlashIsIgnored' was replaced by

[Geoserver-devel] [JIRA] (GEOS-11050) jdbc-store broken by changes to Paths.names

2023-07-03 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMzUwY2JlYzcxYzQwNGUxMWIxMTJiYWUxMmY3ZmIwYzciLCJwIjoiaiJ9 ) / Bug

Re: [Geoserver-devel] gs-metadata breaking build

2023-06-29 Thread Niels Charlier via Geoserver-devel
It should normally be fixed now if the build is re-run. On 29/06/2023 14:44, Jody Garnett wrote: A number of PRs are "blocked" by gs-metadata failing on GitHub actions environment. As this is a recent difficulty is it possible to revert changes to restore build stability? Or turn off tests

Re: [Geoserver-devel] GeoTools / GeoServer PMC meeting - 2023-06-20

2023-06-27 Thread Niels Charlier via Geoserver-devel
Niels Charlier via Geoserver-devel wrote: Andrea, Any tips on how to reproduce the failure locally ? I have not been able to do that. I tried -T6 and java 11. Regards Niels On 20/06/2023 19:16, Torben Barsballe wrote: Attending * Torben

Re: [Geoserver-devel] GeoTools / GeoServer PMC meeting - 2023-06-20

2023-06-22 Thread Niels Charlier via Geoserver-devel
Andrea, Any tips on how to reproduce the failure locally ? I have not been able to do that. I tried -T6 and java 11. Regards Niels On 20/06/2023 19:16, Torben Barsballe wrote: Attending * Torben Barsballe * Andrea Aime * Kevin Smith * Jukka Rahkonen

[Geoserver-devel] [JIRA] (GEOS-11024) metadata: add datetime field type to feature catalog

2023-06-12 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZTRmNDRjMzNmNWJhNDg1NDkwYjg1YmI5NGUxZjRhYTciLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-11022) Taskmanager: isolated workspace support

2023-06-09 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiYTZmNzRkZGZhMzY5NDc2OGI1MDUzNTQ4MTcxMTZjMzgiLCJwIjoiaiJ9 ) / Task

[Geoserver-devel] [JIRA] (GEOS-10979) metadata: crashes on missing properties file

2023-05-15 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiODkxMGU4N2IyNGE3NGFkMThkMzI2YWNhOWI0YTU1NWYiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-10968) Taskmanager: fix java 11 failure

2023-05-08 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiYzdmMDQ0MjY2Mjk1NDA1NjljZjc5NzE1NWY1YzE0ZTkiLCJwIjoiaiJ9 ) / Task

[Geoserver-devel] [JIRA] (GEOS-10932) csw-iso: should only add 'xsi:nil = false' attribute

2023-04-10 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiYTMyMDQ3NDY2YmIzNGM2Y2IwMzJiMThkYTkxNmM4NjkiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-10931) Taskmanager: db access improvements

2023-04-10 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNTVmM2QwMjM2MDZhNGY4YTgzMzI4MDJhZGU3M2ViMmYiLCJwIjoiaiJ9 ) / Task

[Geoserver-devel] [JIRA] (GEOS-10930) taskmanager: isolated workspace support

2023-04-10 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiOGU3MzMwOGFjOGIxNDQ5OTg2MWY1NGM1YWM0MmMwMDMiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-10929) isolated workspace may cause broken links between catalog objects

2023-04-10 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiODRhNThhMjZjYTE0NGNkMDgwNGY1NjViMGI2MTUzMDciLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-10859) OGC API: swagger-api upgrade for security vulnerability

2023-02-10 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNDE4YmQzNTdhNTkyNDJlMGIxNGFlMzk4Mzc5OWYwZGUiLCJwIjoiaiJ9 ) / Task

[Geoserver-devel] [JIRA] (GEOS-10858) jdbc-config turns off isolated workspace support

2023-02-10 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiN2FkNTA2MGJkZTQxNGVjYjgzYzU4Y2JiYzM2MTgwYWQiLCJwIjoiaiJ9

[Geoserver-devel] [JIRA] (GEOS-10843) keycloak: improve support logging out

2023-01-27 Thread Niels Charlier (JIRA) via Geoserver-devel
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiOTllYjIyZmVmYmM1NGYxMDg5YWU4ODA0NTRkNzYzZmIiLCJwIjoiaiJ9

[Geoserver-devel] [JIRA] (GEOS-10802) CLONE - OGC API: queryables page crashed on complex features

2022-12-19 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMTFhNDExYmYwNmU4NDJhOGEzN2IyMmZkODc2OWJjZTUiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-10801) Taskmanager start-up keeps a very long transaction - causing time-out

2022-12-19 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiYWM5NzlhYzUwZjQ3NDFlZjlhZDdkYmE2ZjIzZTRmYWUiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-10800) Taskmanager should sync all metadata when remotely publish a layer.

2022-12-19 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiN2YyMThkZDBlYjljNGY4OThkNzZmY2EwNTEwOTA3YjIiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-10799) Taskmanager: clean-up of configuration removes datastore which still contains layers

2022-12-19 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMGYyZGZhOTBjOTdhNDk1Y2EyNDcxYzk3ODY0NjEwNDQiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-10795) csw-iso: support custom queryable mappings + bounding box

2022-12-15 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMTIyYzFhNzVkNDE0NDY5NGE1ZTczY2RmMWNlOTU2ZjMiLCJwIjoiaiJ9

[Geoserver-devel] [JIRA] (GEOS-10726) OGC API: html pages missing content type/encodign header

2022-10-27 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMjkxYzM3MDM4YzRkNDExYmIwMmVhYzQ1NDlkZTUxZDIiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-10719) app-schema GetFeature numberMatched breaks with views/tables without PK (test)

2022-10-22 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiOTRmYWYzZTg3N2Q5NDRhOGJlNGI2NDE1ZmQ2YjBkMzciLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-10654) app-schema GetFeature numberMatched fails with ID filter (test)

2022-09-16 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNGNiMDcxMTMzZTNjNDdjNDliMDExMjcxNjBhMzY2YTIiLCJwIjoiaiJ9 ) / Bug

Re: [Geoserver-devel] app-schema numberMatched regression

2022-09-14 Thread Niels Charlier via Geoserver-devel
width= <http://www.avg.com/email-signature?utm_medium=email_source=link_campaign=sig-email_content=webmail> Privo di virus.www.avg.com <http://www.avg.com/email-signature?utm_medium=email_source=link_campaign=sig-email_content=webmail> On Mon, Sep 12, 2022 at 10:19 AM Nie

[Geoserver-devel] app-schema numberMatched regression

2022-09-12 Thread Niels Charlier via Geoserver-devel
Hello everyone, I found a bug in app-schema that was recently introduced by https://osgeo-org.atlassian.net/browse/GEOT-7214, a patch by Marco Volpini, but I am a bit confused about the changes and would like to know to what extent they are intentional. Bug logged at:

[Geoserver-devel] [JIRA] (GEOS-10524) CLONE - promote gs-metadata to extension (GSIP 212))

2022-06-02 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZmE0NzgzZTlkZWM4NDc2Njk0ZWZiMDUzYWI0YzE5OGEiLCJwIjoiaiJ9

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-05-16 Thread Niels Charlier via Geoserver-devel
/wiki/GSIP-211 -- Jody Garnett On May 10, 2022 at 11:56:28 AM, Niels Charlier wrote: On 10/05/2022 11:24, Andrea Aime wrote: "found code" is for code that is license compatible, but for which we have no CLA on record, meaning we cannot mix it with other code that might be dona

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-05-10 Thread Niels Charlier via Geoserver-devel
On 10/05/2022 11:24, Andrea Aime wrote: "found code" is for code that is license compatible, but for which we have no CLA on record, meaning we cannot mix it with other code that might be donated back to GeoTools or otherwise relicensed at a later stage. So the module needs to be labelled and

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-05-10 Thread Niels Charlier via Geoserver-devel
t;found code" I cited previously: https://github.com/geoserver/geoserver/wiki/GSIP-186 Cheers Andrea On Tue, Apr 26, 2022 at 7:49 AM Niels Charlier wrote: Hi Jody, it was written by me who signed the CLA. Kind Regards Niels On 25/04/2022 18:27, Jody Garnett wrote:

Re: [Geoserver-devel] Geoserver 2.21-RC ready, available for testing, release notes for review

2022-05-09 Thread Niels Charlier via Geoserver-devel
Hi Thanks Jody, But we're still blocked with the metadata module, they both need to be promoted so I might as well wait for the next version. Kind Regards Niels On 08/05/2022 07:44, Jody Garnett wrote: The GeoServer 2.21-RC release candidate is ready and available for download here

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-04-29 Thread Niels Charlier via Geoserver-devel
was copied on written by others … On Sun, Apr 24, 2022 at 9:09 PM Niels Charlier wrote: Hi, The code is not released under a different license. I contributed it under the CLA, which I signed. The question is only if it is necessary for the organization who paid for the wo

Re: [Geoserver-devel] Problems building GeoServer documentation

2022-04-27 Thread Niels Charlier via Geoserver-devel
/geocat-themes/blob/master/README.md Cheers Andrea On Wed, Apr 27, 2022 at 7:42 AM Niels Charlier wrote: Hi Jody, I get the error after cleaning, I also get it without any changes (on an updated and untouched main branch). Note that the error is: [exec] Theme error

Re: [Geoserver-devel] Problems building GeoServer documentation

2022-04-26 Thread Niels Charlier via Geoserver-devel
e changes. As indicated this is sometimes an issue with parent / child relationships. Jody On Tue, Apr 26, 2022 at 12:27 AM Niels Charlier via Geoserver-devel wrote: Hello Ian, Yes, I get the same error from sphinx as Andrea did back then. Kind Regards Niels On 26/04/2022

Re: [Geoserver-devel] Problems building GeoServer documentation

2022-04-26 Thread Niels Charlier via Geoserver-devel
Hello Ian, Yes, I get the same error from sphinx as Andrea did  back then. Kind Regards Niels On 26/04/2022 12:18, Ian Turton wrote: I just go to docs/en and do mvn install - do you have sphinx installed? Ian On Tue, 26 Apr 2022 at 11:11, Niels Charlier via Geoserver-devel wrote

Re: [Geoserver-devel] Problems building GeoServer documentation

2022-04-26 Thread Niels Charlier via Geoserver-devel
Andrea, I keep having this issue. What do you mean exactly with the instructions on the GeoCat site? I cannot resolve it. Kind Regards Niels On 13/10/2021 09:42, Andrea Aime wrote: Hi Jody, I just followed the instructions on the GeoCat site and then, it built. No changes in the docs.

[Geoserver-devel] [JIRA] (GEOS-10472) promote gs-csw-iso to extension (GSIP 211)

2022-04-26 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZjA0MjZkMDc2N2UzNGE3ZjlhYmI0ZDc2YjBjZWZjMGEiLCJwIjoiaiJ9

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-04-25 Thread Niels Charlier via Geoserver-devel
was always developed in the shared repo by folks that have signed the CLA? Or is their code that was copied on written by others … On Sun, Apr 24, 2022 at 9:09 PM Niels Charlier wrote: Hi, The code is not released under a different license. I contributed it under the CLA, which I

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-04-25 Thread Niels Charlier via Geoserver-devel
Niels Charlier wrote: I understood from Jody that nothing per se had to happen ("you should be good"). perhaps I misunderstood? Kind Regards Niels On 24/04/2022 09:56, Andrea Aime wrote: That said... while Jody did not vote, his CLA feedback is valid. We

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-04-24 Thread Niels Charlier via Geoserver-devel
s has been addressed and any “-1” voters have changed their votes) Considering Jukka's last vote (still to be recorded in the GSIPs) I believe both proposals have passed. Cheers Andrea On Sat, Apr 23, 2022 at 3:02 PM Niels Charlier via Geoserver-devel wrote:

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-04-23 Thread Niels Charlier via Geoserver-devel
Thank you, Jukka! Can I assume then that the absent votes are +0 and that both proposals are accepted? Kind Regards Niels On 21/04/2022 12:39, Rahkonen Jukka (MML) wrote: +1 for both GSIP-311 and GSIP-312. -Jukka Rahkonen- *Lähettäjä:* Niels Charlier via Geoserver-devel *Lähetetty

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-04-21 Thread Niels Charlier via Geoserver-devel
making this Agreement with the Foundation. So a government should be able to sign it. -- Jody Garnett On Apr 4, 2022 at 4:49:08 AM, Niels Charlier via Geoserver-devel wrote: Hello, I have written up two proposals to promote community modules "metadata" and "csw-iso" to

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-04-11 Thread Niels Charlier via Geoserver-devel
, Mats.E Den mån 11 apr. 2022 kl 09:43 skrev Niels Charlier via Ge Coserver-devel : Hello Mats and Richard, Thank you for your feedback. I hear two signals from you: (1) there is demand for the functionality of these modules; (2) they are currently too hard to deploy and co

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-04-11 Thread Niels Charlier via Geoserver-devel
st regards, Mats.E Den fre 8 apr. 2022 kl 14:28 skrev Niels Charlier via Geoserver-devel <mailto:geoserver-devel@lists.sourceforge.net>>:     Hi Simone,     Thanks for your vote. Yes I am available for all questions regarding the modules and general maintenance as required or requested by t

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-04-08 Thread Niels Charlier via Geoserver-devel
an the copyright owner or legal entity authorized by the copyright owner that is making this Agreement with the Foundation. So a government should be able to sign it. -- Jody Garnett On Apr 4, 2022 at 4:49:08 AM, Niels Charlier via Geoserver-devel wrote: Hello,

Re: [Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-04-08 Thread Niels Charlier via Geoserver-devel
his Agreement with the Foundation. So a government should be able to sign it. -- Jody Garnett On Apr 4, 2022 at 4:49:08 AM, Niels Charlier via Geoserver-devel wrote: Hello, I have written up two proposals to promote community modules "metadata" and "csw-iso" to extensions. h

[Geoserver-devel] proposals: promote metadata and csw-iso to extensions

2022-04-04 Thread Niels Charlier via Geoserver-devel
Hello, I have written up two proposals to promote community modules "metadata" and "csw-iso" to extensions. https://github.com/geoserver/geoserver/wiki/GSIP-311 https://github.com/geoserver/geoserver/wiki/GSIP-312 I believe stability, test coverage, users, are all okay. Please discuss. One

[Geoserver-devel] [JIRA] (GEOS-10447) support Metadata for Services (SRV) in csw-iso

2022-04-04 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiYTM4YTk5ZGFkYjU3NDYwNDlkYWUzYTY0MjAzYTc5NDEiLCJwIjoiaiJ9

[Geoserver-devel] [JIRA] (GEOS-10403) new coverage via REST overwrites SRS and SRS handling with native srs.

2022-03-01 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNzY2MzBlNjBmZTk1NDgzNjg4YTMxODJlZTMxY2VjYTIiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-10390) Concurrency issues with SecuredResourceNameChangeListener when renaming layers simultaneously

2022-02-16 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZjM5MTE4NWFiMGQ2NGVmZTg1ODdkOTg5YjYyY2JlZDciLCJwIjoiaiJ9 ) / Bug

Re: [Geoserver-devel] srv-namespace missing in CSW-service

2022-01-05 Thread Niels Charlier via Geoserver-devel
ritten by Niels Charlier on behalf of Boundless. Boundless is no more, Niels showed no desire to get involved with user support on the free channels... As a result, nobody can give you the "5 minutes answer", the only type of answer that you'll get on this list, or on stack overflow. There a

Re: [Geoserver-devel] srv-namespace missing in CSW-service

2022-01-05 Thread Niels Charlier via Geoserver-devel
Hello Heiko, I believe the namespaces for CSW-ISO are hard coded in org.geoserver.csw.records.iso.MetaDataDescriptor, though I cannot guarantee that adding it there is all that is needed to resolve your issue. Perhaps it would be interesting making this a configurable thing. Kind Regards

Re: [Geoserver-devel] [Geotools-devel] reprojections and multiple geometries

2021-10-17 Thread Niels Charlier via Geoserver-devel
iels On 1/10/2021 09:43, Andrea Aime wrote: On Mon, Oct 11, 2021 at 7:05 PM Niels Charlier <mailto:ni...@scitus.be>> wrote: Hello Andrea, I did not mean to misrepresent you. I actually thought your suggestion made sense. The new method in the CRS class is (curre

Re: [Geoserver-devel] [Geotools-devel] reprojections and multiple geometries

2021-10-11 Thread Niels Charlier via Geoserver-devel
On Mon, Oct 11, 2021 at 3:21 PM Niels Charlier via GeoTools-Devel <mailto:geotools-de...@lists.sourceforge.net>> wrote: 2) allow reprojection 3D->2D and only prevent 2D->3D reprojection (Andrea's suggestion). Before this gets out of hand, my suggestion is limited to the CRS

Re: [Geoserver-devel] reprojections and multiple geometries

2021-10-11 Thread Niels Charlier via Geoserver-devel
easonable for the users but I wish you a good luck. -Jukka Rahkonen- -Alkuperäinen viesti- Lähettäjä: Niels Charlier via Geoserver-devel Lähetetty: lauantai 9. lokakuuta 2021 15.05 Vastaanottaja: Geotools-Devel list ; Geoserver-devel Aihe: [Geoserver-devel] reprojections and multiple geometries

[Geoserver-devel] reprojections and multiple geometries

2021-10-09 Thread Niels Charlier via Geoserver-devel
Hello Everyone, I am sending this email to both geotools and geoserver lists because the matter concerns both. I recently made a PR to improve geotools/geoserver behaviour with respect to multiple geometries that have different CRS. (https://github.com/geotools/geotools/pull/3642) One of

[Geoserver-devel] [JIRA] (GEOS-10246) jdbcconfig: performance slow-down from unnecessary transaction s

2021-09-23 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiYjZlMWQ3MTk1NzNlNGE2NThiMTA4YTg0NDllNWNkMjEiLCJwIjoiaiJ9

[Geoserver-devel] [JIRA] (GEOS-10245) jdbcconfig: prefixedName filter field not updated

2021-09-23 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZDgzNmQyNzU3NTFhNDllNWExNzBmMjRhM2JjYWUzMGUiLCJwIjoiaiJ9 ) / Bug

Re: [Geoserver-devel] powermock for unit tests in app-schema

2021-03-23 Thread Niels Charlier via Geoserver-devel
of a local mock. Cheers Andrea On Tue, Mar 9, 2021 at 11:42 AM Mark Prins mailto:mc.pr...@gmail.com>> wrote: On 08-03-2021 13:01, Niels Charlier via Geoserver-devel wrote: > Hello, > > I fixed a bug in geoserver app-schema

[Geoserver-devel] [JIRA] (GEOS-9993) wcs GetCoverage outputformat gml should return gmlcov:rangeType, not gml:rangeType

2021-03-23 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMDhjNjZiOTc0ZTI1NDZmYzkwMmFlN2I5ZDhkYmQ1ZmQiLCJwIjoiaiJ9 ) / Bug

Re: [Geoserver-devel] powermock for unit tests in app-schema

2021-03-09 Thread Niels Charlier via Geoserver-devel
be to avoid using 'final' on a class so that we can still mock those classes. Kind Regards Niels On 09/03/2021 11:40, Mark Prins wrote: On 08-03-2021 13:01, Niels Charlier via Geoserver-devel wrote: Hello, I fixed a bug in geoserver app-schema (https://github.com/geotools/geotools/pull/3367

[Geoserver-devel] powermock for unit tests in app-schema

2021-03-08 Thread Niels Charlier via Geoserver-devel
Hello, I fixed a bug in geoserver app-schema (https://github.com/geotools/geotools/pull/3367 https://osgeo-org.atlassian.net/browse/GEOT-6801). The change I made was very small (one character actually) and in one specific class. To me it seemed appropriate to write a unit test. Since it is

[Geoserver-devel] [JIRA] (GEOS-9947) csw-iso: test failures

2021-03-02 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZmVmODBiN2Y4NGRiNDhiZWE1YzI4ZjhiNGI3NTBhODYiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-9930) jdbcstore: resource contain outdated metadata

2021-02-23 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNWM3NmJjNzdmNDFmNGJkMmIwZDQwYjBmMDU4YTNjM2UiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-9929) jdbc-config: repopulate populates wrong properties

2021-02-23 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZThjNDQ3NTNhNTQ4NGU4YmJiOTY0ZmFjZmM2NzdjOWQiLCJwIjoiaiJ9 ) / Bug

Re: [Geoserver-devel] GetFeaturById storedquery - featureid convention

2020-12-07 Thread Niels Charlier via Geoserver-devel
loud. Cheers Andrea On Fri, Dec 4, 2020 at 1:00 PM Niels Charlier via Geoserver-devel <mailto:geoserver-devel@lists.sourceforge.net>> wrote: Some issues have been reported with GetFeaturById finding features, in particular with app-schema layers (see http://osgeo-or

[Geoserver-devel] GetFeaturById storedquery - featureid convention

2020-12-04 Thread Niels Charlier via Geoserver-devel
Some issues have been reported with GetFeaturById finding features, in particular with app-schema layers (see http://osgeo-org.1560.x6.nabble.com/urn-ogc-def-query-OGC-WFS-GetFeatureById-td5402041.html and

[Geoserver-devel] [JIRA] (GEOS-9798) GetFeature with Storedquery GetFeatureById returns "Could not find feature with specified id"

2020-11-21 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMjgyMzJkMDU2ODI1NGY5NDhlZmM5YzgzMmNmODE0YzYiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-9797) jdbc-config: removing workspace with service breaks geoserver

2020-11-21 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMGUwY2E3YTlmMGJhNDM2MWE5ZmU3YjRlMmI2YjcxNWMiLCJwIjoiaiJ9 ) / Bug

[Geoserver-devel] [JIRA] (GEOS-9730) WMSInfoImpl cannot be serialized any more

2020-09-08 Thread Niels Charlier (JIRA)
Niels Charlier ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf ) *created* an issue GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiZTJiMDFiODhlNzE1NDRiYTlmNTBlMWQwODFlYzExNDYiLCJwIjoiaiJ9 ) / Bug

  1   2   3   4   5   6   >