Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-11-03 Thread Jody Garnett
Comments inline: On Thu, 3 Nov 2022 at 00:16, Carsten Klein wrote: > Hello there, > > now the 2nd optimization of the new SpatialJSON format (Shared String > Table) is merged into main. Many thanks for that :-) > Must be this one https://github.com/geoserver/geoserver/pull/6320 > I have prepa

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-11-03 Thread Jody Garnett
Klien: You should be able to add the label: backport-2.22.x, and backport-2.21.x to your PR and a bot will prep two new pull requests for you. When those are merged the original Jira ticket has the "fixed for" information update to indicate additional releases where the problem is fixed (2.22.0 a

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-11-03 Thread Carsten Klein
Hello there, now the 2nd optimization of the new SpatialJSON format (Shared String Table) is merged into main. Many thanks for that :-) I have prepared two more single-commit PRs for porting back everything to 2.22.x and 2.21.x. Before pushing these into my forked repo and issuing the PRs, I

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-20 Thread Carsten Klein
See my answers inline: Am 20.10.2022 um 13:05 schrieb Andrea Aime: On Tue, Oct 18, 2022 at 7:28 AM Carsten Klein wrote: Hello Andrea, prior to porting back, I'd like to make another change. I'd like to have a context/storage to share data between methods encodeSimpleFeatures a

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-20 Thread Andrea Aime
On Tue, Oct 18, 2022 at 7:28 AM Carsten Klein wrote: > Hello Andrea, > > prior to porting back, I'd like to make another change. I'd like to have a > context/storage to share data between methods encodeSimpleFeatures and > writeExtraCollectionProperties. This is at least a requirement for > build

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-20 Thread Andrea Aime
Hi Carsten, please address the gs-devel community rather than me personally, it's better as other people can answer your question, but they won't if your message addresses me directly. That said, a new community module starts in main, that's 2.23-SNAPSHOT right now, but you'll be able to do a back

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-17 Thread Carsten Klein
Hello Andrea, prior to porting back, I'd like to make another change. I'd like to have a context/storage to share data between methods encodeSimpleFeatures and writeExtraCollectionProperties. This is at least a requirement for building and serializing a shared string table. Since there is no

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-17 Thread Carsten Klein
Andrea, you asked to created a Jira ticket for the new community module, which I did. Not sure whether /Affects version:/ 2.23-RC was actually a good idea... The module is based on 2.23-SNAPSHOT, however, 2.22 seems to be the next release, right? Cheers Carsten Am 14.10.2022 um 10:30 schrie

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-15 Thread Carsten Klein
OK, will do so :) Am 15.10.2022 um 16:35 schrieb Jody Garnett: Yes, we made folders for different languages. If you like that is an excellent single line fix you could do; there is a procedure for doing quick fixes in the doc guide. On Fri, Oct 14, 2022 at 2:12 AM Carsten Klein wrote:

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-15 Thread Jody Garnett
Yes, we made folders for different languages. If you like that is an excellent single line fix you could do; there is a procedure for doing quick fixes in the doc guide. On Fri, Oct 14, 2022 at 2:12 AM Carsten Klein wrote: > There's probably a bug in this guide: > > The build.xml is in doc/en a

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-14 Thread Carsten Klein
There's probably a bug in this guide: The build.xml is in doc/en an not in the dic/en/user. Cheers Carsten Am 14.10.2022 um 10:30 schrieb Andrea Aime: See the documentation guide: https://docs.geoserver.org/latest/en/docguide/ (you can skip the Latex part, that's needed only to generate PDFs)

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-14 Thread Andrea Aime
See the documentation guide: https://docs.geoserver.org/latest/en/docguide/ (you can skip the Latex part, that's needed only to generate PDFs) Cheers Andrea On Fri, Oct 14, 2022 at 10:12 AM Carsten Klein wrote: > Hi Andrea, > > thanks for the advice. I can now test building the zip archives. W

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-14 Thread Carsten Klein
Hi Andrea, thanks for the advice. I can now test building the zip archives. What about documentation? I'd like to test my *.rst files? Sorry for asking so much, but I did not find anything about building the docs (offline) for community modules. Tried with -Drelease but not sure whether that

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-12 Thread Andrea Aime
On Wed, Oct 12, 2022 at 10:48 AM Carsten Klein wrote: > OK, I will go for SpatialJSON. > > I will now do the following: > >- Rename all items according to SpatialJSON >- Throw an exception if the result contains complex features >- Update README.md and provide *.rst files in >doc/

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-12 Thread Carsten Klein
OK, I will go for SpatialJSON. I will now do the following: * Rename all items according to SpatialJSON * Throw an exception if the result contains complex features * Update README.md and provide *.rst files in doc/en/user/source/community/spatialjson * Provide file ext-spatialjason.xml i

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-12 Thread Andrea Aime
All the names work for me, if you like SpatialJSON go for it. Let's get this one rolling :-D Cheers Andrea On Tue, Oct 11, 2022 at 8:07 AM Carsten Klein wrote: > Hello Andrea and Jukka, > > you've seen the mail from Howard Butler. What to make out of it? He > doesn't like such "extended" format

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-10 Thread Carsten Klein
Hello Andrea and Jukka, you've seen the mail from Howard Butler. What to make out of it? He doesn't like such "extended" formats (which I do understand) but also recognizes that he's not in a position to actually do anything against it. For my mind, there are these options for the community p

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-07 Thread Carsten Klein
nhancement: WFS Simple Feature Response in new more compact JSON/JSONP format On Fri, Oct 7, 2022 at 8:45 AM Carsten Klein wrote: GeoServer's JSON is GeoJSON as its (backwards-) compatible with GeoJSON (the addition of the inofficial "crs" object does not prevent GeoJSON

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-07 Thread Rahkonen Jukka
hat happens. -Jukka Rahkonen- Lähettäjä: Andrea Aime Lähetetty: perjantai 7. lokakuuta 2022 10.57 Vastaanottaja: Carsten Klein Kopio: Rahkonen Jukka ; geoserver-devel@lists.sourceforge.net; bj...@wololo.org Aihe: Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compa

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-07 Thread Andrea Aime
On Fri, Oct 7, 2022 at 8:45 AM Carsten Klein wrote: > GeoServer's JSON is GeoJSON as > its (backwards-) compatible with GeoJSON (the addition of the inofficial > "crs" object does not prevent GeoJSON clients form reading the format). > The same is true for OGC's JSON-FG. > GeoJSON is an extensib

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-06 Thread Carsten Klein
a Rahkonen- -Alkuperäinen viesti- Lähettäjä: Carsten Klein Lähetetty: torstai 6. lokakuuta 2022 20.09 Vastaanottaja: Rahkonen Jukka ; Andrea Aime Kopio: geoserver-devel@lists.sourceforge.net; bj...@wololo.org Aihe: Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new mo

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-06 Thread Rahkonen Jukka
jä: Carsten Klein Lähetetty: torstai 6. lokakuuta 2022 20.09 Vastaanottaja: Rahkonen Jukka ; Andrea Aime Kopio: geoserver-devel@lists.sourceforge.net; bj...@wololo.org Aihe: Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format Hi Jukka, you suggest a

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-06 Thread Carsten Klein
er-devel@lists.sourceforge.net; bj...@wololo.org Aihe: Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format Hello Andrea, I've just issued a PR on GitHub. The format and community module has been renamed to "Slim GeoJSON". "Slim&qu

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-06 Thread Rahkonen Jukka
16.47 Vastaanottaja: Andrea Aime Kopio: geoserver-devel@lists.sourceforge.net; bj...@wololo.org Aihe: Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format Hello Andrea, I've just issued a PR on GitHub. The format and community module has been

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-10-06 Thread Carsten Klein
Hello Andrea, I've just issued a PR on GitHub. The format and community module has been renamed to "Slim GeoJSON". "Slim" is shorter and likely easier to pronounce than compact (together with GeoJSON). Sorry for struggling and messing around with Git. However, the final version of the PR sho

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-09-29 Thread Andrea Aime
On Thu, Sep 22, 2022 at 10:08 AM Carsten Klein wrote: > Hello there, > > the new WFS output format CompactJSON, implemented as a community > extension, is ready and works as expected. With our mentioned WFS > responses (1.000+ features, 450 columns each), compared to standard > GeoJSON, savings a

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-09-22 Thread Carsten Klein
Hello there, the new WFS output format CompactJSON, implemented as a community extension, is ready and works as expected. With our mentioned WFS responses (1.000+ features, 450 columns each), compared to standard GeoJSON, savings are between ~30% and ~70% (uncompressed) and between ~20% and ~

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-09-14 Thread Carsten Klein
Hello Mark, just wanted to ensure that the actual class responsible for writing the WFS response pops up in the logs consistently. However, that's not really a requirement so, I could as well log only the bits happening in my class with my private logger and let my parent class log in its own

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-09-14 Thread Mark Prins
On 14-09-2022 10:57, Carsten Klein wrote:     this.LOGGER = logger != null ? logger    : org.geotools.util.logging.Logging.getLogger(this.getClass()); } Also, I've changed the LOGGER variable from private to protected, in order to use it from the subclass. Don't do this, just create a p

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-09-14 Thread Carsten Klein
Hello there, now, I've managed to setup a community module project with Maven, created and Eclipse project, which I additionally linked to project 'gs-wfs', so I can make changes to the existing GeoJSON producer Andrea mentioned. After linking my new project 'gs-compactjson' to project 'gs-w

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-09-13 Thread Carsten Klein
Hi Ian and Andrea, thanks for your input and recommendations. I'll try to create a community extension (using flatgeobuf and others as a starting point / boilerplate). I'm using Eclipse and still struggling with Maven. However, things are moving... I will also have a look at the flatgeobuf f

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-09-13 Thread Andrea Aime
Agreed, it should start as a community module. Happy to review changes to make subclassing the existing GeoJSON producer easier. Or you can just copy and modify, if you like, to get prototyping moving on faster. If you are interested in a ready made compact and efficient format instead, I suggest

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-09-13 Thread Ian Turton
Sorry hit send too soon! I would also prefer it if it was an extension rather than part of the core GeoServer. Ian On Tue, 13 Sept 2022 at 12:52, Ian Turton wrote: > I would suggest calling it something other than GeoJSON since if it strays > too far from the spec clients will become confused

Re: [Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-09-13 Thread Ian Turton
I would suggest calling it something other than GeoJSON since if it strays too far from the spec clients will become confused. Ian On Tue, 13 Sept 2022 at 12:07, Carsten Klein wrote: > Hello everyone, > > I'd like to enhance WFS responses in JSON/JSONP format. In some of our > Web GIS Applicati

[Geoserver-devel] Enhancement: WFS Simple Feature Response in new more compact JSON/JSONP format

2022-09-13 Thread Carsten Klein
Hello everyone, I'd like to enhance WFS responses in JSON/JSONP format. In some of our Web GIS Applications, one may download up to several thousand Simple Features through WFS. Some Layers may have between 400 and 500 columns. Although JSON produces much smaller responses than XML/GML, such