Re: [Geotools-devel] [Geoserver-devel] Deprecating AbstractDataStore

2015-01-14 Thread Torben Barsballe
So, it turns out that Diff.NULL already exists - it was added at the same time as the Initial DiffContentState implementation, but was never used. I have updated everything to use it instead of TransactionStateDiff.NULL. I have also rebased against you latest changes - we did a good job of keeping

[Geotools-devel] MemoryDataStore migration - FeatureWriter.hasNext() issues

2015-01-14 Thread Torben Barsballe
As part of our deprecation of AbstracDataStore, I am migrating MemoryDataStore to extend ContentDataStore. While working on the test cases, I ran into some glaring inconsistencies in the implementation of FeatureWriter.hasNext(): - The javadoc for FeatureWriter.hasNext() indicates it may

Re: [Geotools-devel] TemporalConvertor bug?

2015-01-14 Thread Jody Garnett
Got no real insight here Ian. The one using a Data object does it assign a timezone? Or is assuming your current locale. I would update the test to create the Date with a known timezone before expecting consistent results. -- Jody -- Jody Garnett On 14 January 2015 at 08:32, Ian Turton

Re: [Geotools-devel] MemoryDataStore migration - FeatureWriter.hasNext() issues

2015-01-14 Thread Jody Garnett
I would mimic the interaction of a file handle and expect an IOException when trying to interact with a reader that has been closed. Given the iterator.hasNext() expectation I would expect: - hasNext() to return false if it can no upfront that no more features are available (so being closed is an

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-14 Thread Andrea Aime
On Wed, Jan 14, 2015 at 3:25 PM, Niels Charlier ni...@scitus.be wrote: Hi Sampo, Your testing is important actually, so that we can be absolutely 100% sure there is no regression with regards to your work. For WFS2.0/GML3.2 I use the geotools PullParser rather than the gt-wfs-ng's own

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-14 Thread Sampo Savolainen
Hi, As this does not (should not) touch on anything else, I think it's a candidate for including in the release. Of course there's not much time left for the freeze window. I'll test this as soon as I can. In fact, I tried to build this but I couldn't build GeoServer against your branch: [ERROR]

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-14 Thread Andrea Aime
On Wed, Jan 14, 2015 at 3:47 PM, Sampo Savolainen sampo.savolai...@spatineo.com wrote: Hi, As this does not (should not) touch on anything else, I think it's a candidate for including in the release. Of course there's not much time left for the freeze window. I'll test this as soon as I

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-14 Thread Niels Charlier
Hi Sampo, Your testing is important actually, so that we can be absolutely 100% sure there is no regression with regards to your work. For WFS2.0/GML3.2 I use the geotools PullParser rather than the gt-wfs-ng's own internal parser. I think ideally we should get rid of the internal parser

[Geotools-devel] TemporalConvertor bug?

2015-01-14 Thread Ian Turton
While messing with SQLServer I've hit an issue with one of the date tests failing. It passes on master even though the same issue is present in the convertor. So I'm unsure as to what I'm doing wrong - if you consider this test (that could be added to TemporalConvertorFactoryTest in main

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-14 Thread Sampo Savolainen
Hi, This is really good timing. We just noticed some issues regarding GML feature parsing when using my cascaded stored query support. I'll try your branch tomorrow and report back. In the meanwhile I'd like to know if you are proposing this feature for the next stable release? Sampo On Tue,