Re: [Geotools-devel] Proposal to implement specific methods for Contrast Enhancement

2015-08-05 Thread Ian Turton
It's doable that way but I'm not really happy about storing a bunch of algorithm specific information at the ContrastEnhancer level. Or it leads to a nasty mix of org.opengis.style.ContrastMethod and org.geotools.styling.ContrastMethod and a whole bunch of messing about to try to make sure

Re: [Geotools-devel] Proposal to implement specific methods for Contrast Enhancement

2015-08-05 Thread Daniele Romagnoli
Hi Jody, I see your point about StyleVisitor implementations not covered by Abstract StyleVisitors which may break. However, as far as I can see from Ian changes on his branch, he has already made several visitors extending the AbstractStyleVisitor which implements the new method so that change

[Geotools-devel] Un-deprecating multi-font support in TextSymbolizer

2015-08-05 Thread Andrea Aime
Hi, I would like to un-deprecate all the multi-font methods that have been deprecated for a while in GeoTools, and that utterly broke multi-font support for a number of years. The methods in questions are in this interface:

Re: [Geotools-devel] Un-deprecating multi-font support in TextSymbolizer

2015-08-05 Thread Jody Garnett
Quick +1 for restoring the functionality. Additional comments inline ... The methods in questions are in this interface: https://github.com/geotools/geotools/blob/master/modules/library/api/src/main/java/org/geotools/styling/TextSymbolizer.java#L321 This is our GeoTools shadow read/write

Re: [Geotools-devel] Proposal to implement specific methods for Contrast Enhancement

2015-08-05 Thread Jody Garnett
There is a really different track here on how to modify the style interfaces in a safe manner (between this proposals and anime's. I made the suggestion for FeatureTypeStyle.getSortBy() ... and the answer was to consistently use the vendor options parameter map. Down a few levels here to

Re: [Geotools-devel] Proposal to implement specific methods for Contrast Enhancement

2015-08-05 Thread ian
On Wed, 5 Aug, 2015 at 5:27 PM, Jody Garnett jody.garn...@gmail.com wrote: There is a really different track here on how to modify the style interfaces in a safe manner (between this proposals and anime's. I made the suggestion for FeatureTypeStyle.getSortBy() ... and the answer was to

[Geotools-devel] Jenkins build is back to normal : GeoTools-Master ยป Sample data module #688

2015-08-05 Thread winbuild
See http://winbuild.geo-solutions.it/jenkins/job/GeoTools-Master/org.geotools$gt-sample-data/688/ -- ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net

[Geotools-devel] Jenkins build is back to normal : GeoTools-Master #688

2015-08-05 Thread winbuild
See http://winbuild.geo-solutions.it/jenkins/job/GeoTools-Master/688/changes -- ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net