Re: [Geotools-devel] Fixing GEOT-5194: App-schema can't find types defined in imported schemas

2015-08-24 Thread Jody Garnett
The use of System setProperty has evolved into our preferred way of soft-enabling a change of functionality (while allowing for backwards compatibility .. which is eventually removed). By contrast Hints (like for Query or StreamingRenderer) should be used to for configuration / dependency injectio

Re: [Geotools-devel] Fixing GEOT-5194: App-schema can't find types defined in imported schemas

2015-08-24 Thread Ben Caradoc-Davies
Stefano, I can confirm that, with PR 946 (your fix-GEOT-5194 branch), a full build of GT + GWC + GS + GS-app-schema-online-tests-against-postgis passes. (gt-jdbc-postgis online tests disabled because of GEOT-5197.) https://github.com/geotools/geotools/pull/946 I made one suggestion: add the Sys

Re: [Geotools-devel] Fixing GEOT-5194: App-schema can't find types defined in imported schemas

2015-08-24 Thread Stefano Costa
Hi Ben, thanks for answering. Let me know if there is anything I can do to have this merged before the feature freeze. I won't be available on the 27th nor the 28th, though. On Mon, Aug 24, 2015 at 11:25 PM, Ben Caradoc-Davies wrote: > And we certainly want a full GeoServer app-schema online te

Re: [Geotools-devel] Fixing GEOT-5194: App-schema can't find types defined in imported schemas

2015-08-24 Thread Stefano Costa
Hi Jody, I've just updated the PR following your suggestion: https://github.com/geotools/geotools/pull/946 The system property is called "org.geotools.xml.forceSchemaImport" and it's set to "false" by default. Didn't have time to measure the performance impact though. On Mon, Aug 24, 2015 at 7:55

[Geotools-devel] Release blocker? - (GEOT-5197) SQL syntax error in gt-jdbc-postgis PostgisDataStoreOnlineTest

2015-08-24 Thread Ben Caradoc-Davies
Jody, this may block the 14-beta release. Kind regards, Ben. Forwarded Message Subject:[Geotools-devel] [JIRA] (GEOT-5197) SQL syntax error in gt-jdbc-postgis PostgisDataStoreOnlineTest Date: Mon, 24 Aug 2015 23:02:01 +0200 (CEST) From: Ben Caradoc-Davies (JIRA) T

Re: [Geotools-devel] Fixing GEOT-5194: App-schema can't find types defined in imported schemas

2015-08-24 Thread Ben Caradoc-Davies
And we certainly want a full GeoServer app-schema online test run before any merges are contemplated. On 25/08/15 09:23, Ben Caradoc-Davies wrote: > Thanks, Jody. I hope to give this issue some attention later this week > or early next. -- Ben Caradoc-Davies Director Transient Software Limited

Re: [Geotools-devel] Fixing GEOT-5194: App-schema can't find types defined in imported schemas

2015-08-24 Thread Ben Caradoc-Davies
Thanks, Jody. I hope to give this issue some attention later this week or early next. On 25/08/15 05:55, Jody Garnett wrote: > I believe Ben is unavailable this week (he indicated he would not be in > tomorrows meeting). > > I am comfortable with the approach Andrea described (importing when > no

[Geotools-devel] geotools-master-online has new unnoticed failures

2015-08-24 Thread Ben Caradoc-Davies
Because we left the geotools-master-online build on ares Jenkins failing, we were not notified when new online failures were introduced. This is a continuous integration antipattern. I have just filed a new Jira issue for a gt-jdbc-postgis failure that was not failing the last time I ran it loc

Re: [Geotools-devel] Time to consider a move to Java 8?

2015-08-24 Thread Ben Caradoc-Davies
+1 to switch to Java 8 for GeoTools 15 (unless a dev or user has a compelling objection). On 23/08/15 01:10, Andrea Aime wrote: > Hi, > I was wondering, when do you think we should switch the whole project to > Java 8 as the minimum? > > Java 7 has reached end of life in May 2015, in other words,

[Geotools-devel] [JIRA] (GEOT-5197) SQL syntax error in gt-jdbc-postgis PostgisDataStoreOnlineTest

2015-08-24 Thread Ben Caradoc-Davies (JIRA)
Title: Message Title Ben Caradoc-Davies created an issue

Re: [Geotools-devel] Time to consider a move to Java 8?

2015-08-24 Thread Kevin Smith
I'm all for this. GeoWebCache has built just fine under Java 8 just fine when I've tested it so I have no problem upping GWC's requirements to Java 8. On 23 August 2015 at 02:22, Christian Mueller < christian.muel...@os-solutions.at> wrote: > Hi all > > IBM Java 8 is ready for download, no proble

Re: [Geotools-devel] Backport GEOT-5186 (DB2 SELECTIVITY CLAUSE) to 13.x

2015-08-24 Thread Jody Garnett
The pull request discussion had a proposal: *SELECTIVITY: Value of true will inject SELECTIVITY 0.0001 hint to the optimizer to raise the priority of the spatial index. Default is false.* The alternative would be: *SPATIAL_INDEX_PRIORITY: Value of

Re: [Geotools-devel] Fixing GEOT-5194: App-schema can't find types defined in imported schemas

2015-08-24 Thread Jody Garnett
I believe Ben is unavailable this week (he indicated he would not be in tomorrows meeting). I am comfortable with the approach Andrea described (importing when no element / type definition are provided - as a nice minimal change), if you like you could make a setting or system property to change t

[Geotools-devel] [JIRA] (GEOT-5196) GridGeometry2D's world to grid function translating wrong

2015-08-24 Thread Andrew Cassidy (JIRA)
Title: Message Title Andrew Cassidy created an issue

[Geotools-devel] [JIRA] (GEOT-5195) Have PropertyDataStore honor the geometry factory and cs factory hints

2015-08-24 Thread Andrea Aime [Administrator] (JIRA)
Title: Message Title Andrea Aime [Administrator] created an issue

Re: [Geotools-devel] Fixing GEOT-5194: App-schema can't find types defined in imported schemas

2015-08-24 Thread Andrea Aime
Hi Stefano, those are good observations. Let's hear what Ben has to say? :-) Cheers Andrea On Mon, Aug 24, 2015 at 12:17 PM, Stefano Costa < stefano.co...@geo-solutions.it> wrote: > > > On Mon, Aug 24, 2015 at 10:46 AM, Andrea Aime < > andrea.a...@geo-solutions.it> wrote: > >> On Mon, Aug 24, 20

Re: [Geotools-devel] Fixing GEOT-5194: App-schema can't find types defined in imported schemas

2015-08-24 Thread Stefano Costa
On Mon, Aug 24, 2015 at 10:46 AM, Andrea Aime wrote: > On Mon, Aug 24, 2015 at 9:45 AM, Stefano Costa < > stefano.co...@geo-solutions.it> wrote: > >> The fix affects org.geotools.xml.Schemas and essentially forces the >> import of external schemas (if any) when the schema being parsed contains >>

Re: [Geotools-devel] Fixing GEOT-5194: App-schema can't find types defined in imported schemas

2015-08-24 Thread Andrea Aime
On Mon, Aug 24, 2015 at 9:45 AM, Stefano Costa < stefano.co...@geo-solutions.it> wrote: > The fix affects org.geotools.xml.Schemas and essentially forces the import > of external schemas (if any) when the schema being parsed contains itself > no element / type definition. > I'm wondering if it wo

[Geotools-devel] Jenkins build is back to normal : geotools-12.x #119

2015-08-24 Thread monitor
See -- ___ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/l

[Geotools-devel] Fixing GEOT-5194: App-schema can't find types defined in imported schemas

2015-08-24 Thread Stefano Costa
Dear developers, I experienced issues trying to build an app-schema mapping configuration based on GeoSciML 3.2 schemas, namely http://schemas.geosciml.org/geosciml/3.2/geosciml.xsd (got "no GeologicUnit element found" exception). After some investigation, I concluded that the problem arises when