Thanks, proposal is clear, scope/purpose clear, technical details are
easier to follow with class diagram.
+1
And it looks like you are pretty much done the work, except for user docs...
--
Jody Garnett
On 21 June 2016 at 17:04, Devon Tucker wrote:
> Yes, it's ready
Yes, it's ready for review :D
On Tue, Jun 21, 2016 at 5:01 PM, Jody Garnett
wrote:
> We can always squash the commits when merging to master.
>
> Is the proposal ready for review now?
>
> --
> Jody Garnett
>
> On 21 June 2016 at 16:55, Devon Tucker
We can always squash the commits when merging to master.
Is the proposal ready for review now?
--
Jody Garnett
On 21 June 2016 at 16:55, Devon Tucker wrote:
> Ok so after going down the road of using the PropertiesCollector interface
> for doing the granule geometry
Ok so after going down the road of using the PropertiesCollector interface
for doing the granule geometry handling and decided to go with my original
plan of creating a separate interface for this. I have updated the proposal
accordingly.
Also, I created a pull request for reference, since it
Title: Message Title
Andrea Aime
Title: Message Title
Andrea Aime